[jira] [Commented] (CASSANDRA-11086) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183070#comment-15183070
]
Benjamin Lerer commented on CASSANDRA-11086:
+1
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-11086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11086
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Michael Shuler
>Assignee: Jason Brown
>Priority: Minor
> Fix For: 3.x
>
>
> REF = origin/trunk
> COMMIT = 7230a66318ce8add742959d095900d5870689f0c
> {noformat}
> # 1/27/16 8:50:25 PM UTC
> # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp
> 2000, 2013. All rights reserved.
> --
> 1. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/metrics/TableMetrics.java
> (at line 338)
> return
> computeCompressionRatio(Iterables.concat(Iterables.transform(Keyspace.all(),
> ^^^
> The method computeCompressionRatio(Iterable) in the type
> TableMetrics is not applicable for the arguments (Iterable)
> --
> --
> 2. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java
> (at line 141)
> return channel.socket();
>
> Potential resource leak: 'channel' may not be closed at this location
> --
> --
> 3. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskBlock.java
> (at line 93)
> return cast(dup);
> ^
> Potential resource leak: 'dup' may not be closed at this location
> --
> --
> 4. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 142)
> indexFile = new MappedBuffer(new ChannelProxy(indexPath,
> backingFile.getChannel()));
>
> ^
> Potential resource leak: '' may not be closed
> --
> 5. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 161)
> throw new FSReadError(e, index);
>
> Potential resource leak: 'backingFile' may not be closed at this location
> --
> 6. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 249)
> RangeIterator range = searchRange(e);
> ^
> Potential resource leak: 'range' may not be closed
> --
> --
> 7. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndexBuilder.java
> (at line 286)
> throw new FSWriteError(e, file);
>
> Potential resource leak: 'out' may not be closed at this location
> --
> --
> 8. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 284)
> OnDiskIndex last = scheduleSegmentFlush(false).call();
>
> Potential resource leak: 'last' may not be closed
> --
> 9. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 293)
> OnDiskIndex part = Futures.getUnchecked(f);
>
> Potential resource leak: 'part' may not be closed
> --
> --
> 10. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 118)
> RangeIterator keyIterator = index.search(e);
> ^^^
> Potential resource leak: 'keyIterator' may not be closed
> --
> 11. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 148)
> return ranges == null ? null : new TermIterator(e, ranges,
> referencedIndexes);
>
> ^^
> Potential resource leak: 'ranges' may not be closed at this location
> --
> 12. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 156)
> throw ex;
> ^
> Potential resource leak: 'memtableIterator' may not be closed at this location
> --
> --
> 13. ERROR i
[jira] [Commented] (CASSANDRA-11086) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175751#comment-15175751
]
Jason Brown commented on CASSANDRA-11086:
-
OK, added annotations for all of SASI.
|| trunk ||
| [branch|https://github.com/jasobrown/cassandra/tree/11086_trunk] |
|
[testall|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-11086_trunk-testall/]
|
|
[dtest|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-11086_trunk-dtest/]
|
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-11086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11086
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Michael Shuler
>Assignee: Jason Brown
>Priority: Minor
> Fix For: 3.x
>
>
> REF = origin/trunk
> COMMIT = 7230a66318ce8add742959d095900d5870689f0c
> {noformat}
> # 1/27/16 8:50:25 PM UTC
> # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp
> 2000, 2013. All rights reserved.
> --
> 1. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/metrics/TableMetrics.java
> (at line 338)
> return
> computeCompressionRatio(Iterables.concat(Iterables.transform(Keyspace.all(),
> ^^^
> The method computeCompressionRatio(Iterable) in the type
> TableMetrics is not applicable for the arguments (Iterable)
> --
> --
> 2. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java
> (at line 141)
> return channel.socket();
>
> Potential resource leak: 'channel' may not be closed at this location
> --
> --
> 3. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskBlock.java
> (at line 93)
> return cast(dup);
> ^
> Potential resource leak: 'dup' may not be closed at this location
> --
> --
> 4. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 142)
> indexFile = new MappedBuffer(new ChannelProxy(indexPath,
> backingFile.getChannel()));
>
> ^
> Potential resource leak: '' may not be closed
> --
> 5. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 161)
> throw new FSReadError(e, index);
>
> Potential resource leak: 'backingFile' may not be closed at this location
> --
> 6. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 249)
> RangeIterator range = searchRange(e);
> ^
> Potential resource leak: 'range' may not be closed
> --
> --
> 7. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndexBuilder.java
> (at line 286)
> throw new FSWriteError(e, file);
>
> Potential resource leak: 'out' may not be closed at this location
> --
> --
> 8. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 284)
> OnDiskIndex last = scheduleSegmentFlush(false).call();
>
> Potential resource leak: 'last' may not be closed
> --
> 9. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 293)
> OnDiskIndex part = Futures.getUnchecked(f);
>
> Potential resource leak: 'part' may not be closed
> --
> --
> 10. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 118)
> RangeIterator keyIterator = index.search(e);
> ^^^
> Potential resource leak: 'keyIterator' may not be closed
> --
> 11. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 148)
> return ranges == null ? null : new TermIterator(e, ranges,
> referencedIndexes);
>
> ^^
> Potential resource leak: 'ranges' may not be closed at this location
> ---
[jira] [Commented] (CASSANDRA-11086) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172807#comment-15172807
]
Jason Brown commented on CASSANDRA-11086:
-
Will do
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-11086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11086
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Michael Shuler
>Assignee: Jason Brown
>Priority: Minor
> Fix For: 3.x
>
>
> REF = origin/trunk
> COMMIT = 7230a66318ce8add742959d095900d5870689f0c
> {noformat}
> # 1/27/16 8:50:25 PM UTC
> # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp
> 2000, 2013. All rights reserved.
> --
> 1. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/metrics/TableMetrics.java
> (at line 338)
> return
> computeCompressionRatio(Iterables.concat(Iterables.transform(Keyspace.all(),
> ^^^
> The method computeCompressionRatio(Iterable) in the type
> TableMetrics is not applicable for the arguments (Iterable)
> --
> --
> 2. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java
> (at line 141)
> return channel.socket();
>
> Potential resource leak: 'channel' may not be closed at this location
> --
> --
> 3. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskBlock.java
> (at line 93)
> return cast(dup);
> ^
> Potential resource leak: 'dup' may not be closed at this location
> --
> --
> 4. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 142)
> indexFile = new MappedBuffer(new ChannelProxy(indexPath,
> backingFile.getChannel()));
>
> ^
> Potential resource leak: '' may not be closed
> --
> 5. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 161)
> throw new FSReadError(e, index);
>
> Potential resource leak: 'backingFile' may not be closed at this location
> --
> 6. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 249)
> RangeIterator range = searchRange(e);
> ^
> Potential resource leak: 'range' may not be closed
> --
> --
> 7. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndexBuilder.java
> (at line 286)
> throw new FSWriteError(e, file);
>
> Potential resource leak: 'out' may not be closed at this location
> --
> --
> 8. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 284)
> OnDiskIndex last = scheduleSegmentFlush(false).call();
>
> Potential resource leak: 'last' may not be closed
> --
> 9. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 293)
> OnDiskIndex part = Futures.getUnchecked(f);
>
> Potential resource leak: 'part' may not be closed
> --
> --
> 10. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 118)
> RangeIterator keyIterator = index.search(e);
> ^^^
> Potential resource leak: 'keyIterator' may not be closed
> --
> 11. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 148)
> return ranges == null ? null : new TermIterator(e, ranges,
> referencedIndexes);
>
> ^^
> Potential resource leak: 'ranges' may not be closed at this location
> --
> 12. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 156)
> throw ex;
> ^
> Potential resource leak: 'memtableIterator' may not be closed at this location
> --
> --
> 13. ERROR in
[jira] [Commented] (CASSANDRA-11086) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171751#comment-15171751
]
Benjamin Lerer commented on CASSANDRA-11086:
[~jasobrown] could you also add some annotations to cover the SASI code?
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-11086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11086
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Michael Shuler
>Assignee: Jason Brown
>Priority: Minor
> Fix For: 3.x
>
>
> REF = origin/trunk
> COMMIT = 7230a66318ce8add742959d095900d5870689f0c
> {noformat}
> # 1/27/16 8:50:25 PM UTC
> # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp
> 2000, 2013. All rights reserved.
> --
> 1. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/metrics/TableMetrics.java
> (at line 338)
> return
> computeCompressionRatio(Iterables.concat(Iterables.transform(Keyspace.all(),
> ^^^
> The method computeCompressionRatio(Iterable) in the type
> TableMetrics is not applicable for the arguments (Iterable)
> --
> --
> 2. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java
> (at line 141)
> return channel.socket();
>
> Potential resource leak: 'channel' may not be closed at this location
> --
> --
> 3. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskBlock.java
> (at line 93)
> return cast(dup);
> ^
> Potential resource leak: 'dup' may not be closed at this location
> --
> --
> 4. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 142)
> indexFile = new MappedBuffer(new ChannelProxy(indexPath,
> backingFile.getChannel()));
>
> ^
> Potential resource leak: '' may not be closed
> --
> 5. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 161)
> throw new FSReadError(e, index);
>
> Potential resource leak: 'backingFile' may not be closed at this location
> --
> 6. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 249)
> RangeIterator range = searchRange(e);
> ^
> Potential resource leak: 'range' may not be closed
> --
> --
> 7. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndexBuilder.java
> (at line 286)
> throw new FSWriteError(e, file);
>
> Potential resource leak: 'out' may not be closed at this location
> --
> --
> 8. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 284)
> OnDiskIndex last = scheduleSegmentFlush(false).call();
>
> Potential resource leak: 'last' may not be closed
> --
> 9. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 293)
> OnDiskIndex part = Futures.getUnchecked(f);
>
> Potential resource leak: 'part' may not be closed
> --
> --
> 10. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 118)
> RangeIterator keyIterator = index.search(e);
> ^^^
> Potential resource leak: 'keyIterator' may not be closed
> --
> 11. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 148)
> return ranges == null ? null : new TermIterator(e, ranges,
> referencedIndexes);
>
> ^^
> Potential resource leak: 'ranges' may not be closed at this location
> --
> 12. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 156)
> throw ex;
> ^
> Potential resource leak: 'memtableIterator' may
[jira] [Commented] (CASSANDRA-11086) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163090#comment-15163090
]
Jason Brown commented on CASSANDRA-11086:
-
Added a few {{SupressWarning}} annotations to where they are appropriate (and
correct), as well as add try-with-resources blocks in two places.
||trunk||
|[branch|https://github.com/apache/cassandra/compare/trunk...jasobrown:11086_trunk]|
|[testall|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-11086_trunk-dtest/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-11086_trunk-testall/]|
Waiting for tests to finish execution...
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-11086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11086
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Michael Shuler
>Assignee: Benjamin Lerer
>Priority: Minor
> Fix For: 3.x
>
>
> REF = origin/trunk
> COMMIT = 7230a66318ce8add742959d095900d5870689f0c
> {noformat}
> # 1/27/16 8:50:25 PM UTC
> # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp
> 2000, 2013. All rights reserved.
> --
> 1. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/metrics/TableMetrics.java
> (at line 338)
> return
> computeCompressionRatio(Iterables.concat(Iterables.transform(Keyspace.all(),
> ^^^
> The method computeCompressionRatio(Iterable) in the type
> TableMetrics is not applicable for the arguments (Iterable)
> --
> --
> 2. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java
> (at line 141)
> return channel.socket();
>
> Potential resource leak: 'channel' may not be closed at this location
> --
> --
> 3. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskBlock.java
> (at line 93)
> return cast(dup);
> ^
> Potential resource leak: 'dup' may not be closed at this location
> --
> --
> 4. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 142)
> indexFile = new MappedBuffer(new ChannelProxy(indexPath,
> backingFile.getChannel()));
>
> ^
> Potential resource leak: '' may not be closed
> --
> 5. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 161)
> throw new FSReadError(e, index);
>
> Potential resource leak: 'backingFile' may not be closed at this location
> --
> 6. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 249)
> RangeIterator range = searchRange(e);
> ^
> Potential resource leak: 'range' may not be closed
> --
> --
> 7. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndexBuilder.java
> (at line 286)
> throw new FSWriteError(e, file);
>
> Potential resource leak: 'out' may not be closed at this location
> --
> --
> 8. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 284)
> OnDiskIndex last = scheduleSegmentFlush(false).call();
>
> Potential resource leak: 'last' may not be closed
> --
> 9. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 293)
> OnDiskIndex part = Futures.getUnchecked(f);
>
> Potential resource leak: 'part' may not be closed
> --
> --
> 10. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 118)
> RangeIterator keyIterator = index.search(e);
> ^^^
> Potential resource leak: 'keyIterator' may not be closed
> --
> 11. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 148)
> return ranges == null ? null : new TermIterator(e, ranges,
> referencedIndexes);
>
>
[jira] [Commented] (CASSANDRA-11086) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122151#comment-15122151
]
Pavel Yaskevich commented on CASSANDRA-11086:
-
[~blerer] Regarding those 2 warnings - they shouldn't be a problem since we
have a fail-safe mechanism built-in in QueryController, which tracks all of the
resources associated with query and closes the ones which weren't e.g. because
of an exception or something similar.
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-11086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11086
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Michael Shuler
>Assignee: Benjamin Lerer
>Priority: Minor
> Fix For: 3.x
>
>
> REF = origin/trunk
> COMMIT = 7230a66318ce8add742959d095900d5870689f0c
> {noformat}
> # 1/27/16 8:50:25 PM UTC
> # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp
> 2000, 2013. All rights reserved.
> --
> 1. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/metrics/TableMetrics.java
> (at line 338)
> return
> computeCompressionRatio(Iterables.concat(Iterables.transform(Keyspace.all(),
> ^^^
> The method computeCompressionRatio(Iterable) in the type
> TableMetrics is not applicable for the arguments (Iterable)
> --
> --
> 2. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java
> (at line 141)
> return channel.socket();
>
> Potential resource leak: 'channel' may not be closed at this location
> --
> --
> 3. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskBlock.java
> (at line 93)
> return cast(dup);
> ^
> Potential resource leak: 'dup' may not be closed at this location
> --
> --
> 4. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 142)
> indexFile = new MappedBuffer(new ChannelProxy(indexPath,
> backingFile.getChannel()));
>
> ^
> Potential resource leak: '' may not be closed
> --
> 5. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 161)
> throw new FSReadError(e, index);
>
> Potential resource leak: 'backingFile' may not be closed at this location
> --
> 6. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 249)
> RangeIterator range = searchRange(e);
> ^
> Potential resource leak: 'range' may not be closed
> --
> --
> 7. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndexBuilder.java
> (at line 286)
> throw new FSWriteError(e, file);
>
> Potential resource leak: 'out' may not be closed at this location
> --
> --
> 8. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 284)
> OnDiskIndex last = scheduleSegmentFlush(false).call();
>
> Potential resource leak: 'last' may not be closed
> --
> 9. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 293)
> OnDiskIndex part = Futures.getUnchecked(f);
>
> Potential resource leak: 'part' may not be closed
> --
> --
> 10. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 118)
> RangeIterator keyIterator = index.search(e);
> ^^^
> Potential resource leak: 'keyIterator' may not be closed
> --
> 11. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 148)
> return ranges == null ? null : new TermIterator(e, ranges,
> referencedIndexes);
>
> ^^
> Potential resource leak: 'ranges' may not be closed at this location
> --
> 12. ERROR in
> /var/lib/
[jira] [Commented] (CASSANDRA-11086) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121524#comment-15121524
]
Jason Brown commented on CASSANDRA-11086:
-
I'll take a look at the commitlog/encryption related entries.
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-11086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11086
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Michael Shuler
>Assignee: Benjamin Lerer
>Priority: Minor
> Fix For: 3.x
>
>
> REF = origin/trunk
> COMMIT = 7230a66318ce8add742959d095900d5870689f0c
> {noformat}
> # 1/27/16 8:50:25 PM UTC
> # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp
> 2000, 2013. All rights reserved.
> --
> 1. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/metrics/TableMetrics.java
> (at line 338)
> return
> computeCompressionRatio(Iterables.concat(Iterables.transform(Keyspace.all(),
> ^^^
> The method computeCompressionRatio(Iterable) in the type
> TableMetrics is not applicable for the arguments (Iterable)
> --
> --
> 2. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java
> (at line 141)
> return channel.socket();
>
> Potential resource leak: 'channel' may not be closed at this location
> --
> --
> 3. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskBlock.java
> (at line 93)
> return cast(dup);
> ^
> Potential resource leak: 'dup' may not be closed at this location
> --
> --
> 4. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 142)
> indexFile = new MappedBuffer(new ChannelProxy(indexPath,
> backingFile.getChannel()));
>
> ^
> Potential resource leak: '' may not be closed
> --
> 5. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 161)
> throw new FSReadError(e, index);
>
> Potential resource leak: 'backingFile' may not be closed at this location
> --
> 6. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 249)
> RangeIterator range = searchRange(e);
> ^
> Potential resource leak: 'range' may not be closed
> --
> --
> 7. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndexBuilder.java
> (at line 286)
> throw new FSWriteError(e, file);
>
> Potential resource leak: 'out' may not be closed at this location
> --
> --
> 8. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 284)
> OnDiskIndex last = scheduleSegmentFlush(false).call();
>
> Potential resource leak: 'last' may not be closed
> --
> 9. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 293)
> OnDiskIndex part = Futures.getUnchecked(f);
>
> Potential resource leak: 'part' may not be closed
> --
> --
> 10. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 118)
> RangeIterator keyIterator = index.search(e);
> ^^^
> Potential resource leak: 'keyIterator' may not be closed
> --
> 11. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 148)
> return ranges == null ? null : new TermIterator(e, ranges,
> referencedIndexes);
>
> ^^
> Potential resource leak: 'ranges' may not be closed at this location
> --
> 12. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 156)
> throw ex;
> ^
> Potential resource leak: 'memtableIterator' may not be closed
[jira] [Commented] (CASSANDRA-11086) trunk eclipse-warnings
[
https://issues.apache.org/jira/browse/CASSANDRA-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121496#comment-15121496
]
Benjamin Lerer commented on CASSANDRA-11086:
Most of the warning seems to be false alert. 6 of them have already been
adressed in CASSANDRA-11086.
The only places where there might be some real problems are:
* In {{RangeIntersectionIterator}} (line 146) where it looks like the range can
leak if it is not overlapping
* In {{Operation}} where the right and left operations are not closed within
close.
[~xedin] could you check if those 2 points are some real leaks? I do not
understand yet well enough the SASI code.
> trunk eclipse-warnings
> --
>
> Key: CASSANDRA-11086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11086
> Project: Cassandra
> Issue Type: Bug
> Components: Testing
>Reporter: Michael Shuler
>Assignee: Benjamin Lerer
>Priority: Minor
> Fix For: 3.x
>
>
> REF = origin/trunk
> COMMIT = 7230a66318ce8add742959d095900d5870689f0c
> {noformat}
> # 1/27/16 8:50:25 PM UTC
> # Eclipse Compiler for Java(TM) v20150120-1634, 3.10.2, Copyright IBM Corp
> 2000, 2013. All rights reserved.
> --
> 1. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/metrics/TableMetrics.java
> (at line 338)
> return
> computeCompressionRatio(Iterables.concat(Iterables.transform(Keyspace.all(),
> ^^^
> The method computeCompressionRatio(Iterable) in the type
> TableMetrics is not applicable for the arguments (Iterable)
> --
> --
> 2. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/net/OutboundTcpConnectionPool.java
> (at line 141)
> return channel.socket();
>
> Potential resource leak: 'channel' may not be closed at this location
> --
> --
> 3. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskBlock.java
> (at line 93)
> return cast(dup);
> ^
> Potential resource leak: 'dup' may not be closed at this location
> --
> --
> 4. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 142)
> indexFile = new MappedBuffer(new ChannelProxy(indexPath,
> backingFile.getChannel()));
>
> ^
> Potential resource leak: '' may not be closed
> --
> 5. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 161)
> throw new FSReadError(e, index);
>
> Potential resource leak: 'backingFile' may not be closed at this location
> --
> 6. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndex.java
> (at line 249)
> RangeIterator range = searchRange(e);
> ^
> Potential resource leak: 'range' may not be closed
> --
> --
> 7. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/OnDiskIndexBuilder.java
> (at line 286)
> throw new FSWriteError(e, file);
>
> Potential resource leak: 'out' may not be closed at this location
> --
> --
> 8. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 284)
> OnDiskIndex last = scheduleSegmentFlush(false).call();
>
> Potential resource leak: 'last' may not be closed
> --
> 9. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/disk/PerSSTableIndexWriter.java
> (at line 293)
> OnDiskIndex part = Futures.getUnchecked(f);
>
> Potential resource leak: 'part' may not be closed
> --
> --
> 10. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 118)
> RangeIterator keyIterator = index.search(e);
> ^^^
> Potential resource leak: 'keyIterator' may not be closed
> --
> 11. ERROR in
> /var/lib/jenkins/jobs/trunk_eclipse-warnings/workspace/src/java/org/apache/cassandra/index/sasi/TermIterator.java
> (at line 148)
> return ranges == null ? null : new TermIterator(e, ranges,
> referencedIndexes);
>
