[jira] [Commented] (CASSANDRA-11905) Index building fails to start CFS.readOrdering when reading
[
https://issues.apache.org/jira/browse/CASSANDRA-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303901#comment-15303901
]
Stefania commented on CASSANDRA-11905:
--
+1 on the [3.0 patch|https://github.com/pcmanus/cassandra/commits/11905-3.0];
the [3.7 patch|https://github.com/pcmanus/cassandra/commits/11905-3.7] also
looks OK from a quick look, but I will take another look first thing on Monday,
as well as checking any CI failures. I agree on pushing it to 3.6 if we can,
thank you for producing a patch so quickly!
> Index building fails to start CFS.readOrdering when reading
> ---
>
> Key: CASSANDRA-11905
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11905
> Project: Cassandra
> Issue Type: Bug
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
>Priority: Critical
> Fix For: 3.0.x, 3.x
>
>
> This code for indexing partition when building index in 3.0 is:
> {noformat}
> SinglePartitionReadCommand cmd =
> SinglePartitionReadCommand.fullPartitionRead(cfs.metadata,
> FBUtilities.nowInSeconds(), key);
> try (OpOrder.Group opGroup = cfs.keyspace.writeOrder.start();
> UnfilteredRowIterator partition = cmd.queryMemtableAndDisk(cfs,
> opGroup))
> {
> cfs.indexManager.indexPartition(partition, opGroup, indexes,
> cmd.nowInSec());
> }
> {noformat}
> which is clearly incorrect as the {{OpOrder}} that {{queryMemtableAndDisk}}
> expects is the one from {{cfs.readOrdering}}, not the one for writes on the
> keyspace.
> This wasn't a problem prior to 3.0 as the similar code was using the pager,
> which ended up properly taking the read {{OpOrder}} internally but I messed
> this up in CASSANDRA-8099.
> Thanks to [~Stefania] for pointing that out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-11905) Index building fails to start CFS.readOrdering when reading
[
https://issues.apache.org/jira/browse/CASSANDRA-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306252#comment-15306252
]
Stefania commented on CASSANDRA-11905:
--
There is a typo at line 122 of {{SinglePartitionSliceCommandTest}}, it should
be {{pIter.next()}} rather than {{partitionIterator.next()}}. This is causing 2
CI failures, the remaining failing tests are all unrelated known failures.
+1 once the typo in the test is fixed.
> Index building fails to start CFS.readOrdering when reading
> ---
>
> Key: CASSANDRA-11905
> URL: https://issues.apache.org/jira/browse/CASSANDRA-11905
> Project: Cassandra
> Issue Type: Bug
>Reporter: Sylvain Lebresne
>Assignee: Sylvain Lebresne
>Priority: Critical
> Fix For: 3.0.x, 3.x
>
>
> This code for indexing partition when building index in 3.0 is:
> {noformat}
> SinglePartitionReadCommand cmd =
> SinglePartitionReadCommand.fullPartitionRead(cfs.metadata,
> FBUtilities.nowInSeconds(), key);
> try (OpOrder.Group opGroup = cfs.keyspace.writeOrder.start();
> UnfilteredRowIterator partition = cmd.queryMemtableAndDisk(cfs,
> opGroup))
> {
> cfs.indexManager.indexPartition(partition, opGroup, indexes,
> cmd.nowInSec());
> }
> {noformat}
> which is clearly incorrect as the {{OpOrder}} that {{queryMemtableAndDisk}}
> expects is the one from {{cfs.readOrdering}}, not the one for writes on the
> keyspace.
> This wasn't a problem prior to 3.0 as the similar code was using the pager,
> which ended up properly taking the read {{OpOrder}} internally but I messed
> this up in CASSANDRA-8099.
> Thanks to [~Stefania] for pointing that out.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
