[jira] [Commented] (CASSANDRA-12205) nodetool tablestats sstable count missing.

2016-08-08 Thread Joshua McKenzie (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15412037#comment-15412037
 ] 

Joshua McKenzie commented on CASSANDRA-12205:
-

[~cam888eron]: That was an oversight on my part. When I re-opened the issue I 
neglected to delete the JIRA link indicating the incorrect duplication.

Sorry for the confusion.

> nodetool tablestats sstable count missing.
> --
>
> Key: CASSANDRA-12205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12205
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Cassandra 3.7
>Reporter: Cameron MacMinn
>Assignee: Edward Ribeiro
> Fix For: 3.9
>
> Attachments: CASSANDRA-12205.patch, bad.txt, good.txt
>
>
> As a user, I have used  nodetool cfstats  since v2.1. The most useful line is 
> the 1 like 'SSTable count: 12'.
> As a user, I want v3.7  nodetool tablestats  to continue showing SStable 
> count. At the moment, SStable count is missing from the output.
> Examples attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12205) nodetool tablestats sstable count missing.

2016-08-05 Thread Edward Ribeiro (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409542#comment-15409542
 ] 

Edward Ribeiro commented on CASSANDRA-12205:


No problem, Cameron. This patch has been committed on Cassandra 3.9 and the 
issue marked as fixed. Thanks for reporting! :)

> nodetool tablestats sstable count missing.
> --
>
> Key: CASSANDRA-12205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12205
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Cassandra 3.7
>Reporter: Cameron MacMinn
>Assignee: Edward Ribeiro
> Fix For: 3.9
>
> Attachments: CASSANDRA-12205.patch, bad.txt, good.txt
>
>
> As a user, I have used  nodetool cfstats  since v2.1. The most useful line is 
> the 1 like 'SSTable count: 12'.
> As a user, I want v3.7  nodetool tablestats  to continue showing SStable 
> count. At the moment, SStable count is missing from the output.
> Examples attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12205) nodetool tablestats sstable count missing.

2016-08-05 Thread Cameron MacMinn (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409500#comment-15409500
 ] 

Cameron MacMinn commented on CASSANDRA-12205:
-

As a user, it is not a duplicate.

When I 1st saw that, I assumed it meant duplicate from non-user perspective, in 
the source code, patches, etc. If you cannot find any such duplication, could 
you separate these into 2 issues? (Please let me know if I should update my 
Jira 12205 problem report.)

Thanks again to you and your colleagues for fixing missing SStable count.


> nodetool tablestats sstable count missing.
> --
>
> Key: CASSANDRA-12205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12205
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Cassandra 3.7
>Reporter: Cameron MacMinn
>Assignee: Edward Ribeiro
> Fix For: 3.9
>
> Attachments: CASSANDRA-12205.patch, bad.txt, good.txt
>
>
> As a user, I have used  nodetool cfstats  since v2.1. The most useful line is 
> the 1 like 'SSTable count: 12'.
> As a user, I want v3.7  nodetool tablestats  to continue showing SStable 
> count. At the moment, SStable count is missing from the output.
> Examples attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12205) nodetool tablestats sstable count missing.

2016-08-04 Thread Edward Ribeiro (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408665#comment-15408665
 ] 

Edward Ribeiro commented on CASSANDRA-12205:


Um... this issue is now marked as a duplication of  CASSANDRA-11880, but it 
looks like that issue is adding the number of tables (column families) to the 
stats collections while this one is restoring the SSTable counting that was 
removed at C* 3.7, right? I mean, this is is {{related}} to CASSANDRA-11880 
instead of duplication, afaik. wdyt?

> nodetool tablestats sstable count missing.
> --
>
> Key: CASSANDRA-12205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12205
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Cassandra 3.7
>Reporter: Cameron MacMinn
>Assignee: Edward Ribeiro
> Fix For: 3.x
>
> Attachments: CASSANDRA-12205.patch, bad.txt, good.txt
>
>
> As a user, I have used  nodetool cfstats  since v2.1. The most useful line is 
> the 1 like 'SSTable count: 12'.
> As a user, I want v3.7  nodetool tablestats  to continue showing SStable 
> count. At the moment, SStable count is missing from the output.
> Examples attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12205) nodetool tablestats sstable count missing.

2016-08-04 Thread Cameron MacMinn (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408488#comment-15408488
 ] 

Cameron MacMinn commented on CASSANDRA-12205:
-

Thanks guys, much appreciated. :-)


> nodetool tablestats sstable count missing.
> --
>
> Key: CASSANDRA-12205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12205
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Cassandra 3.7
>Reporter: Cameron MacMinn
> Attachments: CASSANDRA-12205.patch, bad.txt, good.txt
>
>
> As a user, I have used  nodetool cfstats  since v2.1. The most useful line is 
> the 1 like 'SSTable count: 12'.
> As a user, I want v3.7  nodetool tablestats  to continue showing SStable 
> count. At the moment, SStable count is missing from the output.
> Examples attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12205) nodetool tablestats sstable count missing.

2016-07-18 Thread Wei Deng (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382625#comment-15382625
 ] 

Wei Deng commented on CASSANDRA-12205:
--

This is [the 
commit|https://github.com/apache/cassandra/commit/5805a76ca092648146ba71af744c8bce357bdc39]
 (intended to address CASSANDRA-5977) that introduced the regression. 

> nodetool tablestats sstable count missing.
> --
>
> Key: CASSANDRA-12205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12205
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Cassandra 3.7
>Reporter: Cameron MacMinn
> Attachments: bad.txt, good.txt
>
>
> As a user, I have used  nodetool cfstats  since v2.1. The most useful line is 
> the 1 like 'SSTable count: 12'.
> As a user, I want v3.7  nodetool tablestats  to continue showing SStable 
> count. At the moment, SStable count is missing from the output.
> Examples attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CASSANDRA-12205) nodetool tablestats sstable count missing.

2016-07-18 Thread Wei Deng (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-12205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381774#comment-15381774
 ] 

Wei Deng commented on CASSANDRA-12205:
--

[~JoshuaMcKenzie] Are we sure they're the same thing? 11880 seems to add a 
metrics to track how many CQL tables in tablestats output and is a minor 
enhancement. This one is talking about the missing SSTable counts (which IMHO 
is a regression).

It appears [this 
merge|https://github.com/apache/cassandra/commit/f000ff08fde7a9b477d26ca1eea9bbe550564090]
 somehow took out the "SSTable count" output as shown below:

{noformat}
$ git log TableStats.java | egrep '^commit '
commit 54cbdd73c46f85113d947e702bec33ef43d59b8d
commit f55d2d494fe6f4e170373a341a89eeda5ddf2fa9
commit f000ff08fde7a9b477d26ca1eea9bbe550564090
commit 4aaf2b34f0ed76523e738937125598f63651354b
commit 39b86e3792721cfc8aeef639cfd4ac06c56288e8
commit 9b47dd50fceb552acd3ca77cff88f4041511bf48
commit 5805a76ca092648146ba71af744c8bce357bdc39
commit db68ac9fd791d777df0241ef9bd381eca46bbd20
commit 07ddb8a2198185bff4aa1215acdbb07cf3b18b66
commit 66d3428e3fe64851fa7587ee69b53e20bb7c09b5
commit 0bd5170c4ff55c9f3307602de031d77883731883
commit 868e7209d8aed969fa62e1813ad99dec70e4b527
commit bf51f24a6ffd01f330a6251e3a62ad32a1f31b9a
$ git diff 4aaf2b34f0ed76523e738937125598f63651354b 
f000ff08fde7a9b477d26ca1eea9bbe550564090 TableStats.java | grep "SSTable count"
-System.out.println("\t\tSSTable count: " + 
probe.getColumnFamilyMetric(keyspaceName, tableName, "LiveSSTableCount"));
{noformat}

> nodetool tablestats sstable count missing.
> --
>
> Key: CASSANDRA-12205
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12205
> Project: Cassandra
>  Issue Type: Bug
>  Components: Tools
> Environment: Cassandra 3.7
>Reporter: Cameron MacMinn
> Attachments: bad.txt, good.txt
>
>
> As a user, I have used  nodetool cfstats  since v2.1. The most useful line is 
> the 1 like 'SSTable count: 12'.
> As a user, I want v3.7  nodetool tablestats  to continue showing SStable 
> count. At the moment, SStable count is missing from the output.
> Examples attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)