[jira] [Commented] (CASSANDRA-12312) Restore JVM metric export for metric reporters
[
https://issues.apache.org/jira/browse/CASSANDRA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417677#comment-15417677
]
T Jake Luciani commented on CASSANDRA-12312:
I guess creating a separate ticket for docs would have been better. But since
this is 2.2 base patch and the docs are only on 3.x it made the merge tricky.
In general we merge from lowest branch forward see
https://wiki.apache.org/cassandra/HowToContribute.
> Restore JVM metric export for metric reporters
> --
>
> Key: CASSANDRA-12312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12312
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
> Labels: lhf
> Fix For: 2.2.8, 3.0.9, 3.9
>
> Attachments: 12312-2.2.patch, 12312-3.0.patch, 12312-trunk.patch,
> metrics-jvm-3.1.0.jar.asc
>
>
> JVM instrumentation as part of dropwizard metrics has been moved to a
> separate {{metrics-jvm}} artifact in metrics-v3.0. After CASSANDRA-5657, no
> jvm related metrics will be exported to any reporter configured via
> {{metrics-reporter-config}}, as this isn't part of {{metrics-core}} anymore.
> As memory and GC stats are essential for monitoring Cassandra, this turns out
> to be a blocker for us for upgrading to 2.2.
> I've included a patch that would add the now separate {{metrics-jvm}} package
> and enables some of the provided metrics on startup in case a metrics
> reporter is used ({{-Dcassandra.metricsReporterConfigFile}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12312) Restore JVM metric export for metric reporters
[
https://issues.apache.org/jira/browse/CASSANDRA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417664#comment-15417664
]
Stefan Podkowinski commented on CASSANDRA-12312:
I find it somehow confusing to see the commits for the code changes in each
branch just as expected, but not for the documentation changes, which are now
part of the merge commit. It's a bit unfortunate that the author information is
lost in merge commits, so I'm wondering what the correct way to contribute
patches for the documentation would be to avoid this situation in the future.
> Restore JVM metric export for metric reporters
> --
>
> Key: CASSANDRA-12312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12312
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
> Labels: lhf
> Fix For: 2.2.8, 3.0.9, 3.9
>
> Attachments: 12312-2.2.patch, 12312-3.0.patch, 12312-trunk.patch,
> metrics-jvm-3.1.0.jar.asc
>
>
> JVM instrumentation as part of dropwizard metrics has been moved to a
> separate {{metrics-jvm}} artifact in metrics-v3.0. After CASSANDRA-5657, no
> jvm related metrics will be exported to any reporter configured via
> {{metrics-reporter-config}}, as this isn't part of {{metrics-core}} anymore.
> As memory and GC stats are essential for monitoring Cassandra, this turns out
> to be a blocker for us for upgrading to 2.2.
> I've included a patch that would add the now separate {{metrics-jvm}} package
> and enables some of the provided metrics on startup in case a metrics
> reporter is used ({{-Dcassandra.metricsReporterConfigFile}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12312) Restore JVM metric export for metric reporters
[
https://issues.apache.org/jira/browse/CASSANDRA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15417466#comment-15417466
]
T Jake Luciani commented on CASSANDRA-12312:
It was added as part of the [3.9
merge|https://github.com/apache/cassandra/commit/aab33f1170c8dd53935910cead3df0a1d3deb61a]
(since our docs are on 3.8+)
https://github.com/apache/cassandra/commit/aab33f1170c8dd53935910cead3df0a1d3deb61a
> Restore JVM metric export for metric reporters
> --
>
> Key: CASSANDRA-12312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12312
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
> Labels: lhf
> Fix For: 2.2.8, 3.0.9, 3.9
>
> Attachments: 12312-2.2.patch, 12312-3.0.patch, 12312-trunk.patch,
> metrics-jvm-3.1.0.jar.asc
>
>
> JVM instrumentation as part of dropwizard metrics has been moved to a
> separate {{metrics-jvm}} artifact in metrics-v3.0. After CASSANDRA-5657, no
> jvm related metrics will be exported to any reporter configured via
> {{metrics-reporter-config}}, as this isn't part of {{metrics-core}} anymore.
> As memory and GC stats are essential for monitoring Cassandra, this turns out
> to be a blocker for us for upgrading to 2.2.
> I've included a patch that would add the now separate {{metrics-jvm}} package
> and enables some of the provided metrics on startup in case a metrics
> reporter is used ({{-Dcassandra.metricsReporterConfigFile}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12312) Restore JVM metric export for metric reporters
[
https://issues.apache.org/jira/browse/CASSANDRA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416984#comment-15416984
]
Stefan Podkowinski commented on CASSANDRA-12312:
What happened to the metrics.rst update? I can't find it in the actual commit
of yours.
> Restore JVM metric export for metric reporters
> --
>
> Key: CASSANDRA-12312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12312
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
> Labels: lhf
> Fix For: 2.2.8, 3.0.9, 3.9
>
> Attachments: 12312-2.2.patch, 12312-3.0.patch, 12312-trunk.patch,
> metrics-jvm-3.1.0.jar.asc
>
>
> JVM instrumentation as part of dropwizard metrics has been moved to a
> separate {{metrics-jvm}} artifact in metrics-v3.0. After CASSANDRA-5657, no
> jvm related metrics will be exported to any reporter configured via
> {{metrics-reporter-config}}, as this isn't part of {{metrics-core}} anymore.
> As memory and GC stats are essential for monitoring Cassandra, this turns out
> to be a blocker for us for upgrading to 2.2.
> I've included a patch that would add the now separate {{metrics-jvm}} package
> and enables some of the provided metrics on startup in case a metrics
> reporter is used ({{-Dcassandra.metricsReporterConfigFile}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12312) Restore JVM metric export for metric reporters
[
https://issues.apache.org/jira/browse/CASSANDRA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406188#comment-15406188
]
T Jake Luciani commented on CASSANDRA-12312:
bq. what do you think about including metrics on thread states based on
ThreadStatesGaugeSet.java?
I think this might be overkill since we can use jstack for the same. It
doesn't seem valuable to see all this info all the time.
> Restore JVM metric export for metric reporters
> --
>
> Key: CASSANDRA-12312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12312
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
> Labels: lhf
> Fix For: 2.2.x, 3.0.x, 3.x
>
> Attachments: 12312-2.2.patch, 12312-3.0.patch, 12312-trunk.patch,
> metrics-jvm-3.1.0.jar.asc
>
>
> JVM instrumentation as part of dropwizard metrics has been moved to a
> separate {{metrics-jvm}} artifact in metrics-v3.0. After CASSANDRA-5657, no
> jvm related metrics will be exported to any reporter configured via
> {{metrics-reporter-config}}, as this isn't part of {{metrics-core}} anymore.
> As memory and GC stats are essential for monitoring Cassandra, this turns out
> to be a blocker for us for upgrading to 2.2.
> I've included a patch that would add the now separate {{metrics-jvm}} package
> and enables some of the provided metrics on startup in case a metrics
> reporter is used ({{-Dcassandra.metricsReporterConfigFile}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12312) Restore JVM metric export for metric reporters
[
https://issues.apache.org/jira/browse/CASSANDRA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406184#comment-15406184
]
T Jake Luciani commented on CASSANDRA-12312:
Great thanks, I'll commit this soon.
> Restore JVM metric export for metric reporters
> --
>
> Key: CASSANDRA-12312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12312
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
> Labels: lhf
> Fix For: 2.2.x, 3.0.x, 3.x
>
> Attachments: 12312-2.2.patch, 12312-3.0.patch, 12312-trunk.patch,
> metrics-jvm-3.1.0.jar.asc
>
>
> JVM instrumentation as part of dropwizard metrics has been moved to a
> separate {{metrics-jvm}} artifact in metrics-v3.0. After CASSANDRA-5657, no
> jvm related metrics will be exported to any reporter configured via
> {{metrics-reporter-config}}, as this isn't part of {{metrics-core}} anymore.
> As memory and GC stats are essential for monitoring Cassandra, this turns out
> to be a blocker for us for upgrading to 2.2.
> I've included a patch that would add the now separate {{metrics-jvm}} package
> and enables some of the provided metrics on startup in case a metrics
> reporter is used ({{-Dcassandra.metricsReporterConfigFile}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12312) Restore JVM metric export for metric reporters
[
https://issues.apache.org/jira/browse/CASSANDRA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405731#comment-15405731
]
Stefan Podkowinski commented on CASSANDRA-12312:
I've now included documentation on the added metrics in the trunk patch.
[~tjake], what do you think about including metrics on thread states based on
[ThreadStatesGaugeSet.java|https://github.com/dropwizard/metrics/blob/3.1-maintenance/metrics-jvm/src/main/java/com/codahale/metrics/jvm/ThreadStatesGaugeSet.java]?
I haven't included them so far as I'm not really sure if it makes sense to
report these numbers as part of a performance monitoring, except maybe the
number of runnable threads. But I wonder if it's really worth to constantly
poll these values and how expensive that would be.
> Restore JVM metric export for metric reporters
> --
>
> Key: CASSANDRA-12312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12312
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
> Labels: lhf
> Fix For: 2.2.x, 3.0.x, 3.x
>
> Attachments: 12312-2.2.patch, 12312-3.0.patch, 12312-trunk.patch,
> metrics-jvm-3.1.0.jar.asc
>
>
> JVM instrumentation as part of dropwizard metrics has been moved to a
> separate {{metrics-jvm}} artifact in metrics-v3.0. After CASSANDRA-5657, no
> jvm related metrics will be exported to any reporter configured via
> {{metrics-reporter-config}}, as this isn't part of {{metrics-core}} anymore.
> As memory and GC stats are essential for monitoring Cassandra, this turns out
> to be a blocker for us for upgrading to 2.2.
> I've included a patch that would add the now separate {{metrics-jvm}} package
> and enables some of the provided metrics on startup in case a metrics
> reporter is used ({{-Dcassandra.metricsReporterConfigFile}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12312) Restore JVM metric export for metric reporters
[
https://issues.apache.org/jira/browse/CASSANDRA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402358#comment-15402358
]
T Jake Luciani commented on CASSANDRA-12312:
Looks great, would you mind adding the new metrics to the
[docs|https://github.com/apache/cassandra/blob/trunk/doc/source/operating/metrics.rst]?
> Restore JVM metric export for metric reporters
> --
>
> Key: CASSANDRA-12312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12312
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
> Labels: lhf
> Fix For: 2.2.x, 3.0.x, 3.x
>
> Attachments: 12312-2.2.patch, 12312-3.0.patch, 12312-trunk.patch,
> metrics-jvm-3.1.0.jar.asc
>
>
> JVM instrumentation as part of dropwizard metrics has been moved to a
> separate {{metrics-jvm}} artifact in metrics-v3.0. After CASSANDRA-5657, no
> jvm related metrics will be exported to any reporter configured via
> {{metrics-reporter-config}}, as this isn't part of {{metrics-core}} anymore.
> As memory and GC stats are essential for monitoring Cassandra, this turns out
> to be a blocker for us for upgrading to 2.2.
> I've included a patch that would add the now separate {{metrics-jvm}} package
> and enables some of the provided metrics on startup in case a metrics
> reporter is used ({{-Dcassandra.metricsReporterConfigFile}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12312) Restore JVM metric export for metric reporters
[
https://issues.apache.org/jira/browse/CASSANDRA-12312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395221#comment-15395221
]
Stefan Podkowinski commented on CASSANDRA-12312:
||2.2||3.0||trunk||
|[branch|https://github.com/spodkowinski/cassandra/tree/CASSANDRA-12312-2.2]|[branch|https://github.com/spodkowinski/cassandra/tree/CASSANDRA-12312-3.0]|[branch|https://github.com/spodkowinski/cassandra/tree/CASSANDRA-12312-trunk]|
|[dtest|http://cassci.datastax.com/view/Dev/view/spodkowinski/job/spodkowinski-CASSANDRA-12312-2.2-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/spodkowinski/job/spodkowinski-CASSANDRA-12312-3.0-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/spodkowinski/job/spodkowinski-CASSANDRA-12312-trunk-dtest/]|
|[testall|http://cassci.datastax.com/view/Dev/view/spodkowinski/job/spodkowinski-CASSANDRA-12312-2.2-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/spodkowinski/job/spodkowinski-CASSANDRA-12312-3.0-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/spodkowinski/job/spodkowinski-CASSANDRA-12312-trunk-testall/]|
> Restore JVM metric export for metric reporters
> --
>
> Key: CASSANDRA-12312
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12312
> Project: Cassandra
> Issue Type: Bug
>Reporter: Stefan Podkowinski
>Assignee: Stefan Podkowinski
> Attachments: 12312-2.2.patch, 12312-3.0.patch, 12312-trunk.patch,
> metrics-jvm-3.1.0.jar.asc
>
>
> JVM instrumentation as part of dropwizard metrics has been moved to a
> separate {{metrics-jvm}} artifact in metrics-v3.0. After CASSANDRA-5657, no
> jvm related metrics will be exported to any reporter configured via
> {{metrics-reporter-config}}, as this isn't part of {{metrics-core}} anymore.
> As memory and GC stats are essential for monitoring Cassandra, this turns out
> to be a blocker for us for upgrading to 2.2.
> I've included a patch that would add the now separate {{metrics-jvm}} package
> and enables some of the provided metrics on startup in case a metrics
> reporter is used ({{-Dcassandra.metricsReporterConfigFile}}).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
