[jira] [Commented] (CASSANDRA-12861) example/triggers build fail.
[
https://issues.apache.org/jira/browse/CASSANDRA-12861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15663180#comment-15663180
]
Alex Petrov commented on CASSANDRA-12861:
-
I've looked at the code and tried this trigger and does work. The only
difference I've noticed with the previous example was that the timestamp in
micros isn't passed explicitly, although I've checked the code and it picks
current time in microseconds anyway.
+1
> example/triggers build fail.
>
>
> Key: CASSANDRA-12861
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12861
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yasuharu Goto
>Assignee: Sylvain Lebresne
>Priority: Trivial
>
> When I tried to build example/trigger on trunk branch, I found that "ant jar"
> fails with an error like below.
> (Sorry for my language settings for ant. I couldn't find how to change it.
> The error indicated here is a "cannot find symboll" error of
> RowUpdateBuilder).
> {code}
> Buildfile: /Users/yasuharu/git/cassandra/examples/triggers/build.xml
> init:
> [mkdir] Created dir:
> /Users/yasuharu/git/cassandra/examples/triggers/build/classes
> build:
> [javac] Compiling 1 source file to
> /Users/yasuharu/git/cassandra/examples/triggers/build/classes
> [javac] 警告:
> 注釈プロセッサ'org.openjdk.jmh.generators.BenchmarkProcessor'から-source
> '1.8'より小さいソース・バージョン'RELEASE_6'がサポートされています
> [javac]
> /Users/yasuharu/git/cassandra/examples/triggers/src/org/apache/cassandra/triggers/AuditTrigger.java:27:
> エラー: シンボルを見つけられません
> [javac] import org.apache.cassandra.db.RowUpdateBuilder;
> [javac] ^
> [javac] シンボル: クラス RowUpdateBuilder
> [javac] 場所: パッケージ org.apache.cassandra.db
> [javac] エラー1個
> [javac] 警告1個
> BUILD FAILED
> /Users/yasuharu/git/cassandra/examples/triggers/build.xml:45: Compile failed;
> see the compiler error output for details.
> Total time: 1 second
> {code}
> I think the movement of RowUpdateBuilder to test has broken this build.
> https://github.com/apache/cassandra/commit/26838063de6246e3a1e18062114ca92fb81c00cf
> In order to fix this, I moved back RowUpdateBuilder.java to src in my patch.
> https://github.com/apache/cassandra/commit/d133eefe9c5fbebd8d389a9397c3948b8c36bd06
> Could you please review my patch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12861) example/triggers build fail.
[
https://issues.apache.org/jira/browse/CASSANDRA-12861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15658815#comment-15658815
]
Yasuharu Goto commented on CASSANDRA-12861:
---
Thank you [~slebresne] for your correction. Your version helped me
understanding Cassandra code :)
> example/triggers build fail.
>
>
> Key: CASSANDRA-12861
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12861
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yasuharu Goto
>Assignee: Sylvain Lebresne
>Priority: Trivial
>
> When I tried to build example/trigger on trunk branch, I found that "ant jar"
> fails with an error like below.
> (Sorry for my language settings for ant. I couldn't find how to change it.
> The error indicated here is a "cannot find symboll" error of
> RowUpdateBuilder).
> {code}
> Buildfile: /Users/yasuharu/git/cassandra/examples/triggers/build.xml
> init:
> [mkdir] Created dir:
> /Users/yasuharu/git/cassandra/examples/triggers/build/classes
> build:
> [javac] Compiling 1 source file to
> /Users/yasuharu/git/cassandra/examples/triggers/build/classes
> [javac] 警告:
> 注釈プロセッサ'org.openjdk.jmh.generators.BenchmarkProcessor'から-source
> '1.8'より小さいソース・バージョン'RELEASE_6'がサポートされています
> [javac]
> /Users/yasuharu/git/cassandra/examples/triggers/src/org/apache/cassandra/triggers/AuditTrigger.java:27:
> エラー: シンボルを見つけられません
> [javac] import org.apache.cassandra.db.RowUpdateBuilder;
> [javac] ^
> [javac] シンボル: クラス RowUpdateBuilder
> [javac] 場所: パッケージ org.apache.cassandra.db
> [javac] エラー1個
> [javac] 警告1個
> BUILD FAILED
> /Users/yasuharu/git/cassandra/examples/triggers/build.xml:45: Compile failed;
> see the compiler error output for details.
> Total time: 1 second
> {code}
> I think the movement of RowUpdateBuilder to test has broken this build.
> https://github.com/apache/cassandra/commit/26838063de6246e3a1e18062114ca92fb81c00cf
> In order to fix this, I moved back RowUpdateBuilder.java to src in my patch.
> https://github.com/apache/cassandra/commit/d133eefe9c5fbebd8d389a9397c3948b8c36bd06
> Could you please review my patch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12861) example/triggers build fail.
[
https://issues.apache.org/jira/browse/CASSANDRA-12861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1565#comment-1565
]
Sylvain Lebresne commented on CASSANDRA-12861:
--
Pushed patch related to my comment above
[here|https://github.com/pcmanus/cassandra/commits/12861] (not triggering CI
since it only changes the example file which tests don't exercise at all).
> example/triggers build fail.
>
>
> Key: CASSANDRA-12861
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12861
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yasuharu Goto
>Assignee: Yasuharu Goto
>Priority: Trivial
>
> When I tried to build example/trigger on trunk branch, I found that "ant jar"
> fails with an error like below.
> (Sorry for my language settings for ant. I couldn't find how to change it.
> The error indicated here is a "cannot find symboll" error of
> RowUpdateBuilder).
> {code}
> Buildfile: /Users/yasuharu/git/cassandra/examples/triggers/build.xml
> init:
> [mkdir] Created dir:
> /Users/yasuharu/git/cassandra/examples/triggers/build/classes
> build:
> [javac] Compiling 1 source file to
> /Users/yasuharu/git/cassandra/examples/triggers/build/classes
> [javac] 警告:
> 注釈プロセッサ'org.openjdk.jmh.generators.BenchmarkProcessor'から-source
> '1.8'より小さいソース・バージョン'RELEASE_6'がサポートされています
> [javac]
> /Users/yasuharu/git/cassandra/examples/triggers/src/org/apache/cassandra/triggers/AuditTrigger.java:27:
> エラー: シンボルを見つけられません
> [javac] import org.apache.cassandra.db.RowUpdateBuilder;
> [javac] ^
> [javac] シンボル: クラス RowUpdateBuilder
> [javac] 場所: パッケージ org.apache.cassandra.db
> [javac] エラー1個
> [javac] 警告1個
> BUILD FAILED
> /Users/yasuharu/git/cassandra/examples/triggers/build.xml:45: Compile failed;
> see the compiler error output for details.
> Total time: 1 second
> {code}
> I think the movement of RowUpdateBuilder to test has broken this build.
> https://github.com/apache/cassandra/commit/26838063de6246e3a1e18062114ca92fb81c00cf
> In order to fix this, I moved back RowUpdateBuilder.java to src in my patch.
> https://github.com/apache/cassandra/commit/d133eefe9c5fbebd8d389a9397c3948b8c36bd06
> Could you please review my patch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12861) example/triggers build fail.
[
https://issues.apache.org/jira/browse/CASSANDRA-12861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636919#comment-15636919
]
Sylvain Lebresne commented on CASSANDRA-12861:
--
Thanks for the notice and patch, but ss noted on [this
comment|https://issues.apache.org/jira/browse/CASSANDRA-12236?focusedCommentId=15395897&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15395897]
of the ticket that made the change (CASSANDRA-12236), we really did wanted to
move {{RowUpdateBuilder}} out of the non-test sources (in fact, it's in the
test only out of laziness and could be cleaned some day). So I'd rather we
instead replace the use of {{RowUpdateBuilder}} in the trigger example by the
new {{SimpleBuilder}} introduced in CASSANDRA-12236. I'll provide a patch for
that when I have a bit of time next week, but if you want to have a shot at it
first, that would be very much appreciated.
> example/triggers build fail.
>
>
> Key: CASSANDRA-12861
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12861
> Project: Cassandra
> Issue Type: Bug
>Reporter: Yasuharu Goto
>Assignee: Yasuharu Goto
>Priority: Trivial
>
> When I tried to build example/trigger on trunk branch, I found that "ant jar"
> fails with an error like below.
> (Sorry for my language settings for ant. I couldn't find how to change it.
> The error indicated here is a "cannot find symboll" error of
> RowUpdateBuilder).
> {code}
> Buildfile: /Users/yasuharu/git/cassandra/examples/triggers/build.xml
> init:
> [mkdir] Created dir:
> /Users/yasuharu/git/cassandra/examples/triggers/build/classes
> build:
> [javac] Compiling 1 source file to
> /Users/yasuharu/git/cassandra/examples/triggers/build/classes
> [javac] 警告:
> 注釈プロセッサ'org.openjdk.jmh.generators.BenchmarkProcessor'から-source
> '1.8'より小さいソース・バージョン'RELEASE_6'がサポートされています
> [javac]
> /Users/yasuharu/git/cassandra/examples/triggers/src/org/apache/cassandra/triggers/AuditTrigger.java:27:
> エラー: シンボルを見つけられません
> [javac] import org.apache.cassandra.db.RowUpdateBuilder;
> [javac] ^
> [javac] シンボル: クラス RowUpdateBuilder
> [javac] 場所: パッケージ org.apache.cassandra.db
> [javac] エラー1個
> [javac] 警告1個
> BUILD FAILED
> /Users/yasuharu/git/cassandra/examples/triggers/build.xml:45: Compile failed;
> see the compiler error output for details.
> Total time: 1 second
> {code}
> I think the movement of RowUpdateBuilder to test has broken this build.
> https://github.com/apache/cassandra/commit/26838063de6246e3a1e18062114ca92fb81c00cf
> In order to fix this, I moved back RowUpdateBuilder.java to src in my patch.
> https://github.com/apache/cassandra/commit/d133eefe9c5fbebd8d389a9397c3948b8c36bd06
> Could you please review my patch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
