[jira] [Commented] (CASSANDRA-12897) Move cqlsh syntax rules into separate module and allow easier customization
[ https://issues.apache.org/jira/browse/CASSANDRA-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665496#comment-15665496 ] Stefania commented on CASSANDRA-12897: -- Thanks Dikang! > Move cqlsh syntax rules into separate module and allow easier customization > --- > > Key: CASSANDRA-12897 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12897 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Eduard Tudenhoefner >Assignee: Eduard Tudenhoefner >Priority: Minor > Fix For: 3.10 > > > At the moment the entire cqlsh syntax rules are defined in one single field > in > https://github.com/apache/cassandra/blob/13b7362494c4c0ff3c5ce80b8e7ee7fe64d65785/bin/cqlsh.py#L313-L426. > It would be easier if every syntax rule would be stored in its own field for > easier extensibility / customizability. > It probably also makes sense to move the relevant *cqlsh* syntax rules and > syntax completer into a separate *cqlshhandling.py* module because *cqlsh.py* > in itself is huge. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12897) Move cqlsh syntax rules into separate module and allow easier customization
[
https://issues.apache.org/jira/browse/CASSANDRA-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665177#comment-15665177
]
Dikang Gu commented on CASSANDRA-12897:
---
update the fix version to be {{3.10}} after chatting with [~mshuler].
> Move cqlsh syntax rules into separate module and allow easier customization
> ---
>
> Key: CASSANDRA-12897
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12897
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Eduard Tudenhoefner
>Assignee: Eduard Tudenhoefner
>Priority: Minor
> Fix For: 3.10
>
>
> At the moment the entire cqlsh syntax rules are defined in one single field
> in
> https://github.com/apache/cassandra/blob/13b7362494c4c0ff3c5ce80b8e7ee7fe64d65785/bin/cqlsh.py#L313-L426.
> It would be easier if every syntax rule would be stored in its own field for
> easier extensibility / customizability.
> It probably also makes sense to move the relevant *cqlsh* syntax rules and
> syntax completer into a separate *cqlshhandling.py* module because *cqlsh.py*
> in itself is huge.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12897) Move cqlsh syntax rules into separate module and allow easier customization
[ https://issues.apache.org/jira/browse/CASSANDRA-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15662643#comment-15662643 ] Stefania commented on CASSANDRA-12897: -- There was also an [indentation problem|https://cassci.datastax.com/view/Dev/view/nastra/job/nastra-CASSANDRA-12897-dtest/2/testReport/cqlsh_tests.cqlsh_tests/TestCqlsh/test_pep8_compliance/] still remaining, fixed and relaunched. > Move cqlsh syntax rules into separate module and allow easier customization > --- > > Key: CASSANDRA-12897 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12897 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Eduard Tudenhoefner >Assignee: Eduard Tudenhoefner >Priority: Minor > Fix For: 3.x > > > At the moment the entire cqlsh syntax rules are defined in one single field > in > https://github.com/apache/cassandra/blob/13b7362494c4c0ff3c5ce80b8e7ee7fe64d65785/bin/cqlsh.py#L313-L426. > It would be easier if every syntax rule would be stored in its own field for > easier extensibility / customizability. > It probably also makes sense to move the relevant *cqlsh* syntax rules and > syntax completer into a separate *cqlshhandling.py* module because *cqlsh.py* > in itself is huge. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12897) Move cqlsh syntax rules into separate module and allow easier customization
[ https://issues.apache.org/jira/browse/CASSANDRA-12897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15662526#comment-15662526 ] Stefania commented on CASSANDRA-12897: -- Patch LGTM. There are two duplicate lines [here|https://github.com/apache/cassandra/compare/cassandra-3.X...nastra:CASSANDRA-12897#diff-321fbab92058e0e947cfbd0c5383c610R220] and [here|https://github.com/apache/cassandra/compare/cassandra-3.X...nastra:CASSANDRA-12897#diff-321fbab92058e0e947cfbd0c5383c610R230], which I've already fixed in the final patch to be committed. I'm running the clqsh specific tests, because the ordinary dtests do not include cqlshlib unit tests, just to ensure nothing got broken there: ||3.X||trunk|| |[patch|https://github.com/stef1927/cassandra/tree/12897-cqlsh-3.X]|[patch|https://github.com/stef1927/cassandra/tree/12897-cqlsh]| |[cqlsh tests|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12897-cqlsh-3.X-cqlsh-tests/]|[cqlsh tests|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-12897-cqlsh-cqlsh-tests/]| > Move cqlsh syntax rules into separate module and allow easier customization > --- > > Key: CASSANDRA-12897 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12897 > Project: Cassandra > Issue Type: Improvement > Components: Core >Reporter: Eduard Tudenhoefner >Assignee: Eduard Tudenhoefner >Priority: Minor > Fix For: 3.x > > > At the moment the entire cqlsh syntax rules are defined in one single field > in > https://github.com/apache/cassandra/blob/13b7362494c4c0ff3c5ce80b8e7ee7fe64d65785/bin/cqlsh.py#L313-L426. > It would be easier if every syntax rule would be stored in its own field for > easier extensibility / customizability. > It probably also makes sense to move the relevant *cqlsh* syntax rules and > syntax completer into a separate *cqlshhandling.py* module because *cqlsh.py* > in itself is huge. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
