[jira] [Commented] (CASSANDRA-12981) Refactor ColumnCondition
[
https://issues.apache.org/jira/browse/CASSANDRA-12981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842940#comment-15842940
]
Benjamin Lerer commented on CASSANDRA-12981:
Thanks for the review.
> Refactor ColumnCondition
>
>
> Key: CASSANDRA-12981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12981
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>
> {{ColumnCondition}} has become really difficult to understand and modify. We
> should separate the logic to make improvements and maintenance easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12981) Refactor ColumnCondition
[
https://issues.apache.org/jira/browse/CASSANDRA-12981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842879#comment-15842879
]
Alex Petrov commented on CASSANDRA-12981:
-
Thank you! CI looks good, trunk patch looks good, too.
+1
> Refactor ColumnCondition
>
>
> Key: CASSANDRA-12981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12981
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>
> {{ColumnCondition}} has become really difficult to understand and modify. We
> should separate the logic to make improvements and maintenance easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12981) Refactor ColumnCondition
[
https://issues.apache.org/jira/browse/CASSANDRA-12981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842697#comment-15842697
]
Benjamin Lerer commented on CASSANDRA-12981:
I pushed a new patch for trunk to fix the failing unit tests and re-run CI
> Refactor ColumnCondition
>
>
> Key: CASSANDRA-12981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12981
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>
> {{ColumnCondition}} has become really difficult to understand and modify. We
> should separate the logic to make improvements and maintenance easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12981) Refactor ColumnCondition
[
https://issues.apache.org/jira/browse/CASSANDRA-12981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834259#comment-15834259
]
Alex Petrov commented on CASSANDRA-12981:
-
Thank you for the patch.
The code looks much cleaner now, I think. I like the refactoring that you've
done (also, great it works with all combinations).
A couple of small nits:
* did you intend to remove a frozen check
[here|https://github.com/apache/cassandra/compare/trunk...blerer:12981-3.X#diff-4ed3cc64d0f93cbe2ffad5ce9786ac63R885]?
If yes, we probably want to get rid of the loop too, otherwise bring it back.
* I might be missing something, but I think it may be worth to add tests for
unset values on non-collection columns and for collections, but with operators
other than IN
* I understand it was a moved old code, but should we rather use
{{CollectionType#kind}} and {{switch}} statement instead of {{if}}/{{else}}
[here|https://github.com/apache/cassandra/compare/trunk...blerer:12981-3.X#diff-053beb50697f19465663798078b87b4bR129]
* is there any reason to prefer {{Function}} instead of just making
{{deserialize}} a method and calling it? (might be to avoid a cost of switch
statement, should we a type alias then to avoid {{java.util.function}} in two
places?)
Thank you!
> Refactor ColumnCondition
>
>
> Key: CASSANDRA-12981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12981
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>
> {{ColumnCondition}} has become really difficult to understand and modify. We
> should separate the logic to make improvements and maintenance easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CASSANDRA-12981) Refactor ColumnCondition
[
https://issues.apache.org/jira/browse/CASSANDRA-12981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744794#comment-15744794
]
Benjamin Lerer commented on CASSANDRA-12981:
While refactoring, I discovered that C* was not handling properly {{IN}}
markers if they were {{null}} or {{unset}}. By consequence, I also provided
some patch for {{2.2}} and {{3.0}} to solve those problems.
||Branch||utests||dtests||
|[2.2|https://github.com/apache/cassandra/compare/trunk...blerer:12981-2.2]|[2.2|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-12981-2.2-testall/]|[2.2|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-12981-2.2-dtest/]|
|[3.0|https://github.com/apache/cassandra/compare/trunk...blerer:12981-3.0]|[3.0|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-12981-3.0-testall/]|[3.0|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-12981-3.0-dtest/]|
|[3.X|https://github.com/apache/cassandra/compare/trunk...blerer:12981-3.X]|[3.X|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-12981-3.X-testall/]|[3.X|http://cassci.datastax.com/view/Dev/view/blerer/job/blerer-12981-3.X-dtest/]|
> Refactor ColumnCondition
>
>
> Key: CASSANDRA-12981
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12981
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Benjamin Lerer
>Assignee: Benjamin Lerer
>
> {{ColumnCondition}} has become really difficult to understand and modify. We
> should separate the logic to make improvements and maintenance easier.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
