[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889836#comment-17889836
]
Josh McKenzie commented on CASSANDRA-12988:
---
Wow. I... do not recall this ticket =/
I double-checked the code, and sure enough:
{code:java}
public volatile String auth_read_consistency_level = "LOCAL_QUORUM";
public volatile String auth_write_consistency_level = "EACH_QUORUM";{code}
So I updated the text here to at least reflect what's in the codebase. With my
name on git blame. :)
(I upstreamed some work someone else had authored here so it's little surprise
that it's been evicted from the old mental cache).
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.1-alpha1, 4.1
>
>
> Most reads for the auth-related tables execute at {{{}LOCAL_ONE{}}}. We'd
> like to make it configurable and change the default to LOCAL_QUORUM.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889792#comment-17889792
]
Brad Schoening commented on CASSANDRA-12988:
[~jmckenzie] the Jira Description still reads "with the default still being
{{{}LOCAL_ONE{}}}", but it looks like the default in Config.java was changed.
Should that be updated?
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.1-alpha1, 4.1
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419007#comment-17419007
]
Benjamin Lerer commented on CASSANDRA-12988:
+1
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418722#comment-17418722
]
Josh McKenzie commented on CASSANDRA-12988:
---
PR updated. Upgrade testing on 8 as it's not in the 11 circle config.
JDK 8 tests:
[Link|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/87/workflows/43647881-ec71-4264-a2b0-ca117df386a2]
JDK 11 tests:
[Link|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/87/workflows/12f26230-abb0-4a67-947b-63f5ff18020c]
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418586#comment-17418586
]
Josh McKenzie commented on CASSANDRA-12988:
---
{quote} run the upgrade tests before committing
{quote}
Good call. I'll revise those nits soon and kick off the basic + dtest + upgrade
suites. Probably just do upgrade on JDK11 as we're looking for logic and not
env.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418465#comment-17418465
]
Benjamin Lerer commented on CASSANDRA-12988:
Outside of my comments on the PR the code changes look good.
I was just wondering if we should not run the upgrade tests before committing.
I am not sure if some of them checks the level of consistency for Auth
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418233#comment-17418233
]
Josh McKenzie commented on CASSANDRA-12988:
---
[Added a
commit|https://github.com/apache/cassandra/commit/28ad1f8209e06da705f09bff19879619d5e77f55]
that reverts to identical pre-commit CL special-case handling of the default
super user account along with some better documentation around what we're doing
and why so we don't run into this in the future. Plus a unit test to further
harden against accidental changing of this in the future.
I'm tempted to say we should cut all access to
CassandraAuthorizer.auth*ConsistencyLevel and route everything through the role
methods, but people can go straight to the AuthProperties object anyway and
pull CL for read/write w/out respecting role-specific needs if they're really
hell-bent on living on the edge.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418214#comment-17418214
]
Jeremiah Jordan commented on CASSANDRA-12988:
-
Right, I think the main thing is the checks around auto creation of the
cassandra user. Might be nice to add a -D to disable the auto creation code
completely while doing this. The paranoid among us could set that flag once
the cluster is setup and then not have to worry about that code doing something
funny down the line.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416808#comment-17416808
]
Blake Eggleston commented on CASSANDRA-12988:
-
I think you'd only need to special case the auto-creation of the cassandra
user, regular auth would use the configured CLs.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416804#comment-17416804
]
Josh McKenzie commented on CASSANDRA-12988:
---
{quote}Just re-read the patch and it kept the
auth_read_consistency_level/auth_write_consistency_level settings to pick the
level in the yaml, it seemed like that was not there from the JIRA comments.
That should be fine
{quote}
So correct me if I'm misunderstanding: there's a couple things we're navigating
here.
1: How we treat the {{cassandra}} user (i.e. whether we special case it or not,
and if so, how w/out making our codebase a mess and have the special treatment
of this special user be confusing for new users and not surprising old users by
changing it /sigh ;) )
2: The implications of unifying the CL across Authorizer, RoleManager, and
PasswordAuthenticator and promoting from LOCAL_ONE / ONE to LOCAL_QUORUM (or
demoting from QUORUM to one of those, fun!) and/or EACH_QUORUM based on read
vs. write
Being able to config read/write path in the .yaml to whatever you want and
potentially changing those defaults to QUORUM vs. what's in that PR would
satisfy part of that. The broader question of "is it a good idea to unify these
and what do we do about {{cassandra}}", I'm less clear on our best worst option
here.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416793#comment-17416793
]
Jeremiah Jordan commented on CASSANDRA-12988:
-
Yes, keeping QUORUM for that would solve the auto create issue.
Just thought of another issue. In the wild people will very often set the RF
of the auth key space to be equal to the number of nodes in the DC. I have
seen people set it to 12 or even higher in a single DC. They do this to make
the LOCAL_ONE query able to always be to the current node, lowering the chances
of auth failures from other nodes being slow. Switching to always using
LOCAL_QUORUM will go very badly in these cases.
I would suggest we need to be able to keep the LOCAL_ONE query as an option.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416765#comment-17416765
]
Blake Eggleston commented on CASSANDRA-12988:
-
What if we didn't auto create the cassandra user unless a QUORUM read confirmed
it wasn't there?
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416761#comment-17416761
]
Jeremiah Jordan commented on CASSANDRA-12988:
-
I have not gone through the implications of this change extensively, but from
past experience with auth bootstrapping and multiple DC's, I do not know
changing away from QUORUM is safe.
Because of the way people bring up new datacenter with bootstrap off, combined
with the way we auto create the "cassandra" users, I do not think it is safe to
stop using QUORUM for that user. A read at LOCAL_QUORUM will not find any
users and the nodes would then "create" the "cassandra" user, possibly over
writing or bringing that user back if it removed.
I hate the fact that the "cassandra" user uses QUORUM as much as the next
person, but until we have a way to create that user which is not "try to do it
automatically during first startup", or we don't have "auto bootstrap:false" as
an option, I think the use of QUORUM is actually needed.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412674#comment-17412674
]
Josh McKenzie commented on CASSANDRA-12988:
---
Ok, PR updated and squashed w/NEWS.txt entry, and very trivial relaxation of
the python dtests checking for auth failure (removing *which* CL we failed to
achieve and instead just confirming we failed to hit the expected CL server
side). I think this one's ready to go.
Linking re-run to the base tests (unit + in-jvm dtest) since there was a
smattering of unit test failures on the run in the earlier branch for some
reason.
||Item|Link||
|JDK8
base|[Link|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/79/workflows/eb774443-2edb-4c3c-8652-9d040a353a28]|
|JDK11
base|[Link|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/79/workflows/a740f309-fab9-4025-8885-b19666d748d4]|
|Squashed
PR|[Link|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:cassandra-12988?expand=1]|
|dtest
PR|[Link|https://github.com/apache/cassandra-dtest/compare/trunk...josh-mckenzie:cassandra-12988?expand=1]|
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412185#comment-17412185
]
Josh McKenzie commented on CASSANDRA-12988:
---
This patch as it stands ties read auth CL together at LOCAL_QUORUM, writes at
EACH_QUORUM. Previously, we had a kind of hodge-podge of them across various
classes:
* ConsistencyLevel.LOCAL_ONE for both read and write operations in
CassandraAuthorizer
* ConsistencyLevel.ONE for batches in there
* ConsistencyLevel.QUORUM for checks in CassandraRoleManager +
PasswordAuthenticator if the username is "cassandra"
* ConsistencyLevel.LOCAL_ONE for checks in CassandraRoleManager +
PasswordAuthenticator if the username is otherwise
Right now there's a handful of dtests failing as they're specifically looking
for error messages that match the above expected CL's for various auth
failures. At this point I think the right course of action is to tidy up those
dtests and also update NEWS.txt with some variation of the above note about the
change in consistency levels from essentially ONE to QUORUM.
Assuming no disagreement from you [~b.le...@gmail.com], I'll get on that in the
morning.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411899#comment-17411899
]
Josh McKenzie commented on CASSANDRA-12988:
---
Some dtest failures that look related to the slight changes in CL defaults that
come along w/the shape of the patch. Bouncing back to in progress while I work
through those as I'm not sure how invasive those changes will end up.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17411436#comment-17411436
]
Josh McKenzie commented on CASSANDRA-12988:
---
Have rebased and re-architected implementation here, tests running. Behaves on
DatabaseDescriptorRefTest locally.
||Item|Link||
|JDK8
tests|[Link|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/75/workflows/73c71040-88d4-4165-b7c1-010cbecf845c]|
|JDK11
tests|[Link|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/75/workflows/b96bbb92-0eb2-4b10-ae08-7f3956442a13]|
|PR|[Link|https://github.com/apache/cassandra/compare/trunk...josh-mckenzie:cassandra-12988?expand=1]|
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Josh McKenzie
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17372113#comment-17372113
]
Brandon Williams commented on CASSANDRA-12988:
--
Another 2 years, almost definitely needs a rebase. Cancelling patch.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Sam Tunnicliffe
>Priority: Low
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771362#comment-16771362
]
Robert Stupp commented on CASSANDRA-12988:
--
Well, the patch is >2yrs old and probably needs a rebase and might be a bit
late for 4.0.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
>Reporter: Jason Brown
>Assignee: Sam Tunnicliffe
>Priority: Minor
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097741#comment-16097741
]
Robert Stupp commented on CASSANDRA-12988:
--
[~jasobrown] is this patch-available?
The code looks good so far. Some thing though:
* The MBean should not use {{org.apache.cassandra.db.ConsistencyLevel}} but
instead just use a {{String}}. {{DatabaseDescriptor}} should continue to use
{{org.apache.cassandra.db.ConsistencyLevel}}
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Minor
> Fix For: 4.x
>
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886362#comment-15886362
]
Robert Stupp commented on CASSANDRA-12988:
--
Generally, I think this idea is fine. Since it's a new feature, I fear we have
to target 4.0/4.x for this.
The patch breaks {{DatabaseDescriptorRefTest}}, which ensures that daemon
components are not started just by accessing lovely {{DatabaseDescriptor}} -
for offline tools. {{ConsistencyLevel}} is one of the classes that would
indirectly start unwanted threads or load unwanted classes. TL;DR I think it's
necessary to refactor this a bit.
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Minor
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (CASSANDRA-12988) make the consistency level for user-level auth reads and writes configurable
[
https://issues.apache.org/jira/browse/CASSANDRA-12988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717165#comment-15717165
]
Jason Brown commented on CASSANDRA-12988:
-
Linked patch allows an operator to set the read and write consistency levels
for the auth tables independently, by setting a value in the yaml or calling a
JMX {{MXBean}}.
||3.X||trunk||
|[branch|https://github.com/jasobrown/cassandra/tree/config_auth_reads-3.X]|[branch|https://github.com/jasobrown/cassandra/tree/config_auth_reads-trunk]|
|[dtest|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-config_auth_reads-3.X-dtest/]|[dtest|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-config_auth_reads-trunk-dtest/]|
|[testall|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-config_auth_reads-3.X-testall/]|[testall|http://cassci.datastax.com/view/Dev/view/jasobrown/job/jasobrown-config_auth_reads-trunk-testall/]|
> make the consistency level for user-level auth reads and writes configurable
>
>
> Key: CASSANDRA-12988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12988
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Minor
>
> Most reads for the auth-related tables execute at {{LOCAL_ONE}}. We'd like to
> make it configurable, with the default still being {{LOCAL_ONE}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
