[jira] [Commented] (CASSANDRA-13578) mx4j configuration minor improvement
[ https://issues.apache.org/jira/browse/CASSANDRA-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140232#comment-16140232 ] Jason Brown commented on CASSANDRA-13578: - I'm +1, as well. Will commit today. > mx4j configuration minor improvement > > > Key: CASSANDRA-13578 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13578 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Minor > Fix For: 4.x > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13578) mx4j configuration minor improvement
[ https://issues.apache.org/jira/browse/CASSANDRA-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140082#comment-16140082 ] Jeremiah Jordan commented on CASSANDRA-13578: - +1 > mx4j configuration minor improvement > > > Key: CASSANDRA-13578 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13578 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Minor > Fix For: 4.x > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13578) mx4j configuration minor improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137858#comment-16137858
]
Jay Zhuang commented on CASSANDRA-13578:
[~jjordan] that makes sense. I updated the patch to make it backward
compatible, would you please review?
I tested it with both new way {{MX4J_PORT=8081}} and older way
{{MX4J_PORT=-Dmx4jport=8081}}, all works fine:
| branch | uTest |
| [13578-trunk|https://github.com/cooldoger/cassandra/tree/13578-trunk] |
[circleci#80|https://circleci.com/gh/cooldoger/cassandra/80] |
> mx4j configuration minor improvement
>
>
> Key: CASSANDRA-13578
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13578
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
> Fix For: 4.x
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13578) mx4j configuration minor improvement
[ https://issues.apache.org/jira/browse/CASSANDRA-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136103#comment-16136103 ] Jeremiah Jordan commented on CASSANDRA-13578: - For anyone that knew how is was supposed to be set this is changing the interface of using MX4J_PORT and MX4J_ADDRESS. If you want to introduce new options that just take a port and address then I think it would be more upgrade friendly to give them new names, and then accept the old way if set, or if not try the new way. > mx4j configuration minor improvement > > > Key: CASSANDRA-13578 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13578 > Project: Cassandra > Issue Type: Improvement > Components: Tools >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Minor > Fix For: 4.x > > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13578) mx4j configuration minor improvement
[
https://issues.apache.org/jira/browse/CASSANDRA-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043563#comment-16043563
]
Jay Zhuang commented on CASSANDRA-13578:
The problem is if anyone set {{MX4J_PORT=8081}} in the env instead of
{{MX4J_PORT=-Dmx4jport=8081}}, Cassandra will fail to start:
{{noformat}}
$ ./bin/cassandra
...
CompilerOracle: dontinline
org/apache/cassandra/io/util/RebufferingInputStream.readPrimitiveSlowly (I)J
CompilerOracle: inline
org/apache/cassandra/db/rows/UnfilteredSerializer.serializeRowBody
(Lorg/apache/cassandra/db/rows/Row;ILorg/apache/cassandra/db/SerializationHeader;Lorg/apache/cassandra/io/util/DataOutputPlus;)V
CompilerOracle: inline org/apache/cassandra/io/util/Memory.checkBounds (JJ)V
CompilerOracle: inline org/apache/cassandra/io/util/SafeMemory.checkBounds (JJ)V
CompilerOracle: inline
org/apache/cassandra/utils/AsymmetricOrdering.selectBoundary
(Lorg/apache/cassandra/utils/AsymmetricOrdering/Op;II)I
CompilerOracle: inline
org/apache/cassandra/utils/AsymmetricOrdering.strictnessOfLessThan
(Lorg/apache/cassandra/utils/AsymmetricOrdering/Op;)I
CompilerOracle: inline org/apache/cassandra/utils/BloomFilter.indexes
(Lorg/apache/cassandra/utils/IFilter/FilterKey;)[J
CompilerOracle: inline org/apache/cassandra/utils/BloomFilter.setIndexes
(JJIJ[J)V
CompilerOracle: inline org/apache/cassandra/utils/ByteBufferUtil.compare
(Ljava/nio/ByteBuffer;[B)I
CompilerOracle: inline org/apache/cassandra/utils/ByteBufferUtil.compare
([BLjava/nio/ByteBuffer;)I
CompilerOracle: inline
org/apache/cassandra/utils/ByteBufferUtil.compareUnsigned
(Ljava/nio/ByteBuffer;Ljava/nio/ByteBuffer;)I
CompilerOracle: inline
org/apache/cassandra/utils/FastByteOperations$UnsafeOperations.compareTo
(Ljava/lang/Object;JILjava/lang/Object;JI)I
CompilerOracle: inline
org/apache/cassandra/utils/FastByteOperations$UnsafeOperations.compareTo
(Ljava/lang/Object;JILjava/nio/ByteBuffer;)I
CompilerOracle: inline
org/apache/cassandra/utils/FastByteOperations$UnsafeOperations.compareTo
(Ljava/nio/ByteBuffer;Ljava/nio/ByteBuffer;)I
CompilerOracle: inline org/apache/cassandra/utils/vint/VIntCoding.encodeVInt
(JI)[B
Error: Could not find or load main class 8081
{{noformat}}
So I think it worth to have this change in 4.0.
> mx4j configuration minor improvement
>
>
> Key: CASSANDRA-13578
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13578
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Minor
> Fix For: 4.x
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
