[jira] [Commented] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
[
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057787#comment-16057787
]
Joaquin Casares commented on CASSANDRA-13625:
-
Sorry for that confusion, I've updated the main description. Thanks for
pointing that out! :)
> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joaquin Casares
>Assignee: Joaquin Casares
> Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml from {{>=
> 2.2.9, < 3}}.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
[
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057768#comment-16057768
]
Romain Hardouin commented on CASSANDRA-13625:
-
Ok! I understood >= 2.2.9
> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joaquin Casares
> Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
[
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057755#comment-16057755
]
Joaquin Casares commented on CASSANDRA-13625:
-
[~rha], I'm not for removing the setting from trunk, just from the 2.2.x
cassandra.yaml where the setting has never been implemented.
If you were to switch to the cassandra-2.2.9 branch and run your grep script
again, it should come back with no references.
> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joaquin Casares
> Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
[
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057223#comment-16057223
]
Romain Hardouin commented on CASSANDRA-13625:
-
Hi, I don't understand why do you want to remove this setting, it's still used
in trunk:
{code}
$ grep -IRn getMaxValueSize
test/unit/org/apache/cassandra/db/compaction/BlacklistingCompactionsTest.java:86:
maxValueSize = DatabaseDescriptor.getMaxValueSize();
test/unit/org/apache/cassandra/io/sstable/SSTableWriterTestBase.java:84:
maxValueSize = DatabaseDescriptor.getMaxValueSize();
test/unit/org/apache/cassandra/io/sstable/SSTableCorruptionDetectionTest.java:91:
maxValueSize = DatabaseDescriptor.getMaxValueSize();
src/java/org/apache/cassandra/db/ClusteringPrefix.java:377:
: (isEmpty(header, offset) ? ByteBufferUtil.EMPTY_BYTE_BUFFER :
types.get(offset).readValue(in, DatabaseDescriptor.getMaxValueSize()));
src/java/org/apache/cassandra/db/ClusteringPrefix.java:531:
: (Serializer.isEmpty(nextHeader, i) ? ByteBufferUtil.EMPTY_BYTE_BUFFER :
serializationHeader.clusteringTypes().get(i).readValue(in,
DatabaseDescriptor.getMaxValueSize()));
src/java/org/apache/cassandra/db/rows/Cell.java:246:value =
header.getType(column).readValue(in, DatabaseDescriptor.getMaxValueSize());
src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java:1056:
DecoratedKey key =
metadata.partitioner.decorateKey(metadata.partitionKeyType.readValue(in,
DatabaseDescriptor.getMaxValueSize()));
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:1054:public
static int getMaxValueSize()
{code}
{{getMaxValueSize()}} occurrences:
https://github.com/apache/cassandra/search?q=getMaxValueSize
> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joaquin Casares
> Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13625) Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
[
https://issues.apache.org/jira/browse/CASSANDRA-13625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056665#comment-16056665
]
Joaquin Casares commented on CASSANDRA-13625:
-
Here's a PR for the single-file fix:
https://github.com/apache/cassandra/pull/124.
> Remove unused cassandra.yaml setting, max_value_size_in_mb, from 2.2.9
> --
>
> Key: CASSANDRA-13625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13625
> Project: Cassandra
> Issue Type: Bug
>Reporter: Joaquin Casares
> Labels: lhf
> Fix For: 2.2.10
>
>
> {{max_value_size_in_mb}} is currently in the 2.2.9 cassandra.yaml, but does
> not make reference of the config in any place within its codebase:
> https://github.com/apache/cassandra/blob/cassandra-2.2.9/conf/cassandra.yaml#L888-L891
> CASSANDRA-9530, which introduced {{max_value_size_in_mb}}, has it's Fix
> Version/s marked as 3.0.7, 3.7, and 3.8.
> Let's remove the {{max_value_size_in_mb}} from the cassandra.yaml.
> {NOFORMAT}
> ~/repos/cassandra[(HEAD detached at cassandra-2.2.9)] (joaquin)$ grep -r
> max_value_size_in_mb .
> conf/cassandra.yaml:# max_value_size_in_mb: 256
> {NOFORMAT}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
