[jira] [Commented] (CASSANDRA-13837) Hanging threads in BulkLoader

2017-09-08 Thread Marcus Eriksson (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158266#comment-16158266
 ] 

Marcus Eriksson commented on CASSANDRA-13837:
-

LGTM, +1 (dtests didn't really run though, but sstableloader exits fine 
manually)

I just noticed 
[this|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/streaming/StreamResultFuture.java#L215]
 - I doubt that should be WARN? Feel free to remove or change to INFO on commit

> Hanging threads in BulkLoader
> -
>
> Key: CASSANDRA-13837
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13837
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Minor
>
> [~krummas] discovered some threads that were not closing correctly when he 
> fixed CASSANDRA-13836. We suspect this is due to 
> CASSANDRA-8457/CASSANDRA-12229.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13837) Hanging threads in BulkLoader

2017-09-07 Thread Jason Brown (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157655#comment-16157655
 ] 

Jason Brown commented on CASSANDRA-13837:
-

[~krummas] do you mind reviewing?

> Hanging threads in BulkLoader
> -
>
> Key: CASSANDRA-13837
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13837
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Minor
>
> [~krummas] discovered some threads that were not closing correctly when he 
> fixed CASSANDRA-13836. We suspect this is due to 
> CASSANDRA-8457/CASSANDRA-12229.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13837) Hanging threads in BulkLoader

2017-09-07 Thread Jason Brown (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157641#comment-16157641
 ] 

Jason Brown commented on CASSANDRA-13837:
-

Patch here:

||13837||
|[branch|https://github.com/jasobrown/cassandra/tree/13837]|
|[dtest|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/293/]|
|[utests|https://circleci.com/gh/jasobrown/cassandra/tree/13837]|

Basically, we just need to make the netty {{EventLoopGroup}} threads daemon 
threads

> Hanging threads in BulkLoader
> -
>
> Key: CASSANDRA-13837
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13837
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Minor
>
> [~krummas] discovered some threads that were not closing correctly when he 
> fixed CASSANDRA-13836. We suspect this is due to 
> CASSANDRA-8457/CASSANDRA-12229.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13837) Hanging threads in BulkLoader

2017-09-05 Thread Joel Knighton (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153917#comment-16153917
 ] 

Joel Knighton commented on CASSANDRA-13837:
---

I pointed [~mshuler] here prematurely - my bad. It looks like the System.exit 
uncommented in [CASSANDRA-13836] resolves the hang we were seeing on that test. 
The remaining hangs seem to be repair-related and unrelated to this ticket.

> Hanging threads in BulkLoader
> -
>
> Key: CASSANDRA-13837
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13837
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Minor
>
> [~krummas] discovered some threads that were not closing correctly when he 
> fixed CASSANDRA-13836. We suspect this is due to 
> CASSANDRA-8457/CASSANDRA-12229.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13837) Hanging threads in BulkLoader

2017-09-05 Thread Michael Shuler (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153868#comment-16153868
 ] 

Michael Shuler commented on CASSANDRA-13837:


This appears to be hanging up the trunk dtest jobs in random tests. We've been 
looking for a single dtest that might be problematic, but there doesn't seem to 
be a clear pattern on a particular test.

Any way we can bump the priority on this from Minor?

> Hanging threads in BulkLoader
> -
>
> Key: CASSANDRA-13837
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13837
> Project: Cassandra
>  Issue Type: Bug
>Reporter: Jason Brown
>Assignee: Jason Brown
>Priority: Minor
>
> [~krummas] discovered some threads that were not closing correctly when he 
> fixed CASSANDRA-13836. We suspect this is due to 
> CASSANDRA-8457/CASSANDRA-12229.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org