[jira] [Commented] (CASSANDRA-13933) Handle mutateRepaired failure in nodetool verify
[ https://issues.apache.org/jira/browse/CASSANDRA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351898#comment-16351898 ] Sumanth Pasupuleti commented on CASSANDRA-13933: [~krummas] attached patches for 3.0, 3.11 and trunk > Handle mutateRepaired failure in nodetool verify > > > Key: CASSANDRA-13933 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13933 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Sumanth Pasupuleti >Priority: Major > Labels: lhf > Attachments: CASSANDRA-13933-3.0.txt, CASSANDRA-13933-3.11.txt, > CASSANDRA-13933-trunk.txt > > > See comment here: > https://issues.apache.org/jira/browse/CASSANDRA-13922?focusedCommentId=16189875&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16189875 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13933) Handle mutateRepaired failure in nodetool verify
[ https://issues.apache.org/jira/browse/CASSANDRA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350907#comment-16350907 ] Sumanth Pasupuleti commented on CASSANDRA-13933: Thanks [~krummas] . Will be incorporating the comments and submitting patches for 3.0 and 3.11 too. [~jjordan] this is good to know, especially for a newbie in this community like me. Will keep this in mind. Thank you! > Handle mutateRepaired failure in nodetool verify > > > Key: CASSANDRA-13933 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13933 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Sumanth Pasupuleti >Priority: Major > Labels: lhf > Attachments: CASSANDRA-13933-trunk.txt > > > See comment here: > https://issues.apache.org/jira/browse/CASSANDRA-13922?focusedCommentId=16189875&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16189875 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13933) Handle mutateRepaired failure in nodetool verify
[ https://issues.apache.org/jira/browse/CASSANDRA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350615#comment-16350615 ] Jeremiah Jordan commented on CASSANDRA-13933: - This is just a drive by comment, but please be wary of changing the exception signature of exposed functions in 3.x, as depending on what is involved here it could break external plugin's/extensions. (Probably not relevant here since this is in the repair path, which I don't think we have any extension points in, but just like to remind people of that.) > Handle mutateRepaired failure in nodetool verify > > > Key: CASSANDRA-13933 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13933 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Sumanth Pasupuleti >Priority: Major > Labels: lhf > Attachments: CASSANDRA-13933-trunk.txt > > > See comment here: > https://issues.apache.org/jira/browse/CASSANDRA-13922?focusedCommentId=16189875&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16189875 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13933) Handle mutateRepaired failure in nodetool verify
[
https://issues.apache.org/jira/browse/CASSANDRA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350520#comment-16350520
]
Marcus Eriksson commented on CASSANDRA-13933:
-
Thanks for the patch [~sumanth.pasupuleti]
I think this looks good in general, small comments;
* I don't think we should declare {{throws CorruptSSTableException}} since it
is a {{RuntimeException}}
* we could remove the {{throws IOException}} from {{markAndThrow}} (and its
callers) now since we always throw {{CorruptSSTableException}} instead
We need to apply this to 3.0, 3.11 and trunk, can you provide patches?
> Handle mutateRepaired failure in nodetool verify
>
>
> Key: CASSANDRA-13933
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13933
> Project: Cassandra
> Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Sumanth Pasupuleti
>Priority: Major
> Labels: lhf
> Attachments: CASSANDRA-13933-trunk.txt
>
>
> See comment here:
> https://issues.apache.org/jira/browse/CASSANDRA-13922?focusedCommentId=16189875&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16189875
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13933) Handle mutateRepaired failure in nodetool verify
[
https://issues.apache.org/jira/browse/CASSANDRA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349506#comment-16349506
]
Sumanth Pasupuleti commented on CASSANDRA-13933:
[~krummas] Submitted the patch. Please let me know if you have any comments.
Couple of things:
# Ended up going with an info log as against warn log (where I can potentially
log the exception details). Curious to know your thoughts.
# Three tests failed; wasnt sure if they are related, but digging through
||Class||Name||Status||Type||Time(s)||
|BatchlogTest|testSerialization|Failure|expected:<10> but was:<0>
{{junit.framework.AssertionFailedError: expected:<10> but was:<0>}}
{{at
org.apache.cassandra.batchlog.BatchlogTest.testSerialization(BatchlogTest.java:95)}}|0.024|
|CommitLogDescriptorTest|testVersions|Failure|expected:<11> but was:<12>
{{junit.framework.AssertionFailedError: expected:<11> but was:<12>}}
{{at
org.apache.cassandra.db.commitlog.CommitLogDescriptorTest.testVersions(CommitLogDescriptorTest.java:84)}}|0.284|
|ShadowRoundTest|testDelayedResponse|Failure|expected: but was:
{{junit.framework.AssertionFailedError: expected: but was:}}
{{at
org.apache.cassandra.gms.ShadowRoundTest.testDelayedResponse(ShadowRoundTest.java:106)}}|
> Handle mutateRepaired failure in nodetool verify
>
>
> Key: CASSANDRA-13933
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13933
> Project: Cassandra
> Issue Type: Bug
>Reporter: Marcus Eriksson
>Assignee: Sumanth Pasupuleti
>Priority: Major
> Labels: lhf
> Attachments: CASSANDRA-13933-trunk.txt
>
>
> See comment here:
> https://issues.apache.org/jira/browse/CASSANDRA-13922?focusedCommentId=16189875&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16189875
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13933) Handle mutateRepaired failure in nodetool verify
[ https://issues.apache.org/jira/browse/CASSANDRA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348504#comment-16348504 ] Marcus Eriksson commented on CASSANDRA-13933: - no it is fine, I can rebase on top of your patch > Handle mutateRepaired failure in nodetool verify > > > Key: CASSANDRA-13933 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13933 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Sumanth Pasupuleti >Priority: Major > Labels: lhf > > See comment here: > https://issues.apache.org/jira/browse/CASSANDRA-13922?focusedCommentId=16189875&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16189875 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13933) Handle mutateRepaired failure in nodetool verify
[ https://issues.apache.org/jira/browse/CASSANDRA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347853#comment-16347853 ] Sumanth Pasupuleti commented on CASSANDRA-13933: [~krummas] I am done with my changes and should be ready to submit the commit for review tomorrow. However, your commit (thanks for pointing me to 14201) [https://github.com/krummas/cassandra/commit/1489a5b66f60c733aaa1749d2d2ad36457e21824] would have merge conflicts with my changes. Let me know if I should wait for your changes to be in trunk, and submit changes on top of yours. > Handle mutateRepaired failure in nodetool verify > > > Key: CASSANDRA-13933 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13933 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Sumanth Pasupuleti >Priority: Major > Labels: lhf > > See comment here: > https://issues.apache.org/jira/browse/CASSANDRA-13922?focusedCommentId=16189875&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16189875 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13933) Handle mutateRepaired failure in nodetool verify
[ https://issues.apache.org/jira/browse/CASSANDRA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347023#comment-16347023 ] Marcus Eriksson commented on CASSANDRA-13933: - also note CASSANDRA-14201 > Handle mutateRepaired failure in nodetool verify > > > Key: CASSANDRA-13933 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13933 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Assignee: Sumanth Pasupuleti >Priority: Major > Labels: lhf > > See comment here: > https://issues.apache.org/jira/browse/CASSANDRA-13922?focusedCommentId=16189875&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16189875 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13933) Handle mutateRepaired failure in nodetool verify
[ https://issues.apache.org/jira/browse/CASSANDRA-13933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347013#comment-16347013 ] Sumanth Pasupuleti commented on CASSANDRA-13933: [~krummas] I would like to work on submitting a patch for this. Would you be able to assign this to me, and mark the status to be InProgress? I am not sure if I have access to do it. > Handle mutateRepaired failure in nodetool verify > > > Key: CASSANDRA-13933 > URL: https://issues.apache.org/jira/browse/CASSANDRA-13933 > Project: Cassandra > Issue Type: Bug >Reporter: Marcus Eriksson >Priority: Major > Labels: lhf > > See comment here: > https://issues.apache.org/jira/browse/CASSANDRA-13922?focusedCommentId=16189875&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16189875 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
