[jira] [Commented] (CASSANDRA-14306) Single config variable to specify logs path
[ https://issues.apache.org/jira/browse/CASSANDRA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006389#comment-17006389 ] Michael Semb Wever commented on CASSANDRA-14306: ||branch||circleci||asf jenkins testall||asf jenkins dtests|| |[cassandra-3.0_14306|https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/cassandra-3.0_14306]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.0_14306]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/39/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/39/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/712/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/712]| |[cassandra-3.11_14306|https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/cassandra-3.11_14306]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Fcassandra-3.11_14306]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/40/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/40/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/713/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/713]| |[trunk_14306|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/trunk_14306]|[circleci|https://circleci.com/gh/thelastpickle/workflows/cassandra/tree/mck%2Ftrunk_14306]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/41/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-testall/41/]|[!https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/714/badge/icon!|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/714]| > Single config variable to specify logs path > --- > > Key: CASSANDRA-14306 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14306 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Angelo Polo >Priority: Low > Attachments: unified_logs_dir.patch, unified_logs_dir_v2_3.11.patch, > unified_logs_dir_v2_trunk.patch > > > Motivation: All configuration should take place in bin/cassandra.in.sh (for > non-Windows) and the various conf/ files. In particular, bin/cassandra should > not need to be modified upon installation. In many installs, $CASSANDRA_HOME > is not a writable location, the yaml setting 'data_file_directories' is being > set to a non-default location, etc. It would be good to have a single > variable in an explicit conf file to specify where logs should be written. > For non-Windows installs, there are currently two places where the log > directory is set: in conf/cassandra-env.sh and in bin/cassandra. The defaults > for these are both $CASSANDRA_HOME/logs. These can be unified to a single > variable CASSANDRA_LOGS that is set in conf/cassandra-env.sh, with the > intention that it would be modified once there (if not set in the > environment) by a user running a custom installation. Then include a check in > bin/cassandra that CASSANDRA_LOGS is set in case conf/cassandra-env.sh > doesn't get sourced on startup, and provide a default value if not. For the > scenario that a user would prefer different paths for the logback logs and > the GC logs, they can still go into bin/cassandra to set the second path, > just as they would do currently. See "unified_logs_dir.patch" for a proposed > patch. > No change seems necessary for the Windows scripts. The two uses of > $CASSANDRA_HOME/logs are in the same script conf/cassandra-env.ps1 within > scrolling distance of each other (lines 278-301). They haven't been combined > I suppose because of the different path separators in the two usages. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14306) Single config variable to specify logs path
[ https://issues.apache.org/jira/browse/CASSANDRA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004843#comment-17004843 ] Michael Semb Wever commented on CASSANDRA-14306: Thanks [~polo-language], am taking a look now. It can be a bit overwhelming to ensure tickets are always tackled in the correct order, appreciate the new patches. > Single config variable to specify logs path > --- > > Key: CASSANDRA-14306 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14306 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Angelo Polo >Priority: Low > Attachments: unified_logs_dir.patch, unified_logs_dir_v2_3.11.patch, > unified_logs_dir_v2_trunk.patch > > > Motivation: All configuration should take place in bin/cassandra.in.sh (for > non-Windows) and the various conf/ files. In particular, bin/cassandra should > not need to be modified upon installation. In many installs, $CASSANDRA_HOME > is not a writable location, the yaml setting 'data_file_directories' is being > set to a non-default location, etc. It would be good to have a single > variable in an explicit conf file to specify where logs should be written. > For non-Windows installs, there are currently two places where the log > directory is set: in conf/cassandra-env.sh and in bin/cassandra. The defaults > for these are both $CASSANDRA_HOME/logs. These can be unified to a single > variable CASSANDRA_LOGS that is set in conf/cassandra-env.sh, with the > intention that it would be modified once there (if not set in the > environment) by a user running a custom installation. Then include a check in > bin/cassandra that CASSANDRA_LOGS is set in case conf/cassandra-env.sh > doesn't get sourced on startup, and provide a default value if not. For the > scenario that a user would prefer different paths for the logback logs and > the GC logs, they can still go into bin/cassandra to set the second path, > just as they would do currently. See "unified_logs_dir.patch" for a proposed > patch. > No change seems necessary for the Windows scripts. The two uses of > $CASSANDRA_HOME/logs are in the same script conf/cassandra-env.ps1 within > scrolling distance of each other (lines 278-301). They haven't been combined > I suppose because of the different path separators in the two usages. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14306) Single config variable to specify logs path
[ https://issues.apache.org/jira/browse/CASSANDRA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004830#comment-17004830 ] Angelo Polo commented on CASSANDRA-14306: - This issue predates 15090, so it was just a different choice of name for the same concept. I've attached two updated patches (of conf/cassandra-env.sh only) for the GC logs. These use the now-committed variable name CASSANDRA_LOG_DIR. * [^unified_logs_dir_v2_trunk.patch] * [^unified_logs_dir_v2_3.11.patch] > Single config variable to specify logs path > --- > > Key: CASSANDRA-14306 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14306 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Angelo Polo >Priority: Low > Attachments: unified_logs_dir.patch, unified_logs_dir_v2_3.11.patch, > unified_logs_dir_v2_trunk.patch > > > Motivation: All configuration should take place in bin/cassandra.in.sh (for > non-Windows) and the various conf/ files. In particular, bin/cassandra should > not need to be modified upon installation. In many installs, $CASSANDRA_HOME > is not a writable location, the yaml setting 'data_file_directories' is being > set to a non-default location, etc. It would be good to have a single > variable in an explicit conf file to specify where logs should be written. > For non-Windows installs, there are currently two places where the log > directory is set: in conf/cassandra-env.sh and in bin/cassandra. The defaults > for these are both $CASSANDRA_HOME/logs. These can be unified to a single > variable CASSANDRA_LOGS that is set in conf/cassandra-env.sh, with the > intention that it would be modified once there (if not set in the > environment) by a user running a custom installation. Then include a check in > bin/cassandra that CASSANDRA_LOGS is set in case conf/cassandra-env.sh > doesn't get sourced on startup, and provide a default value if not. For the > scenario that a user would prefer different paths for the logback logs and > the GC logs, they can still go into bin/cassandra to set the second path, > just as they would do currently. See "unified_logs_dir.patch" for a proposed > patch. > No change seems necessary for the Windows scripts. The two uses of > $CASSANDRA_HOME/logs are in the same script conf/cassandra-env.ps1 within > scrolling distance of each other (lines 278-301). They haven't been combined > I suppose because of the different path separators in the two usages. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14306) Single config variable to specify logs path
[
https://issues.apache.org/jira/browse/CASSANDRA-14306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004724#comment-17004724
]
Michael Semb Wever commented on CASSANDRA-14306:
In the {{bin/cassandra}} file what's the difference between the
{{CASSANDRA_LOG_DIR}} and {{CASSANDRA_LOGS}} variables?
IE why are we introducing the second? Maybe this can all be standardised just
using the existing {{CASSANDRA_LOG_DIR}} variable?
> Single config variable to specify logs path
> ---
>
> Key: CASSANDRA-14306
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14306
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Angelo Polo
>Priority: Low
> Attachments: unified_logs_dir.patch
>
>
> Motivation: All configuration should take place in bin/cassandra.in.sh (for
> non-Windows) and the various conf/ files. In particular, bin/cassandra should
> not need to be modified upon installation. In many installs, $CASSANDRA_HOME
> is not a writable location, the yaml setting 'data_file_directories' is being
> set to a non-default location, etc. It would be good to have a single
> variable in an explicit conf file to specify where logs should be written.
> For non-Windows installs, there are currently two places where the log
> directory is set: in conf/cassandra-env.sh and in bin/cassandra. The defaults
> for these are both $CASSANDRA_HOME/logs. These can be unified to a single
> variable CASSANDRA_LOGS that is set in conf/cassandra-env.sh, with the
> intention that it would be modified once there (if not set in the
> environment) by a user running a custom installation. Then include a check in
> bin/cassandra that CASSANDRA_LOGS is set in case conf/cassandra-env.sh
> doesn't get sourced on startup, and provide a default value if not. For the
> scenario that a user would prefer different paths for the logback logs and
> the GC logs, they can still go into bin/cassandra to set the second path,
> just as they would do currently. See "unified_logs_dir.patch" for a proposed
> patch.
> No change seems necessary for the Windows scripts. The two uses of
> $CASSANDRA_HOME/logs are in the same script conf/cassandra-env.ps1 within
> scrolling distance of each other (lines 278-301). They haven't been combined
> I suppose because of the different path separators in the two usages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
