[jira] [Commented] (CASSANDRA-14492) Test use of thousands separators and comma decimal separators
[
https://issues.apache.org/jira/browse/CASSANDRA-14492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16527071#comment-16527071
]
Patrick Bannister commented on CASSANDRA-14492:
---
Looks like my original coverage analysis didn't handle termination of the
multiprocessing.Process objects that we run to do COPY tasks. After resolving
this, it's clear that we are definitely exercising the codepaths for custom
thousands separators and decimal separators.
> Test use of thousands separators and comma decimal separators
> -
>
> Key: CASSANDRA-14492
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14492
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Patrick Bannister
>Priority: Major
> Labels: cqlsh, test
> Fix For: 4.x
>
>
> Coverage analysis showed no coverage for functions related to displaying
> numbers with thousands separators ("$100,000,000,000" instead of
> "$1000") and displaying numbers with custom decimal separators
> ("3,1415927" instead of "3.1415927").
> We should add a test that displays numbers like this, or identify an existing
> test that does it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14492) Test use of thousands separators and comma decimal separators
[
https://issues.apache.org/jira/browse/CASSANDRA-14492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16525752#comment-16525752
]
Patrick Bannister commented on CASSANDRA-14492:
---
The dtest test_number_separators_round_trip() in
cqlsh_tests/cqlsh_copy_tests.py already tests both of these features. However,
since the test occurs in the context of COPY statements, it uses a different
code path: there's a separate integer formatting function used for COPY TO
statements, implemented in cqlshlib/copyutil.py, instead of the formatting
functions in cqlshlib/formatting.py.
It's interesting that we've implemented datatype formatting in more than one
place.
> Test use of thousands separators and comma decimal separators
> -
>
> Key: CASSANDRA-14492
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14492
> Project: Cassandra
> Issue Type: Sub-task
>Reporter: Patrick Bannister
>Priority: Major
> Labels: cqlsh, test
> Fix For: 4.x
>
>
> Coverage analysis showed no coverage for functions related to displaying
> numbers with thousands separators ("$100,000,000,000" instead of
> "$1000") and displaying numbers with custom decimal separators
> ("3,1415927" instead of "3.1415927").
> We should add a test that displays numbers like this, or identify an existing
> test that does it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
