[jira] [Commented] (CASSANDRA-14693) Follow-up: allow transient node to serve as repair coordinator
[ https://issues.apache.org/jira/browse/CASSANDRA-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611250#comment-16611250 ] Alex Petrov commented on CASSANDRA-14693: - Thank you [~krummas], I've incorporated your comment on commit. [~aweisberg] I'll open a separate issue: it's not that difficult to write tests for RepairJob streams, but there are quite a few cases, so it'd be good to work in it separately. Committed as [0841353e90f1cc94dc47b435af87e4d5876478ea|https://github.com/apache/cassandra/commit/0841353e90f1cc94dc47b435af87e4d5876478ea] to trunk. > Follow-up: allow transient node to serve as repair coordinator > -- > > Key: CASSANDRA-14693 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14693 > Project: Cassandra > Issue Type: Task >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Minor > > Allow transient node to serve as a coordinator. > |[trunk|https://github.com/apache/cassandra/pull/257]|[utest|https://circleci.com/gh/ifesdjeen/cassandra/329]|[dtest|https://circleci.com/gh/ifesdjeen/cassandra/330]|[dtest-novnode|https://circleci.com/gh/ifesdjeen/cassandra/328]| -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14693) Follow-up: allow transient node to serve as repair coordinator
[
https://issues.apache.org/jira/browse/CASSANDRA-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609471#comment-16609471
]
Marcus Eriksson commented on CASSANDRA-14693:
-
the new class hierarchy looks great, just a minor comment that we could remove
the parameter to {{startSync}} and instead make {{private final
List> rangesToSync;}} protected and use that, makes it a bit
clearer since we never call {{startSync}} with anything else
> Follow-up: allow transient node to serve as repair coordinator
> --
>
> Key: CASSANDRA-14693
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14693
> Project: Cassandra
> Issue Type: Task
>Reporter: Alex Petrov
>Assignee: Alex Petrov
>Priority: Minor
>
> Allow transient node to serve as a coordinator.
> |[trunk|https://github.com/apache/cassandra/pull/257]|[utest|https://circleci.com/gh/ifesdjeen/cassandra/329]|[dtest|https://circleci.com/gh/ifesdjeen/cassandra/330]|[dtest-novnode|https://circleci.com/gh/ifesdjeen/cassandra/328]|
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14693) Follow-up: allow transient node to serve as repair coordinator
[ https://issues.apache.org/jira/browse/CASSANDRA-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607586#comment-16607586 ] Marcus Eriksson commented on CASSANDRA-14693: - [~ifesdjeen] yes, I'll have a look monday > Follow-up: allow transient node to serve as repair coordinator > -- > > Key: CASSANDRA-14693 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14693 > Project: Cassandra > Issue Type: Task >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Minor > > Allow transient node to serve as a coordinator. > |[trunk|https://github.com/apache/cassandra/pull/257]|[utest|https://circleci.com/gh/ifesdjeen/cassandra/329]|[dtest|https://circleci.com/gh/ifesdjeen/cassandra/330]|[dtest-novnode|https://circleci.com/gh/ifesdjeen/cassandra/328]| -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14693) Follow-up: allow transient node to serve as repair coordinator
[ https://issues.apache.org/jira/browse/CASSANDRA-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607578#comment-16607578 ] Alex Petrov commented on CASSANDRA-14693: - [~krummas] would you able to take a look at the class Repair Task hierarchy refactoring? [~aweisberg] I'll take a closer look at the test. > Follow-up: allow transient node to serve as repair coordinator > -- > > Key: CASSANDRA-14693 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14693 > Project: Cassandra > Issue Type: Task >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Minor > > Allow transient node to serve as a coordinator. > |[trunk|https://github.com/apache/cassandra/pull/257]|[utest|https://circleci.com/gh/ifesdjeen/cassandra/329]|[dtest|https://circleci.com/gh/ifesdjeen/cassandra/330]|[dtest-novnode|https://circleci.com/gh/ifesdjeen/cassandra/328]| -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14693) Follow-up: allow transient node to serve as repair coordinator
[ https://issues.apache.org/jira/browse/CASSANDRA-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607506#comment-16607506 ] Ariel Weisberg commented on CASSANDRA-14693: +1. I am ok with doing a RepairJob test separately, but it does seem like a core class that deserves a unit test. > Follow-up: allow transient node to serve as repair coordinator > -- > > Key: CASSANDRA-14693 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14693 > Project: Cassandra > Issue Type: Task >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Minor > > Allow transient node to serve as a coordinator. > |[trunk|https://github.com/apache/cassandra/pull/257]|[utest|https://circleci.com/gh/ifesdjeen/cassandra/329]|[dtest|https://circleci.com/gh/ifesdjeen/cassandra/330]|[dtest-novnode|https://circleci.com/gh/ifesdjeen/cassandra/328]| -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14693) Follow-up: allow transient node to serve as repair coordinator
[ https://issues.apache.org/jira/browse/CASSANDRA-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606454#comment-16606454 ] Blake Eggleston commented on CASSANDRA-14693: - bq. Seems like we don't have a RepairJob unit test :-P Not really no. I'll open a JIRA, but it will require a little refactoring. > Follow-up: allow transient node to serve as repair coordinator > -- > > Key: CASSANDRA-14693 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14693 > Project: Cassandra > Issue Type: Task >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Minor > > Allow transient node to serve as a coordinator. > |[trunk|https://github.com/apache/cassandra/pull/257]|[utest|https://circleci.com/gh/ifesdjeen/cassandra/329]|[dtest|https://circleci.com/gh/ifesdjeen/cassandra/330]|[dtest-novnode|https://circleci.com/gh/ifesdjeen/cassandra/328]| -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14693) Follow-up: allow transient node to serve as repair coordinator
[ https://issues.apache.org/jira/browse/CASSANDRA-14693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606208#comment-16606208 ] Ariel Weisberg commented on CASSANDRA-14693: Looks good to me modulo the three trivial comments. Do we feel we have an end to end test that makes it look like LocalSyncTask is doing the right thing? The unit test is pretty that LocalSyncTask does the right thing, but what about the code that constructs the LocalSyncTask? Seems like we don't have a RepairJob unit tests :-P > Follow-up: allow transient node to serve as repair coordinator > -- > > Key: CASSANDRA-14693 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14693 > Project: Cassandra > Issue Type: Task >Reporter: Alex Petrov >Assignee: Alex Petrov >Priority: Minor > > Allow transient node to serve as a coordinator. > |[trunk|https://github.com/apache/cassandra/pull/257]|[utest|https://circleci.com/gh/ifesdjeen/cassandra/329]|[dtest|https://circleci.com/gh/ifesdjeen/cassandra/330]|[dtest-novnode|https://circleci.com/gh/ifesdjeen/cassandra/328]| -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
