[jira] [Commented] (CASSANDRA-15052) Dtests: Add acceptable warnings to offline tool tests in order to pass them
[ https://issues.apache.org/jira/browse/CASSANDRA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089291#comment-17089291 ] Stefan Miklosovic commented on CASSANDRA-15052: --- I dont think this is issue anymore. I think I have tested this on unrealistically low disk usage and that is what emitted these warnings. > Dtests: Add acceptable warnings to offline tool tests in order to pass them > --- > > Key: CASSANDRA-15052 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15052 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Labels: pull-request-available > Attachments: SPICE-15052.txt > > Time Spent: 50m > Remaining Estimate: 0h > > I run all dtest suite and test > offline_tools_test.py::TestOfflineTools::test_sstablelevelreset has failed > because of additional warning logs which were not added into acceptable ones. > After adding them, test passed fine. I believe added warning messages have > nothing to do with test itself, it was reproduced on c5.9xlarge as well as no > "regular" notebook. > > https://github.com/apache/cassandra-dtest/pull/47 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15052) Dtests: Add acceptable warnings to offline tool tests in order to pass them
[ https://issues.apache.org/jira/browse/CASSANDRA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089239#comment-17089239 ] Dinesh Joshi commented on CASSANDRA-15052: -- [~stefan.miklosovic] is this still an issue? If so can you please add steps to repro or can we close it? > Dtests: Add acceptable warnings to offline tool tests in order to pass them > --- > > Key: CASSANDRA-15052 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15052 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Labels: pull-request-available > Attachments: SPICE-15052.txt > > Time Spent: 50m > Remaining Estimate: 0h > > I run all dtest suite and test > offline_tools_test.py::TestOfflineTools::test_sstablelevelreset has failed > because of additional warning logs which were not added into acceptable ones. > After adding them, test passed fine. I believe added warning messages have > nothing to do with test itself, it was reproduced on c5.9xlarge as well as no > "regular" notebook. > > https://github.com/apache/cassandra-dtest/pull/47 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15052) Dtests: Add acceptable warnings to offline tool tests in order to pass them
[ https://issues.apache.org/jira/browse/CASSANDRA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989270#comment-16989270 ] Dinesh Joshi commented on CASSANDRA-15052: -- [~marcuse] I was not able to repro the issue. > Dtests: Add acceptable warnings to offline tool tests in order to pass them > --- > > Key: CASSANDRA-15052 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15052 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Labels: pull-request-available > Attachments: SPICE-15052.txt > > Time Spent: 50m > Remaining Estimate: 0h > > I run all dtest suite and test > offline_tools_test.py::TestOfflineTools::test_sstablelevelreset has failed > because of additional warning logs which were not added into acceptable ones. > After adding them, test passed fine. I believe added warning messages have > nothing to do with test itself, it was reproduced on c5.9xlarge as well as no > "regular" notebook. > > https://github.com/apache/cassandra-dtest/pull/47 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15052) Dtests: Add acceptable warnings to offline tool tests in order to pass them
[ https://issues.apache.org/jira/browse/CASSANDRA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971498#comment-16971498 ] Marcus Eriksson commented on CASSANDRA-15052: - [~djoshi] / [~stefan.miklosovic] was this figured out? > Dtests: Add acceptable warnings to offline tool tests in order to pass them > --- > > Key: CASSANDRA-15052 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15052 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Labels: pull-request-available > Attachments: SPICE-15052.txt > > Time Spent: 50m > Remaining Estimate: 0h > > I run all dtest suite and test > offline_tools_test.py::TestOfflineTools::test_sstablelevelreset has failed > because of additional warning logs which were not added into acceptable ones. > After adding them, test passed fine. I believe added warning messages have > nothing to do with test itself, it was reproduced on c5.9xlarge as well as no > "regular" notebook. > > https://github.com/apache/cassandra-dtest/pull/47 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15052) Dtests: Add acceptable warnings to offline tool tests in order to pass them
[ https://issues.apache.org/jira/browse/CASSANDRA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814927#comment-16814927 ] Dinesh Joshi commented on CASSANDRA-15052: -- [~stefan.miklosovic], I don't see the failure in my test run. It doesn't appear on CircleCI. Perhaps we should jump on a call to discuss this further? I'll send you an email offline. > Dtests: Add acceptable warnings to offline tool tests in order to pass them > --- > > Key: CASSANDRA-15052 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15052 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Labels: pull-request-available > Attachments: SPICE-15052.txt > > Time Spent: 50m > Remaining Estimate: 0h > > I run all dtest suite and test > offline_tools_test.py::TestOfflineTools::test_sstablelevelreset has failed > because of additional warning logs which were not added into acceptable ones. > After adding them, test passed fine. I believe added warning messages have > nothing to do with test itself, it was reproduced on c5.9xlarge as well as no > "regular" notebook. > > https://github.com/apache/cassandra-dtest/pull/47 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15052) Dtests: Add acceptable warnings to offline tool tests in order to pass them
[
https://issues.apache.org/jira/browse/CASSANDRA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806294#comment-16806294
]
Stefan Miklosovic commented on CASSANDRA-15052:
---
[~djoshi3]
please see the attached log against your trunk and WITHOUT this fix
[^SPICE-15052.txt]
I think the issue is this:
{code:java}
Small commitlog volume detected at /tmp/dtest-78woi6j_/test/node1/commitlogs;
setting commitlog_to...21.000GiB free across all data volumes. Consider adding
more capacity to your cluster or removing obsolete snapshots\n'
...
WARN 10:16:28,580 Small commitlog volume detected at
/tmp/dtest-78woi6j_/test/node1/commitlogs; setting commitlog_total_space_in_mb
to 7428. You can override this in cassandra.yaml
WARN 10:16:28,583 Small cdc volume detected at
/tmp/dtest-78woi6j_/test/node1/cdc_raw; setting cdc_total_space_in_mb to 3714.
You can override this in cassandra.yaml
WARN 10:16:28,584 Only 21.000GiB free across all data volumes. Consider adding
more capacity to your cluster or removing obsolete snapshots
{code}
Which is true, but how did it compute 21 GiB specifically? Seems like it summed
up /run with / and tmpfs, thats rather misleading imho.
{code:java}
(venv) smiklosovic@ip-172-31-8-142:~/temp/cassandra-dtest$ df -h
Filesystem Size Used Avail Use% Mounted on
udev 35G 0 35G 0% /dev
tmpfs 6.9G 876K 6.9G 1% /run
/dev/nvme0n1p1 30G 23G 7.0G 76% /
tmpfs35G 0 35G 0% /dev/shm
tmpfs 5.0M 0 5.0M 0% /run/lock
tmpfs35G 0 35G 0% /sys/fs/cgroup
/dev/loop0 13M 13M 0 100% /snap/amazon-ssm-agent/295
/dev/loop1 18M 18M 0 100% /snap/amazon-ssm-agent/1068
/dev/loop3 91M 91M 0 100% /snap/core/6405
/dev/loop4 92M 92M 0 100% /snap/core/6531
/dev/loop5 90M 90M 0 100% /snap/core/6673
tmpfs 6.9G 0 6.9G 0% /run/user/1000
{code}
What is the minimum here and how is it computed? There is not any mention about
the available space for dtests to allocate to run tests fine. We should either
document what diskspace dtests requires or we should suppress this warning or
we should change the values of these properties. Dtest runs fine if we include
that message among expected warning-ones.
> Dtests: Add acceptable warnings to offline tool tests in order to pass them
> ---
>
> Key: CASSANDRA-15052
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15052
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Labels: pull-request-available
> Attachments: SPICE-15052.txt
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I run all dtest suite and test
> offline_tools_test.py::TestOfflineTools::test_sstablelevelreset has failed
> because of additional warning logs which were not added into acceptable ones.
> After adding them, test passed fine. I believe added warning messages have
> nothing to do with test itself, it was reproduced on c5.9xlarge as well as no
> "regular" notebook.
>
> https://github.com/apache/cassandra-dtest/pull/47
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15052) Dtests: Add acceptable warnings to offline tool tests in order to pass them
[
https://issues.apache.org/jira/browse/CASSANDRA-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805507#comment-16805507
]
Dinesh Joshi commented on CASSANDRA-15052:
--
Hi [~stefan.miklosovic], I got around to checking this out and I can't seem to
repro the issue. {{offline_tools_test.py::test_sstablelevelreset}} passes for
me. I don't see a failure. Here's how I ran it locally (within a virtualenv):
{noformat}
pytest --cassandra-dir=/home/dj/cassandra -s -k test_sstablelevelreset
{noformat}
I am running this against latest trunk @
df8e068c721d503e5f72a397c393c3034ecccef3.
> Dtests: Add acceptable warnings to offline tool tests in order to pass them
> ---
>
> Key: CASSANDRA-15052
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15052
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest
>Reporter: Stefan Miklosovic
>Assignee: Stefan Miklosovic
>Priority: Normal
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I run all dtest suite and test
> offline_tools_test.py::TestOfflineTools::test_sstablelevelreset has failed
> because of additional warning logs which were not added into acceptable ones.
> After adding them, test passed fine. I believe added warning messages have
> nothing to do with test itself, it was reproduced on c5.9xlarge as well as no
> "regular" notebook.
>
> https://github.com/apache/cassandra-dtest/pull/47
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
