[
https://issues.apache.org/jira/browse/CASSANDRA-15124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841875#comment-16841875
]
Chris Lohfink commented on CASSANDRA-15124:
---
Review feedback from [~andrew.tolbert] added:
* Somewhat confusing that the title for threadpools endpoint is Thread stats,
accidentally found myself typing in /api/v1/threadstats. Can probably just
name it Thread pools
* List of many of the thread pools in Cassandra and their state seems kinda
awkward, could just steal this from tpstats docs: Provides usage statistics of
thread pools.
* With the json API, one thing that might be nice is that instead of returning
an array of arrays, would be to just key by a field and return a json object
with the keys being the value of the primary field. I.E. it'd be easier to do
obj['tombstone_warn_threshold'] than to parse through the array to find the
relevant key. Would require further transformation but could be nice.
* same for threadpools to key off name result['MutationStage']
* When start sidecar would be nice to log something indicating how to get to
the docs endpoint.
* CQLSession.address is public when you probably didn't mean it to be, and some
field variables could be made final.
* At CQLSession line 159, should log the exception instead of the message so
you can get a full stack trace (logger.error("Cassandra configuration is
incorrect.", e);)
> Virtual tables API endpoints for sidecar
>
>
> Key: CASSANDRA-15124
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15124
> Project: Cassandra
> Issue Type: New Feature
> Components: Sidecar
>Reporter: Chris Lohfink
>Assignee: Chris Lohfink
>Priority: Normal
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Expose the existing virtual tables in sidecar api
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org