[jira] [Commented] (CASSANDRA-15153) Ensure Caffeine cache does not return stale entries
[ https://issues.apache.org/jira/browse/CASSANDRA-15153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17416878#comment-17416878 ] Brandon Williams commented on CASSANDRA-15153: -- Thanks [~ben.manes]. Luckily the impact here remained only theoretical, but we'll try to do a better job of keeping up in the future. > Ensure Caffeine cache does not return stale entries > --- > > Key: CASSANDRA-15153 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15153 > Project: Cassandra > Issue Type: Bug > Components: Feature/Authorization >Reporter: Per Otterström >Assignee: Aleksei Zotov >Priority: Normal > Labels: security > Fix For: 4.0.2, 4.1 > > > Version 2.3.5 of the Caffeine cache that we're using in various places can > hand out stale entries in some cases. This seem to happen when an update > fails repeatedly, in which case Caffeine may return a previously loaded > value. For instance, the AuthCache may hand out permissions even though the > reload operation is failing, see CASSANDRA-15041. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15153) Ensure Caffeine cache does not return stale entries
[ https://issues.apache.org/jira/browse/CASSANDRA-15153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17416868#comment-17416868 ] Ben Manes commented on CASSANDRA-15153: --- Sorry for the bug here. There are so many moving parts that I probably confused myself when writing that original and obviously bad code.. I'll review the test cases to make sure that this metadata is covered and not just fixed. Please do try to keep updated to recent versions for bug fixes. > Ensure Caffeine cache does not return stale entries > --- > > Key: CASSANDRA-15153 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15153 > Project: Cassandra > Issue Type: Bug > Components: Feature/Authorization >Reporter: Per Otterström >Assignee: Aleksei Zotov >Priority: Normal > Labels: security > Fix For: 4.0.2, 4.1 > > > Version 2.3.5 of the Caffeine cache that we're using in various places can > hand out stale entries in some cases. This seem to happen when an update > fails repeatedly, in which case Caffeine may return a previously loaded > value. For instance, the AuthCache may hand out permissions even though the > reload operation is failing, see CASSANDRA-15041. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15153) Ensure Caffeine cache does not return stale entries
[ https://issues.apache.org/jira/browse/CASSANDRA-15153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17416712#comment-17416712 ] Aleksei Zotov commented on CASSANDRA-15153: --- Great! Thanks [~brandon.williams]! And thanks to [~eperott] for spotting the problem and coming up with the unit test! > Ensure Caffeine cache does not return stale entries > --- > > Key: CASSANDRA-15153 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15153 > Project: Cassandra > Issue Type: Bug > Components: Feature/Authorization >Reporter: Per Otterström >Assignee: Aleksei Zotov >Priority: Normal > Labels: security > Fix For: 4.0.2, 4.1 > > > Version 2.3.5 of the Caffeine cache that we're using in various places can > hand out stale entries in some cases. This seem to happen when an update > fails repeatedly, in which case Caffeine may return a previously loaded > value. For instance, the AuthCache may hand out permissions even though the > reload operation is failing, see CASSANDRA-15041. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15153) Ensure Caffeine cache does not return stale entries
[ https://issues.apache.org/jira/browse/CASSANDRA-15153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17416609#comment-17416609 ] Aleksei Zotov commented on CASSANDRA-15153: --- [~brandon.williams] [~mck] Sorry for bugging you, I'm just wondering whether there are any concerns on getting this merged. If yes, please, let me know, so I can do the necessary changes on the weekend. > Ensure Caffeine cache does not return stale entries > --- > > Key: CASSANDRA-15153 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15153 > Project: Cassandra > Issue Type: Bug > Components: Feature/Authorization >Reporter: Per Otterström >Assignee: Aleksei Zotov >Priority: Normal > Labels: security > Fix For: 4.0.x, 4.x > > > Version 2.3.5 of the Caffeine cache that we're using in various places can > hand out stale entries in some cases. This seem to happen when an update > fails repeatedly, in which case Caffeine may return a previously loaded > value. For instance, the AuthCache may hand out permissions even though the > reload operation is failing, see CASSANDRA-15041. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15153) Ensure Caffeine cache does not return stale entries
[ https://issues.apache.org/jira/browse/CASSANDRA-15153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413782#comment-17413782 ] Michael Semb Wever commented on CASSANDRA-15153: All the test results look good [~azotcsit]. > Ensure Caffeine cache does not return stale entries > --- > > Key: CASSANDRA-15153 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15153 > Project: Cassandra > Issue Type: Bug > Components: Feature/Authorization >Reporter: Per Otterström >Assignee: Aleksei Zotov >Priority: Normal > Labels: security > > Version 2.3.5 of the Caffeine cache that we're using in various places can > hand out stale entries in some cases. This seem to happen when an update > fails repeatedly, in which case Caffeine may return a previously loaded > value. For instance, the AuthCache may hand out permissions even though the > reload operation is failing, see CASSANDRA-15041. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15153) Ensure Caffeine cache does not return stale entries
[ https://issues.apache.org/jira/browse/CASSANDRA-15153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413670#comment-17413670 ] Aleksei Zotov commented on CASSANDRA-15153: --- Thanks [~mck]! There are a few failures for _trunk_, but they do not seem to be related to this particular change. > Ensure Caffeine cache does not return stale entries > --- > > Key: CASSANDRA-15153 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15153 > Project: Cassandra > Issue Type: Bug > Components: Feature/Authorization >Reporter: Per Otterström >Assignee: Aleksei Zotov >Priority: Normal > Labels: security > > Version 2.3.5 of the Caffeine cache that we're using in various places can > hand out stale entries in some cases. This seem to happen when an update > fails repeatedly, in which case Caffeine may return a previously loaded > value. For instance, the AuthCache may hand out permissions even though the > reload operation is failing, see CASSANDRA-15041. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15153) Ensure Caffeine cache does not return stale entries
[ https://issues.apache.org/jira/browse/CASSANDRA-15153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413603#comment-17413603 ] Michael Semb Wever commented on CASSANDRA-15153: CI: - trunk [!https://ci-cassandra.apache.org/job/Cassandra-devbranch//badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch//] - 4.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/1110/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1110/] - 3.11 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-test/793/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-test/793] > Ensure Caffeine cache does not return stale entries > --- > > Key: CASSANDRA-15153 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15153 > Project: Cassandra > Issue Type: Bug > Components: Feature/Authorization >Reporter: Per Otterström >Assignee: Aleksei Zotov >Priority: Normal > Labels: security > > Version 2.3.5 of the Caffeine cache that we're using in various places can > hand out stale entries in some cases. This seem to happen when an update > fails repeatedly, in which case Caffeine may return a previously loaded > value. For instance, the AuthCache may hand out permissions even though the > reload operation is failing, see CASSANDRA-15041. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15153) Ensure Caffeine cache does not return stale entries
[
https://issues.apache.org/jira/browse/CASSANDRA-15153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413598#comment-17413598
]
Aleksei Zotov commented on CASSANDRA-15153:
---
[~mck] [~brandon.williams]
Thanks for the feedback! I made the changes and here is the summary:
||Branch||Comment||Changes||Source Code||
|3.0|It turned out that 3.0 does not use Caffeine. No changes are
required.|No|N/A |
|3.11|{{AuthCache}} uses {{com.google.common.cache.CacheBuilder}} instead
{{com.github.benmanes.caffeine.cache.Caffeine}}. I ported the corresponding
test only and it passes. |Added a unit test|
https://github.com/alex-ninja/cassandra/tree/cassandra-15153-3.11_caffeine|
| 4.0| Using 2.5.6 version fixes the issue. The corresponding test
passes.|Added a unit test and updated _Caffeine_ version to 2.5.6|
https://github.com/alex-ninja/cassandra/tree/cassandra-15153-4.0_caffeine|
| trunk|It is impossible to use 3.0.3 version because it is not compatible with
Java 8 ([release
notes|https://github.com/ben-manes/caffeine/releases/tag/v3.0.0]). Therefore,
2.9.2 is used. |Added a unit test and updated _Caffeine_ version to 2.9.2|
https://github.com/alex-ninja/cassandra/tree/cassandra-15153-trunk_caffeine|
Could you please review and (if there are no remarks) start the CI.
PS:
If you think that it makes sense to keep versions aligned and stick to 2.5.6 in
both 4.0 and trunk, I'm good with that (the patches are interchangeable). My
personal attitude it to stick to the newer version for trunk because it may
contain bug fixes for issues we have not yet discovered.
> Ensure Caffeine cache does not return stale entries
> ---
>
> Key: CASSANDRA-15153
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15153
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/Authorization
>Reporter: Per Otterström
>Assignee: Aleksei Zotov
>Priority: Normal
> Labels: security
>
> Version 2.3.5 of the Caffeine cache that we're using in various places can
> hand out stale entries in some cases. This seem to happen when an update
> fails repeatedly, in which case Caffeine may return a previously loaded
> value. For instance, the AuthCache may hand out permissions even though the
> reload operation is failing, see CASSANDRA-15041.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
