[jira] [Commented] (CASSANDRA-15222) BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
[ https://issues.apache.org/jira/browse/CASSANDRA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901188#comment-16901188 ] Benedict commented on CASSANDRA-15222: -- Ah, [~dotbg], I am really sorry. I have just realised I already made the intended change, as part of CASSANDRA-15066. If you take a look at the difference with 3.x, it will become apparent what I was intending with this ticket. I am sorry for wasting your time, and not looking more closely after you posted the first patch. I hope you engage on another ticket - I promise to look more carefully next time! > BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy() > - > > Key: CASSANDRA-15222 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15222 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction, Local/SSTable, Messaging/Internode >Reporter: Benedict >Assignee: Boris Tsirkin >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15222) BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
[ https://issues.apache.org/jira/browse/CASSANDRA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899467#comment-16899467 ] Boris Tsirkin commented on CASSANDRA-15222: --- Thanks [~benedict], I have redone my Merge Request. > BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy() > - > > Key: CASSANDRA-15222 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15222 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction, Local/SSTable, Messaging/Internode >Reporter: Benedict >Assignee: Boris Tsirkin >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15222) BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
[
https://issues.apache.org/jira/browse/CASSANDRA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899414#comment-16899414
]
Benedict commented on CASSANDRA-15222:
--
There shouldn't be any need to touch {{Unsafe}} - just coping {{public void
copy(ByteBuffer src, int srcPosition, byte[] trg, int trgPosition, int
length)}} but flipping the signature to {{public void copy(byte[] src, int
srcPosition, ByteBuffer trg, int trgPosition, int length)}} should be enough.
This only invokes non-{{Unsafe}} methods.
> BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
> -
>
> Key: CASSANDRA-15222
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15222
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction, Local/SSTable, Messaging/Internode
>Reporter: Benedict
>Assignee: Boris Tsirkin
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15222) BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
[ https://issues.apache.org/jira/browse/CASSANDRA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899210#comment-16899210 ] Boris Tsirkin commented on CASSANDRA-15222: --- Well, I can do that as well. I may, however, need some advice on the unsafe. Unfortunately, I have not done this "magic" yet :) > BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy() > - > > Key: CASSANDRA-15222 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15222 > Project: Cassandra > Issue Type: Improvement > Components: Local/Compaction, Local/SSTable, Messaging/Internode >Reporter: Benedict >Assignee: Boris Tsirkin >Priority: Normal > Labels: pull-request-available > Fix For: 4.0.x > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15222) BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
[
https://issues.apache.org/jira/browse/CASSANDRA-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898975#comment-16898975
]
Benedict commented on CASSANDRA-15222:
--
Thanks [~dotbg].
I was hoping, when filing this, that we would introduce extra method signatures
to {{FastByteOperations}} so that we could avoid allocating any new objects.
Would you be willing to take another look at the ticket, with this in mind?
> BufferedDataOutputStreamPlus.write() should use FastByteOperations.copy()
> -
>
> Key: CASSANDRA-15222
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15222
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction, Local/SSTable, Messaging/Internode
>Reporter: Benedict
>Assignee: Boris Tsirkin
>Priority: Normal
> Labels: pull-request-available
> Fix For: 4.0.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
