[jira] [Commented] (CASSANDRA-15290) Avoid token cache invalidation for removing proxy node
[ https://issues.apache.org/jira/browse/CASSANDRA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421362#comment-17421362 ] Brandon Williams commented on CASSANDRA-15290: -- Thanks, I created CASSANDRA-17007 to tackle this. > Avoid token cache invalidation for removing proxy node > -- > > Key: CASSANDRA-15290 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15290 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Membership >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Low > Fix For: 4.1 > > > As proxy node doesn't own token, adding/removing doesn't change token > ownership and no need to invalidate the token cache. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15290) Avoid token cache invalidation for removing proxy node
[
https://issues.apache.org/jira/browse/CASSANDRA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421184#comment-17421184
]
Berenguer Blasi commented on CASSANDRA-15290:
-
Hi guys, I noticed a spike in trunk CI failures and if my bisect kung-fu was
good enough it is flaky at {{b1e77ba}} but not on the previous one {{bd406c7}}.
It can be repro'ed locally by running the test a few times.
> Avoid token cache invalidation for removing proxy node
> --
>
> Key: CASSANDRA-15290
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15290
> Project: Cassandra
> Issue Type: Improvement
> Components: Cluster/Membership
>Reporter: Jay Zhuang
>Assignee: Jay Zhuang
>Priority: Low
> Fix For: 4.1
>
>
> As proxy node doesn't own token, adding/removing doesn't change token
> ownership and no need to invalidate the token cache.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15290) Avoid token cache invalidation for removing proxy node
[ https://issues.apache.org/jira/browse/CASSANDRA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17413604#comment-17413604 ] Aleksei Zotov commented on CASSANDRA-15290: --- I guess performance impact of the unnecessary token cache invalidation is negligible, so we do not need to backport it as a perf bug fix to 4.0 and older versions. Please, correct me if I'm wrong. +1 (non binding) > Avoid token cache invalidation for removing proxy node > -- > > Key: CASSANDRA-15290 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15290 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Membership >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Low > Fix For: 4.x > > > As proxy node doesn't own token, adding/removing doesn't change token > ownership and no need to invalidate the token cache. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15290) Avoid token cache invalidation for removing proxy node
[ https://issues.apache.org/jira/browse/CASSANDRA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408206#comment-17408206 ] Brandon Williams commented on CASSANDRA-15290: -- I don't see any related failures, +1 from me. > Avoid token cache invalidation for removing proxy node > -- > > Key: CASSANDRA-15290 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15290 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Membership >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Low > Fix For: 4.x > > > As proxy node doesn't own token, adding/removing doesn't change token > ownership and no need to invalidate the token cache. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15290) Avoid token cache invalidation for removing proxy node
[ https://issues.apache.org/jira/browse/CASSANDRA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17407522#comment-17407522 ] Brandon Williams commented on CASSANDRA-15290: -- ||Heading 1||Heading 2|| |[rebased|https://github.com/driftx/cassandra/tree/CASSANDRA-15290]|[circle|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-15290], [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/1087/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1087/pipeline]| > Avoid token cache invalidation for removing proxy node > -- > > Key: CASSANDRA-15290 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15290 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Membership >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Low > Fix For: 4.x > > > As proxy node doesn't own token, adding/removing doesn't change token > ownership and no need to invalidate the token cache. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15290) Avoid token cache invalidation for removing proxy node
[ https://issues.apache.org/jira/browse/CASSANDRA-15290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915145#comment-16915145 ] Jay Zhuang commented on CASSANDRA-15290: | Branch | CircleCI | | [15290-trunk|https://github.com/Instagram/cassandra/tree/15290-trunk] | https://circleci.com/workflow-run/068aa546-39cd-4999-b959-4bd5d180c5d1 | > Avoid token cache invalidation for removing proxy node > -- > > Key: CASSANDRA-15290 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15290 > Project: Cassandra > Issue Type: Improvement > Components: Cluster/Membership >Reporter: Jay Zhuang >Assignee: Jay Zhuang >Priority: Low > Fix For: 4.0.x > > > As proxy node doesn't own token, adding/removing doesn't change token > ownership and no need to invalidate the token cache. -- This message was sent by Atlassian Jira (v8.3.2#803003) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
