[jira] [Commented] (CASSANDRA-15647) Missmatching dependencies between cassandra dist and cassandra-all pom
[
https://issues.apache.org/jira/browse/CASSANDRA-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063610#comment-17063610
]
Jon Meredith commented on CASSANDRA-15647:
--
Confirmed the dependencies change as expected with the commit. (Though I had to
add
{code}./apache-cassandra-4.0-alpha4-SNAPSHOT-parent.pom{code}
to the parent element to get it to work - maybe a .m2 settings issue on my
end).
Before
{code}
$ mvn dependency:tree -f build/apache-cassandra*-SNAPSHOT.pom -Dverbose
-Dincludes=net.java.dev.jna
[INFO] Scanning for projects...
[INFO]
[INFO] -< org.apache.cassandra:cassandra-all >-
[INFO] Building Apache Cassandra 4.0-alpha4-SNAPSHOT
[INFO] [ jar ]-
[WARNING] The POM for org.perfkit.sjk.parsers:sjk-jfr5:jar:0.5 is invalid,
transitive dependencies (if any) will not be available, enable debug logging
for more details
[WARNING] The POM for org.perfkit.sjk.parsers:sjk-jfr6:jar:0.7 is invalid,
transitive dependencies (if any) will not be available, enable debug logging
for more details
[WARNING] The POM for org.perfkit.sjk.parsers:sjk-nps:jar:0.5 is invalid,
transitive dependencies (if any) will not be available, enable debug logging
for more details
[INFO]
[INFO] — maven-dependency-plugin:3.1.1:tree (default-cli) @ cassandra-all —
[INFO] Verbose not supported since maven-dependency-plugin 3.0
[INFO] org.apache.cassandra:cassandra-all:jar:4.0-alpha4-SNAPSHOT
[INFO] +- net.java.dev.jna:jna:jar:4.2.2:compile
[INFO] - net.openhft:chronicle-threads:jar:1.16.0:compile
[INFO] - net.openhft:affinity:jar:3.1.7:compile
[INFO] - net.java.dev.jna:jna-platform:jar:4.4.0:compile
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 1.070 s
[INFO] Finished at: 2020-03-20T14:15:14-06:00
[INFO]
{code}
After
{code}
$ mvn dependency:tree -f build/apache-cassandra*-SNAPSHOT.pom -Dverbose
-Dincludes=net.java.dev.jna
[INFO] Scanning for projects...
[INFO]
[INFO] -< org.apache.cassandra:cassandra-all >-
[INFO] Building Apache Cassandra 4.0-alpha4-SNAPSHOT
[INFO] [ jar ]-
[WARNING] The POM for org.perfkit.sjk.parsers:sjk-jfr5:jar:0.5 is invalid,
transitive dependencies (if any) will not be available, enable debug logging
for more details
[WARNING] The POM for org.perfkit.sjk.parsers:sjk-jfr6:jar:0.7 is invalid,
transitive dependencies (if any) will not be available, enable debug logging
for more details
[WARNING] The POM for org.perfkit.sjk.parsers:sjk-nps:jar:0.5 is invalid,
transitive dependencies (if any) will not be available, enable debug logging
for more details
[INFO]
[INFO] — maven-dependency-plugin:3.1.1:tree (default-cli) @ cassandra-all —
[INFO] Verbose not supported since maven-dependency-plugin 3.0
[INFO] org.apache.cassandra:cassandra-all:jar:4.0-alpha4-SNAPSHOT
[INFO] - net.java.dev.jna:jna:jar:4.2.2:compile
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 1.080 s
[INFO] Finished at: 2020-03-20T14:16:26-06:00
[INFO]
{code}
+1 from me (though I cannot merge).
> Missmatching dependencies between cassandra dist and cassandra-all pom
> --
>
> Key: CASSANDRA-15647
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15647
> Project: Cassandra
> Issue Type: Bug
> Components: Build, Dependencies
>Reporter: Marvin Froeder
>Assignee: Ryan Svihla
>Priority: Normal
> Fix For: 4.0-beta
>
>
> I noticed that the cassandra distribution (tar.gz) dependencies doesn't match
> the dependency list for the cassandra-all that is available at maven central.
> Cassandra distribution only includes jna 4.2.2.
> But, the maven dependency also include jna-platform 4.4.0
> Breakdown of relevant maven dependencies:
> ```
> [INFO] +- org.apache.cassandra:cassandra-all:jar:4.0-alpha3:provided
> [INFO] | +- net.java.dev.jna:jna:jar:4.2.2:provided
> [INFO] | +- net.openhft:chronicle-threads:jar:1.16.0:provided
> [INFO] | | \- net.openhft:affinity:jar:3.1.7:provided
> [INFO] | | \- net.java.dev.jna:jna-platform:jar:4.4.0:provided
> ```
> As you can see, jna is a direct dependency and jna-platform is a transitive
> dependency from chronicle-threads.
> I expected thi
[jira] [Commented] (CASSANDRA-15647) Missmatching dependencies between cassandra dist and cassandra-all pom
[ https://issues.apache.org/jira/browse/CASSANDRA-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063603#comment-17063603 ] Jon Meredith commented on CASSANDRA-15647: -- You're correct, it was *not* intentional. The change was only supposed to prevent the native libraries being called under in-jvm dtests as they prevented Instances from being garbage collected. We should reapply the patch https://github.com/apache/cassandra/pull/240/commits/34d5719ac33826e90e952d92e5204247c611e08f > Missmatching dependencies between cassandra dist and cassandra-all pom > -- > > Key: CASSANDRA-15647 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15647 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies >Reporter: Marvin Froeder >Assignee: Ryan Svihla >Priority: Normal > Fix For: 4.0-beta > > > I noticed that the cassandra distribution (tar.gz) dependencies doesn't match > the dependency list for the cassandra-all that is available at maven central. > Cassandra distribution only includes jna 4.2.2. > But, the maven dependency also include jna-platform 4.4.0 > Breakdown of relevant maven dependencies: > ``` > [INFO] +- org.apache.cassandra:cassandra-all:jar:4.0-alpha3:provided > [INFO] | +- net.java.dev.jna:jna:jar:4.2.2:provided > [INFO] | +- net.openhft:chronicle-threads:jar:1.16.0:provided > [INFO] | | \- net.openhft:affinity:jar:3.1.7:provided > [INFO] | | \- net.java.dev.jna:jna-platform:jar:4.4.0:provided > ``` > As you can see, jna is a direct dependency and jna-platform is a transitive > dependency from chronicle-threads. > I expected this issue to had been fixed by > https://github.com/apache/cassandra/pull/240/, but this change seem to have > being reverted, as no longer in trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15647) Missmatching dependencies between cassandra dist and cassandra-all pom
[ https://issues.apache.org/jira/browse/CASSANDRA-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063340#comment-17063340 ] Benedict Elliott Smith commented on CASSANDRA-15647: According to the commit "Disable native library loading until it can be reinstated (tracked in CASSANDRA-15170)." This work was done by [~jmeredithco], and while I don't believe this was intentional it might have been. > Missmatching dependencies between cassandra dist and cassandra-all pom > -- > > Key: CASSANDRA-15647 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15647 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies >Reporter: Marvin Froeder >Assignee: Ryan Svihla >Priority: Normal > Fix For: 4.0-beta > > > I noticed that the cassandra distribution (tar.gz) dependencies doesn't match > the dependency list for the cassandra-all that is available at maven central. > Cassandra distribution only includes jna 4.2.2. > But, the maven dependency also include jna-platform 4.4.0 > Breakdown of relevant maven dependencies: > ``` > [INFO] +- org.apache.cassandra:cassandra-all:jar:4.0-alpha3:provided > [INFO] | +- net.java.dev.jna:jna:jar:4.2.2:provided > [INFO] | +- net.openhft:chronicle-threads:jar:1.16.0:provided > [INFO] | | \- net.openhft:affinity:jar:3.1.7:provided > [INFO] | | \- net.java.dev.jna:jna-platform:jar:4.4.0:provided > ``` > As you can see, jna is a direct dependency and jna-platform is a transitive > dependency from chronicle-threads. > I expected this issue to had been fixed by > https://github.com/apache/cassandra/pull/240/, but this change seem to have > being reverted, as no longer in trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15647) Missmatching dependencies between cassandra dist and cassandra-all pom
[ https://issues.apache.org/jira/browse/CASSANDRA-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063338#comment-17063338 ] Ryan Svihla commented on CASSANDRA-15647: - [~benedict] I think the build.xml file got force pushed over in this commit [https://github.com/apache/cassandra/commit/7dc5b700b760382c15045e3301c7061f412da993|https://github.com/apache/cassandra/blob/7dc5b700b760382c15045e3301c7061f412da993/build.xml] removing the exclusion. Can you confirm dropping the JNA exclusion wasn't intentional? > Missmatching dependencies between cassandra dist and cassandra-all pom > -- > > Key: CASSANDRA-15647 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15647 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies >Reporter: Marvin Froeder >Assignee: Ryan Svihla >Priority: Normal > Fix For: 4.0-beta > > > I noticed that the cassandra distribution (tar.gz) dependencies doesn't match > the dependency list for the cassandra-all that is available at maven central. > Cassandra distribution only includes jna 4.2.2. > But, the maven dependency also include jna-platform 4.4.0 > Breakdown of relevant maven dependencies: > ``` > [INFO] +- org.apache.cassandra:cassandra-all:jar:4.0-alpha3:provided > [INFO] | +- net.java.dev.jna:jna:jar:4.2.2:provided > [INFO] | +- net.openhft:chronicle-threads:jar:1.16.0:provided > [INFO] | | \- net.openhft:affinity:jar:3.1.7:provided > [INFO] | | \- net.java.dev.jna:jna-platform:jar:4.4.0:provided > ``` > As you can see, jna is a direct dependency and jna-platform is a transitive > dependency from chronicle-threads. > I expected this issue to had been fixed by > https://github.com/apache/cassandra/pull/240/, but this change seem to have > being reverted, as no longer in trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15647) Missmatching dependencies between cassandra dist and cassandra-all pom
[ https://issues.apache.org/jira/browse/CASSANDRA-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061015#comment-17061015 ] Ryan Svihla commented on CASSANDRA-15647: - digging into the history I think this just happened as part of a force push from the 3.11 branch into trunk (but I could be misreading the github ui), [https://github.com/apache/cassandra/commit/7dc5b700b760382c15045e3301c7061f412da993 |https://github.com/apache/cassandra/commit/7dc5b700b760382c15045e3301c7061f412da993]It does not look intentional that the JNA exclusion was left off or related to the issue that wrote the build.xml. I've linked the equivalent [PR|https://github.com/apache/cassandra/pull/476] for the trunk version of the build file in case it was accidental as I suspect. > Missmatching dependencies between cassandra dist and cassandra-all pom > -- > > Key: CASSANDRA-15647 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15647 > Project: Cassandra > Issue Type: Bug > Components: Build, Dependencies >Reporter: Marvin Froeder >Assignee: Ryan Svihla >Priority: Normal > > I noticed that the cassandra distribution (tar.gz) dependencies doesn't match > the dependency list for the cassandra-all that is available at maven central. > Cassandra distribution only includes jna 4.2.2. > But, the maven dependency also include jna-platform 4.4.0 > Breakdown of relevant maven dependencies: > ``` > [INFO] +- org.apache.cassandra:cassandra-all:jar:4.0-alpha3:provided > [INFO] | +- net.java.dev.jna:jna:jar:4.2.2:provided > [INFO] | +- net.openhft:chronicle-threads:jar:1.16.0:provided > [INFO] | | \- net.openhft:affinity:jar:3.1.7:provided > [INFO] | | \- net.java.dev.jna:jna-platform:jar:4.4.0:provided > ``` > As you can see, jna is a direct dependency and jna-platform is a transitive > dependency from chronicle-threads. > I expected this issue to had been fixed by > https://github.com/apache/cassandra/pull/240/, but this change seem to have > being reverted, as no longer in trunk. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
