[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069365#comment-17069365 ] Michael Semb Wever commented on CASSANDRA-15651: Committed as 571b2ed35655e6bc13e0 > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.17, 3.0.21, 3.11.7, 4.0-alpha > > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17069055#comment-17069055 ] Michael Semb Wever commented on CASSANDRA-15651: bq. https://github.com/apache/cassandra-builds/commit/dcf8bef5a0f272ed95a8d2851e532cd26adb6b8e#diff-91876f5f158ec50dab9a70cc06c06922R51. This is actually there, at the end of the command. I didn't see jvm-dtest having issue, was just the new ones. Thanks. Fixed. > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.17, 3.0.21, 3.11.7, 4.0-alpha > > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068972#comment-17068972 ] David Capwell commented on CASSANDRA-15651: --- Doh! I missed that during review =( https://github.com/apache/cassandra-builds/commit/dcf8bef5a0f272ed95a8d2851e532cd26adb6b8e#diff-91876f5f158ec50dab9a70cc06c06922R51. This is actually there, at the end of the command. I didn't see jvm-dtest having issue, was just the new ones. I retested burn and long (I felt they were quick but I didn't validate why last time...) and confirm they are picking up the tests now. +1 but should fix the jvm-dtest double arg comment. > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.17, 3.0.21, 3.11.7, 4.0-alpha > > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068733#comment-17068733 ] Michael Semb Wever commented on CASSANDRA-15651: Fix is [here|https://github.com/apache/cassandra-builds/commit/dcf8bef5a0f272ed95a8d2851e532cd26adb6b8e], if you have a chance to review again. (It is what you found, that tests were just not running.) > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.17, 3.0.21, 3.11.7, 4.0-alpha > > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17068602#comment-17068602 ] Michael Semb Wever commented on CASSANDRA-15651: Some discussion on this breakage in slack [here|https://the-asf.slack.com/archives/CK23JSY2K/p1585248163058400]. > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.17, 3.0.21, 3.11.7, 4.0-alpha > > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067636#comment-17067636 ] Michael Semb Wever commented on CASSANDRA-15651: Reverted the cassandra-builds, so get ci-cassandra.a.o working again. > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.17, 3.0.21, 3.11.7, 4.0-alpha > > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066491#comment-17066491 ] Michael Semb Wever commented on CASSANDRA-15651: Thanks [~dcapwell]. I did the testing. Committed as https://github.com/apache/cassandra/commit/fa403bb7210de650d6068cee1cb7e4e26ba777bb and https://github.com/apache/cassandra-builds/commit/399a8a0c87489aea236b240ca0edaf781c1c4966 > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.17, 3.0.21, 3.11.7, 4.0-alpha > > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066094#comment-17066094 ] Michael Semb Wever commented on CASSANDRA-15651: Whoops. cdc is 3.11 onwards. The cassandra [patch|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/cassandra-3.11_15651] is now from cassandra-3.11 Both bugs are fixed now. And the function for parsing the timeout property to argument. > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.x > > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065306#comment-17065306 ] David Capwell commented on CASSANDRA-15651: --- Said it on slack; once you fix the 2 bugs I am +1. > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.x > > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064098#comment-17064098 ] David Capwell commented on CASSANDRA-15651: --- +1 to defering to a targeted jira. Thanks for the comment about Cassandra patch, didn't check that yet. Harry doesn't explicitly. Harry is random generation + validation of response, so I "feel" the caller of Harry should solve this and not Harry explicitly > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.x > > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[
https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064063#comment-17064063
]
Michael Semb Wever commented on CASSANDRA-15651:
Thanks for the feedback.
Totally agree that duplicating tests for compression and cdc, and the way they
are duplicated, is silly. Personally I would just begin with enabling both in
the default test run. I don't know if Harry deals with this in any way,
CASSANDRA-15348.
The {{testclasslist-cdc}} target exists in the cassandra patch. otherwise here
i aimed to make as little change as possible to the cassandra codebase. i agree
that the copy-paste definitions for compression and cdc can be done better, but
don't want that done on the release branches. i think it's better tackled in a
ticket that deals with cleaning up the build script, eg rewriting it to gradle
(which would only happen in trunk).
> Jenkins tests to use testclasslist where possible (like CircleCI)
> -
>
> Key: CASSANDRA-15651
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15651
> Project: Cassandra
> Issue Type: Task
> Components: Build, Test/unit
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x
>
>
> Following up on CASSANDRA-15639
> make all the jenkins test jobs run in the same manner.
> This standards the approach across test jobs and to CircleCI, and will make
> it easier to parallelise test runs later on.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17064025#comment-17064025 ] David Capwell commented on CASSANDRA-15651: --- Overall +1 to the idea and the code looks mostly fine; I plan to test the script Monday but early feedback is below * https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15651--tests-use-testclasslist#diff-91876f5f158ec50dab9a70cc06c06922R42 better to make this a function to avoid copy/paste. * test, and test-compression are 98% the same, the only differences are * *-Dcassandra.test.compression=true * * cassandra.compressed.yaml which appends commit log compression to the config file (my trunk is missing commitlog_compression.yaml and instead has test/conf/commitlog_compression_LZ4.yaml and test/conf/commitlog_compression_Zstd.yaml, walking ant I am not sure how that works (my guess is concat doesn't fail so compression doesn't compress) * testclasslist-cdc doesn't exist, nor do I see any build steps for cdc other than testlist-cdc and test-cdc. Looking at test-cdc it looks like another copy/paste build step where the main difference is cassandra.cdc.yaml is used instead (which is generated by normal config concat with test/conf/cdc.yaml). * utests_long isn't concurrent in circle ci... (this patch is for Jenkins so totally fine if circle ci isn't). * burn isn't run in circle ci (having multiple CIs is fun isn't it?) The main thing I don't like about this is that compression and cdc are one-offs (true today, this patch doesn't change this), but really they are trying to be a a matrix build in disguise. I would love to get rid of them and actually embrace running the tests under different configurations as a thing. If we think about it, we run the unit tests with compression and cdc but not the jvm dtests? Would love for this to be solved, but will not hold this JIRA ransom to fix it =). > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x > > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15651) Jenkins tests to use testclasslist where possible (like CircleCI)
[ https://issues.apache.org/jira/browse/CASSANDRA-15651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17063871#comment-17063871 ] Michael Semb Wever commented on CASSANDRA-15651: cassandra-builds patch [here|https://github.com/apache/cassandra-builds/compare/master...thelastpickle:mck/15651--tests-use-testclasslist] cassandra-2.2 patch [here|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/cassandra-2.2_15651] (cassandra patch must be committed first) > Jenkins tests to use testclasslist where possible (like CircleCI) > - > > Key: CASSANDRA-15651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15651 > Project: Cassandra > Issue Type: Task > Components: Build, Test/unit >Reporter: Michael Semb Wever >Priority: Normal > > Following up on CASSANDRA-15639 > make all the jenkins test jobs run in the same manner. > This standards the approach across test jobs and to CircleCI, and will make > it easier to parallelise test runs later on. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
