[jira] [Commented] (CASSANDRA-15893) JAVA 11: test_short_read - consistency_test.TestConsistency
[ https://issues.apache.org/jira/browse/CASSANDRA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154590#comment-17154590 ] Ekaterina Dimitrova commented on CASSANDRA-15893: - [~brandon.williams] do you mind to commit if you don't see any issue, please? > JAVA 11: test_short_read - consistency_test.TestConsistency > --- > > Key: CASSANDRA-15893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15893 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-beta > > Attachments: test_short_read.txt > > > JAVA 11: test_short_read - consistency_test.TestConsistency > Failing locally and in CircleCI: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/11202c7e-6c94-4d4e-bbbf-9e2fa9791ad0/jobs/1337 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15893) JAVA 11: test_short_read - consistency_test.TestConsistency
[ https://issues.apache.org/jira/browse/CASSANDRA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154572#comment-17154572 ] Berenguer Blasi commented on CASSANDRA-15893: - Kill it then. It will come up eventually if it has to and git history will be there. +1 from me. > JAVA 11: test_short_read - consistency_test.TestConsistency > --- > > Key: CASSANDRA-15893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15893 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-beta > > Attachments: test_short_read.txt > > > JAVA 11: test_short_read - consistency_test.TestConsistency > Failing locally and in CircleCI: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/11202c7e-6c94-4d4e-bbbf-9e2fa9791ad0/jobs/1337 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15893) JAVA 11: test_short_read - consistency_test.TestConsistency
[ https://issues.apache.org/jira/browse/CASSANDRA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154539#comment-17154539 ] Ekaterina Dimitrova commented on CASSANDRA-15893: - [~Bereng], I can make it 5 but I think it is a left-over from 5 years ago. The thing is the author wasn't able to reproduce it and she left the loop to ensure the community can faster see any regressions in case this needs additional fix. 5 years later I don't find neither a ticket, nor an evidence in any CI that the issue reappeared so to me it looks like just an unneeded leftover. Let me know if you still want the 5 times loop. It doesn't hurt to have It but I don't see a reason anymore, honestly. > JAVA 11: test_short_read - consistency_test.TestConsistency > --- > > Key: CASSANDRA-15893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15893 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-beta > > Attachments: test_short_read.txt > > > JAVA 11: test_short_read - consistency_test.TestConsistency > Failing locally and in CircleCI: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/11202c7e-6c94-4d4e-bbbf-9e2fa9791ad0/jobs/1337 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15893) JAVA 11: test_short_read - consistency_test.TestConsistency
[ https://issues.apache.org/jira/browse/CASSANDRA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154310#comment-17154310 ] Berenguer Blasi commented on CASSANDRA-15893: - [~e.dimitrova] I went over the original ticket and it seems there is already a consistency test checking for the NULL. Despite that the original authors considered looping a good idea still to surface any races hiding in there. Instead of removing the looping completely could we just reduce it to 5 loops i.e.? wdyt? > JAVA 11: test_short_read - consistency_test.TestConsistency > --- > > Key: CASSANDRA-15893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15893 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-beta > > Attachments: test_short_read.txt > > > JAVA 11: test_short_read - consistency_test.TestConsistency > Failing locally and in CircleCI: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/11202c7e-6c94-4d4e-bbbf-9e2fa9791ad0/jobs/1337 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15893) JAVA 11: test_short_read - consistency_test.TestConsistency
[ https://issues.apache.org/jira/browse/CASSANDRA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154098#comment-17154098 ] Ekaterina Dimitrova commented on CASSANDRA-15893: - This test was put in a loop to be run 10 times. This was done in order to be able to catch an issue which was hard to be reproduced. The loop had the goal to help us to ensure that the applied patch is enough to fix the problem. This was done 5 years ago as part of CASSANDRA-9460 . I put some additional logging and I observed that the test fails on the 9th repetition as the test run duration becomes more than the time threshold of 900s. Jenkins shows the test is stable so I removed the loop. Just looped it 10 times locally successfully. I believe this is enough to solve the problem. Attached log of the local run [Patch|https://github.com/ekaterinadimitrova2/cassandra-dtest/commit/3af693ac8669002600dac872390d6e6ac3e80ffd] [~Bereng], [~blerer], can anyone of you review the solution, please? Thanks in advance! > JAVA 11: test_short_read - consistency_test.TestConsistency > --- > > Key: CASSANDRA-15893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15893 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc > > > JAVA 11: test_short_read - consistency_test.TestConsistency > Failing locally and in CircleCI: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/11202c7e-6c94-4d4e-bbbf-9e2fa9791ad0/jobs/1337 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15893) JAVA 11: test_short_read - consistency_test.TestConsistency
[ https://issues.apache.org/jira/browse/CASSANDRA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152367#comment-17152367 ] Ekaterina Dimitrova commented on CASSANDRA-15893: - Thank you for your time and work [~Bereng], I know how frustrating this could be but it happens sometimes. I am already looking into it, I am moving it back to work in progress. Thank you one more time! > JAVA 11: test_short_read - consistency_test.TestConsistency > --- > > Key: CASSANDRA-15893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15893 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc > > > JAVA 11: test_short_read - consistency_test.TestConsistency > Failing locally and in CircleCI: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/11202c7e-6c94-4d4e-bbbf-9e2fa9791ad0/jobs/1337 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15893) JAVA 11: test_short_read - consistency_test.TestConsistency
[ https://issues.apache.org/jira/browse/CASSANDRA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151855#comment-17151855 ] Berenguer Blasi commented on CASSANDRA-15893: - Thx for the feedback [~e.dimitrova] . I am assigning it to you bc I can't repro locally :( > JAVA 11: test_short_read - consistency_test.TestConsistency > --- > > Key: CASSANDRA-15893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15893 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.0-rc > > > JAVA 11: test_short_read - consistency_test.TestConsistency > Failing locally and in CircleCI: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/11202c7e-6c94-4d4e-bbbf-9e2fa9791ad0/jobs/1337 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15893) JAVA 11: test_short_read - consistency_test.TestConsistency
[ https://issues.apache.org/jira/browse/CASSANDRA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151446#comment-17151446 ] Ekaterina Dimitrova commented on CASSANDRA-15893: - Locally I failed it also in java 8. Also, I checked it with older trunk versions from April and it was failing. So I wouldn't close it. The thing is that it was not failing up until recently neither in Jenkins, nor in CircleCI. Now It fails in CircleCI. So whatever is the issue, it got bigger. I will try to look at it more next week > JAVA 11: test_short_read - consistency_test.TestConsistency > --- > > Key: CASSANDRA-15893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15893 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc > > > JAVA 11: test_short_read - consistency_test.TestConsistency > Failing locally and in CircleCI: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/11202c7e-6c94-4d4e-bbbf-9e2fa9791ad0/jobs/1337 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15893) JAVA 11: test_short_read - consistency_test.TestConsistency
[ https://issues.apache.org/jira/browse/CASSANDRA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147659#comment-17147659 ] Berenguer Blasi commented on CASSANDRA-15893: - Cannot repro, suggesting to close until it can be repro'ed > JAVA 11: test_short_read - consistency_test.TestConsistency > --- > > Key: CASSANDRA-15893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15893 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest >Reporter: Ekaterina Dimitrova >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc > > > JAVA 11: test_short_read - consistency_test.TestConsistency > Failing locally and in CircleCI: > https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/11202c7e-6c94-4d4e-bbbf-9e2fa9791ad0/jobs/1337 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15893) JAVA 11: test_short_read - consistency_test.TestConsistency
[
https://issues.apache.org/jira/browse/CASSANDRA-15893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146125#comment-17146125
]
Berenguer Blasi commented on CASSANDRA-15893:
-
Passes locally for me as well as the other ones you raised. Under j11:
{noformat}
pytest --cassandra-dir=/tmp/test
consistency_test.py::TestConsistency::test_short_read
===
test session starts
===
platform linux -- Python 3.6.9, pytest-3.6.4, py-1.8.1, pluggy-0.7.1
rootdir: /home/bereng/work/repos/bdpWS/dtests, inifile: pytest.ini
plugins: timeout-1.3.4, flaky-3.6.1
timeout: 900.0s
timeout method: signal
timeout func_only: False
collected 1 item
consistency_test.py .
[100%]
===Flaky Test Report===test_short_read passed 1 out of the required 1 times.
Success!===End Flaky Test
Report==
1 passed in 710.55 seconds
{noformat}
> JAVA 11: test_short_read - consistency_test.TestConsistency
> ---
>
> Key: CASSANDRA-15893
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15893
> Project: Cassandra
> Issue Type: Bug
>Reporter: Ekaterina Dimitrova
>Priority: Normal
>
> JAVA 11: test_short_read - consistency_test.TestConsistency
> Failing locally and in CircleCI:
> https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/222/workflows/11202c7e-6c94-4d4e-bbbf-9e2fa9791ad0/jobs/1337
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
