[jira] [Commented] (CASSANDRA-16151) Package tools/bin scripts as executable

2020-10-21 Thread Jira 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218270#comment-17218270
 ] 

Andres de la Peña commented on CASSANDRA-16151:
---

Great, thanks, nice patches.

Committed to {{cassandra-2.2}} as 
[72941b9ec14e64af9e64365027d542b4fff41d81|https://github.com/apache/cassandra/commit/72941b9ec14e64af9e64365027d542b4fff41d81]
 and merged up to 
[{{3.0}}|https://github.com/apache/cassandra/commit/d44dbd91c1752a71f4819be92fd75a52be9f0118],
 
[{{3.11}}|https://github.com/apache/cassandra/commit/a2f59be94388754e667f545b02798810056f9b1b]
 and 
[{{trunk}}|https://github.com/apache/cassandra/commit/095540d54a07d2c35bd9260e065fcf346ad36164].

> Package tools/bin scripts as executable
> ---
>
> Key: CASSANDRA-16151
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16151
> Project: Cassandra
>  Issue Type: Bug
>  Components: Packaging
>Reporter: Angelo Polo
>Assignee: Angelo Polo
>Priority: Normal
>  Labels: patch
> Fix For: 2.2.19, 3.0.23, 3.11.9, 4.0-beta3
>
> Attachments: 2.2-Package-tools-bin-scripts-as-executable.patch, 
> 3.0-Package-tools-bin-scripts-as-executable.patch, 
> 3.11-Package-tools-bin-scripts-as-executable.patch, 
> trunk-Package-tools-bin-scripts-as-executable.patch
>
>
> The tools/bin scripts aren't packaged as executable in the source 
> distributions, though in the repository the scripts have the right bits.
> This causes, on 3.11.8 for example, the tests in 
> org.apache.cassandra.cql3.EmptyValuesTest to fail:
> {{java.io.IOException: Cannot run program "tools/bin/sstabledump": error=13, 
> Permission denied}}
> {{[junit-timeout] junit.framework.AssertionFailedError: java.io.IOException}}
> {{[junit-timeout]         at 
> org.apache.cassandra.cql3.EmptyValuesTest.verify(EmptyValuesTest.java:85)}}
> {{[junit-timeout]         at 
> org.apache.cassandra.cql3.EmptyValuesTest.verifyJsonInsert(EmptyValuesTest.java:112)}}
> See attached patch of build.xml for the trunk and cassandra-3.11 branches.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16151) Package tools/bin scripts as executable

2020-10-21 Thread Angelo Polo (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218214#comment-17218214
 ] 

Angelo Polo commented on CASSANDRA-16151:
-

Patches for 2.2 and 3.0 attached!

> Package tools/bin scripts as executable
> ---
>
> Key: CASSANDRA-16151
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16151
> Project: Cassandra
>  Issue Type: Bug
>  Components: Packaging
>Reporter: Angelo Polo
>Assignee: Angelo Polo
>Priority: Normal
>  Labels: patch
> Fix For: 4.0-beta, 3.11.9
>
> Attachments: 2.2-Package-tools-bin-scripts-as-executable.patch, 
> 3.0-Package-tools-bin-scripts-as-executable.patch, 
> 3.11-Package-tools-bin-scripts-as-executable.patch, 
> trunk-Package-tools-bin-scripts-as-executable.patch
>
>
> The tools/bin scripts aren't packaged as executable in the source 
> distributions, though in the repository the scripts have the right bits.
> This causes, on 3.11.8 for example, the tests in 
> org.apache.cassandra.cql3.EmptyValuesTest to fail:
> {{java.io.IOException: Cannot run program "tools/bin/sstabledump": error=13, 
> Permission denied}}
> {{[junit-timeout] junit.framework.AssertionFailedError: java.io.IOException}}
> {{[junit-timeout]         at 
> org.apache.cassandra.cql3.EmptyValuesTest.verify(EmptyValuesTest.java:85)}}
> {{[junit-timeout]         at 
> org.apache.cassandra.cql3.EmptyValuesTest.verifyJsonInsert(EmptyValuesTest.java:112)}}
> See attached patch of build.xml for the trunk and cassandra-3.11 branches.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-16151) Package tools/bin scripts as executable

2020-10-19 Thread Jira 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-16151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217071#comment-17217071
 ] 

Andres de la Peña commented on CASSANDRA-16151:
---

Looks good to me, I think we should also patch 2.2 and 3.0 since they also seem 
affected.

> Package tools/bin scripts as executable
> ---
>
> Key: CASSANDRA-16151
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16151
> Project: Cassandra
>  Issue Type: Bug
>  Components: Packaging
>Reporter: Angelo Polo
>Assignee: Angelo Polo
>Priority: Normal
>  Labels: patch
> Fix For: 4.0-beta, 3.11.9
>
> Attachments: 3.11-Package-tools-bin-scripts-as-executable.patch, 
> trunk-Package-tools-bin-scripts-as-executable.patch
>
>
> The tools/bin scripts aren't packaged as executable in the source 
> distributions, though in the repository the scripts have the right bits.
> This causes, on 3.11.8 for example, the tests in 
> org.apache.cassandra.cql3.EmptyValuesTest to fail:
> {{java.io.IOException: Cannot run program "tools/bin/sstabledump": error=13, 
> Permission denied}}
> {{[junit-timeout] junit.framework.AssertionFailedError: java.io.IOException}}
> {{[junit-timeout]         at 
> org.apache.cassandra.cql3.EmptyValuesTest.verify(EmptyValuesTest.java:85)}}
> {{[junit-timeout]         at 
> org.apache.cassandra.cql3.EmptyValuesTest.verifyJsonInsert(EmptyValuesTest.java:112)}}
> See attached patch of build.xml for the trunk and cassandra-3.11 branches.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org