[jira] [Commented] (CASSANDRA-16180) 4.0 quality testing: Coordination
[ https://issues.apache.org/jira/browse/CASSANDRA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224810#comment-17224810 ] Andres de la Peña commented on CASSANDRA-16180: --- [~maedhroz] I have created [a PR|https://github.com/apache/cassandra/pull/801] trying to separate range query logic (and tests) from `StorageProxy`. It doesn't add any new tests yet, but it can be useful to see whether it eases testing and what new tests we could add. At least it reduces the size of `StorageProxy` and will probably ease SAI integration in the future. > 4.0 quality testing: Coordination > - > > Key: CASSANDRA-16180 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16180 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 4.0 > > > This is a subtask of CASSANDRA-15579 focusing on coordination. > I think that the main reference dtest for this is > [consistency_test.py|https://github.com/apache/cassandra-dtest/blob/master/consistency_test.py]. > We should identify which other tests cover this and identify what should be > extended, similarly to what has been done with CASSANDRA-15977. > [This > document|https://docs.google.com/document/d/1BBeGKla9tIPflZ2awkyfl5Hc_FTs3QYw98LWUnb1fTQ/edit?usp=sharing] > aims to list and describe the existing functional tests for coordination, so > we can have a broad view of what is currently covered. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16180) 4.0 quality testing: Coordination
[
https://issues.apache.org/jira/browse/CASSANDRA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222335#comment-17222335
]
Andres de la Peña commented on CASSANDRA-16180:
---
[~maedhroz] I'm adding [a
document|https://docs.google.com/document/d/1BBeGKla9tIPflZ2awkyfl5Hc_FTs3QYw98LWUnb1fTQ/edit?usp=sharing]
describing the existing dtests for coordination. I think that they are in
quite better shape than the ones we found for read repair during
CASSANDRA-15977, which is unsurprising given how fundamental coordination is.
After giving it a thought I think that splitting {{StorageProxy}} and trying to
add some unit tests to the separated components is a good thing to do here,
particularly for the range read logic, as you said.
I also agree that it's better to leave Paxos/CAS out of the scope of this
ticket.
> 4.0 quality testing: Coordination
> -
>
> Key: CASSANDRA-16180
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16180
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.0
>
>
> This is a subtask of CASSANDRA-15579 focusing on coordination.
> I think that the main reference dtest for this is
> [consistency_test.py|https://github.com/apache/cassandra-dtest/blob/master/consistency_test.py].
> We should identify which other tests cover this and identify what should be
> extended, similarly to what has been done with CASSANDRA-15977.
> [This
> document|https://docs.google.com/document/d/1BBeGKla9tIPflZ2awkyfl5Hc_FTs3QYw98LWUnb1fTQ/edit?usp=sharing]
> aims to list and describe the existing functional tests for coordination, so
> we can have a broad view of what is currently covered.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16180) 4.0 quality testing: Coordination
[
https://issues.apache.org/jira/browse/CASSANDRA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214286#comment-17214286
]
Benedict Elliott Smith commented on CASSANDRA-16180:
{quote}I'd also propose that we leave Paxos/CAS out of scope for this issue.
{quote}
Yes, that's probably best - there's a related ticket where Sylvain and I have
both expanded Paxos test coverage anyway, and besides this I think it is better
to wait until post 4.0 (shortly after which I hope the Paxos landscape will
materially improve in the project)
> 4.0 quality testing: Coordination
> -
>
> Key: CASSANDRA-16180
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16180
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.0
>
>
> This is a subtask of CASSANDRA-15579 focusing on coordination.
> I think that the main reference dtest for this is
> [consistency_test.py|https://github.com/apache/cassandra-dtest/blob/master/consistency_test.py].
> We should identify which other tests cover this and identify what should be
> extended, similarly to what has been done with CASSANDRA-15977.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16180) 4.0 quality testing: Coordination
[ https://issues.apache.org/jira/browse/CASSANDRA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214034#comment-17214034 ] Caleb Rackliffe commented on CASSANDRA-16180: - I'd also propose that we leave Paxos/CAS out of scope for this issue. CC [~benedict] > 4.0 quality testing: Coordination > - > > Key: CASSANDRA-16180 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16180 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Andres de la Peña >Assignee: Andres de la Peña >Priority: Normal > Fix For: 4.0 > > > This is a subtask of CASSANDRA-15579 focusing on coordination. > I think that the main reference dtest for this is > [consistency_test.py|https://github.com/apache/cassandra-dtest/blob/master/consistency_test.py]. > We should identify which other tests cover this and identify what should be > extended, similarly to what has been done with CASSANDRA-15977. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16180) 4.0 quality testing: Coordination
[
https://issues.apache.org/jira/browse/CASSANDRA-16180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214031#comment-17214031
]
Caleb Rackliffe commented on CASSANDRA-16180:
-
[~adelapena] [~bdeggleston] I know the main focus of this issue is testing, but
I want to propose something that bleeds into our documentation and code
organization along the way. {{StorageProxy}} is one of the most critical
classes in the entire project, but it is almost exactly 3000 lines of code and
has zero class-level JavaDoc. We should break it up into its major constituent
parts (hints, Paxos, point reads, range reads, etc.) and consider testing those
constituent parts in isolation. (There is a {{StorageProxyTest}}, but it's
really just a test for some utilities that also happen to be jammed into
{{StorageProxy}}.)
We don't have to boil the ocean either. You, [~jasonstack], and I know that SAI
is already likely going to pull the range read logic out of {{StorageProxy}},
so pulling that forward (again, assuming we have reasonable tests to avoid
risk) along w/ point reads could be a good first step. (That also corresponds
pretty closely to this Jira in particular.)
> 4.0 quality testing: Coordination
> -
>
> Key: CASSANDRA-16180
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16180
> Project: Cassandra
> Issue Type: Task
> Components: Test/unit
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.0
>
>
> This is a subtask of CASSANDRA-15579 focusing on coordination.
> I think that the main reference dtest for this is
> [consistency_test.py|https://github.com/apache/cassandra-dtest/blob/master/consistency_test.py].
> We should identify which other tests cover this and identify what should be
> extended, similarly to what has been done with CASSANDRA-15977.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
