[jira] [Commented] (CASSANDRA-16190) Add tests for streaming metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17318048#comment-17318048 ] Ekaterina Dimitrova commented on CASSANDRA-16190: - Apologize, I have my GitHub notifications on but it seems I didn't get anything for that commit. I don't know why, I will check my GitHub settings Thank you > Add tests for streaming metrics > --- > > Key: CASSANDRA-16190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16190 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/python >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.0-rc1, 4.0 > > > We currently have no tests to checks the streaming metrics -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16190) Add tests for streaming metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317781#comment-17317781 ] Benjamin Lerer commented on CASSANDRA-16190: [~e.dimitrova] I pushed a fix for your suggestions 3 days ago and thought you might want to look at them before I committed. I will commit. > Add tests for streaming metrics > --- > > Key: CASSANDRA-16190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16190 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/python >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.0-rc > > > We currently have no tests to checks the streaming metrics -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16190) Add tests for streaming metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17316462#comment-17316462 ] Ekaterina Dimitrova commented on CASSANDRA-16190: - [~blerer], I made a review and approved the patch some time ago in GitHub but seems I didn't respond on the ticket. :( Apologize for that. I had some small formatting suggestions which you can decide to consider on commit. Thank you! > Add tests for streaming metrics > --- > > Key: CASSANDRA-16190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16190 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/python >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.0-rc > > > We currently have no tests to checks the streaming metrics -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16190) Add tests for streaming metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308823#comment-17308823 ] Benjamin Lerer commented on CASSANDRA-16190: [~edimitrova] I think you were involve in CASSANDRA-15656. Do you mind reviewing that ticket? > Add tests for streaming metrics > --- > > Key: CASSANDRA-16190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16190 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/python >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.0-rc > > > We currently have no tests to checks the streaming metrics -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16190) Add tests for streaming metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308820#comment-17308820 ] Benjamin Lerer commented on CASSANDRA-16190: [~cscotta] I hit an issue while implementing those tests with the metrics added by CASSANDRA-15656. It seems that they are not updated in every cases. The following [PR|https://github.com/apache/cassandra/pull/941] fix the problem and add the missing tests. Circle-CI [j8|https://app.circleci.com/pipelines/github/blerer/cassandra/116/workflows/4edd0829-c1ee-4ca3-b21d-85cb35da08b9] and [j11|https://app.circleci.com/pipelines/github/blerer/cassandra/116/workflows/795f14d7-9659-4534-8182-5ca0966d63ef] > Add tests for streaming metrics > --- > > Key: CASSANDRA-16190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16190 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/python >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.0-rc > > > We currently have no tests to checks the streaming metrics -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16190) Add tests for streaming metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17304495#comment-17304495 ] C. Scott Andreas commented on CASSANDRA-16190: -- Proposing as a candidate for 4.0.x > Add tests for streaming metrics > --- > > Key: CASSANDRA-16190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16190 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/python >Reporter: Benjamin Lerer >Assignee: Benjamin Lerer >Priority: Normal > Fix For: 4.0-rc > > > We currently have no tests to checks the streaming metrics -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16190) Add tests for streaming metrics
[ https://issues.apache.org/jira/browse/CASSANDRA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245281#comment-17245281 ] Adam Holmberg commented on CASSANDRA-16190: --- Note: Yifan bootstrapped a streaming metrics test in CASSANDRA-16143 that may serve as a basis for this ticket. > Add tests for streaming metrics > --- > > Key: CASSANDRA-16190 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16190 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/python >Reporter: Benjamin Lerer >Priority: Normal > Fix For: 4.0-beta > > > We currently have no tests to checks the streaming metrics -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
