[jira] [Commented] (CASSANDRA-16578) NativeLibrary#getProcessID() does not handle `UnsatisfiedLinkError`
[ https://issues.apache.org/jira/browse/CASSANDRA-16578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390530#comment-17390530 ] Benjamin Lerer commented on CASSANDRA-16578: Thank you for the patch [~drohrer] and sorry for the delay. > NativeLibrary#getProcessID() does not handle `UnsatisfiedLinkError` > --- > > Key: CASSANDRA-16578 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16578 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Fix For: 4.0.1, 3.0.26, 3.11.12 > > Attachments: native-library-fix.patch > > > NativeLibrary#getProcessID() does not handle `UnsatisfiedLinkError` (derived > from Error, not Exception) as the other native methods do. Therefore, it can > never return -1 when it fails for this reason, and can break callers that > would otherwise be able to handle the situation gracefully. Most other > methods in the class do this, but this one is missing the handling of this > error. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16578) NativeLibrary#getProcessID() does not handle `UnsatisfiedLinkError`
[ https://issues.apache.org/jira/browse/CASSANDRA-16578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390480#comment-17390480 ] Benjamin Lerer commented on CASSANDRA-16578: The patch look good to me. > NativeLibrary#getProcessID() does not handle `UnsatisfiedLinkError` > --- > > Key: CASSANDRA-16578 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16578 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Attachments: native-library-fix.patch > > > NativeLibrary#getProcessID() does not handle `UnsatisfiedLinkError` (derived > from Error, not Exception) as the other native methods do. Therefore, it can > never return -1 when it fails for this reason, and can break callers that > would otherwise be able to handle the situation gracefully. Most other > methods in the class do this, but this one is missing the handling of this > error. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16578) NativeLibrary#getProcessID() does not handle `UnsatisfiedLinkError`
[ https://issues.apache.org/jira/browse/CASSANDRA-16578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317423#comment-17317423 ] David Capwell commented on CASSANDRA-16578: --- +1 > NativeLibrary#getProcessID() does not handle `UnsatisfiedLinkError` > --- > > Key: CASSANDRA-16578 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16578 > Project: Cassandra > Issue Type: Bug > Components: Local/Other >Reporter: Doug Rohrer >Assignee: Doug Rohrer >Priority: Normal > Attachments: native-library-fix.patch > > > NativeLibrary#getProcessID() does not handle `UnsatisfiedLinkError` (derived > from Error, not Exception) as the other native methods do. Therefore, it can > never return -1 when it fails for this reason, and can break callers that > would otherwise be able to handle the situation gracefully. Most other > methods in the class do this, but this one is missing the handling of this > error. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
