[jira] [Commented] (CASSANDRA-16623) Remove references to run_dtests from README
[
https://issues.apache.org/jira/browse/CASSANDRA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329355#comment-17329355
]
Ekaterina Dimitrova commented on CASSANDRA-16623:
-
Committed
[here|https://github.com/apache/cassandra-dtest/commit/a082ee1cac951e0d41503cae54454e81198d37ef].
Thanks [~mfleming]
> Remove references to run_dtests from README
> ---
>
> Key: CASSANDRA-16623
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16623
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
>Reporter: Matt Fleming
>Assignee: Matt Fleming
>Priority: Low
>
> Newcomers to cassandra-dtest that look through README.md will see that the
> run_dtests.py script is the quickest way to get started running tests.
> Unfortunately, the script has a number of problems and I'm not sure it ever
> work properly after the move to the pytest framework.
> h2. Process stdout/stderr buffering
> Firstly, when I execute run_dtests.py I don't see any output after
> {{$ ./run_dtests.py --dtest-tests paging_test.py }}
> {{= test session starts
> ==}}
> This looks likely to be because of the buffering that pytest does internally
> for stdout and stderr and because of the way that it's executed by
> run_dtests.py, i.e. I suspect that run_dtests.py is blocked on the following
> line for most of the execution because there's no data available in the pipe
> for stderr:
> {{stderr_output = sp.stderr.readline()}}
> See also [https://github.com/pytest-dev/pytest/issues/1886]
> h2. --pytest-options doesn't work
> Secondly, the options specified in --pytest-options aren't actually passed
> through to pytest.
> h2. Most devs run pytest directly
> When I spoke to [~edimitrova] it seemed like most developers just run the
> tests directly with pytest which would explain why run_dtests.py has
> bitrotted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16623) Remove references to run_dtests from README
[
https://issues.apache.org/jira/browse/CASSANDRA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329206#comment-17329206
]
Ekaterina Dimitrova commented on CASSANDRA-16623:
-
Seeing your comment I tested with single test and that definitely returns
nothing. I was testing other options where it was giving info for runs so it
seems it is really not OK. Thanks for raising it.
[~mck] confirmed the script is still used at places like
[here|https://github.com/apache/cassandra-builds/blob/trunk/build-scripts/cassandra-dtest-pytest.sh#L89].
So we are not removing it but it seems we are all on the same page, agreeing
with the readme change.
+1 I will commit it soon, thanks [~mfleming]
> Remove references to run_dtests from README
> ---
>
> Key: CASSANDRA-16623
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16623
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
>Reporter: Matt Fleming
>Assignee: Matt Fleming
>Priority: Low
> Fix For: 4.0.x
>
>
> Newcomers to cassandra-dtest that look through README.md will see that the
> run_dtests.py script is the quickest way to get started running tests.
> Unfortunately, the script has a number of problems and I'm not sure it ever
> work properly after the move to the pytest framework.
> h2. Process stdout/stderr buffering
> Firstly, when I execute run_dtests.py I don't see any output after
> {{$ ./run_dtests.py --dtest-tests paging_test.py }}
> {{= test session starts
> ==}}
> This looks likely to be because of the buffering that pytest does internally
> for stdout and stderr and because of the way that it's executed by
> run_dtests.py, i.e. I suspect that run_dtests.py is blocked on the following
> line for most of the execution because there's no data available in the pipe
> for stderr:
> {{stderr_output = sp.stderr.readline()}}
> See also [https://github.com/pytest-dev/pytest/issues/1886]
> h2. --pytest-options doesn't work
> Secondly, the options specified in --pytest-options aren't actually passed
> through to pytest.
> h2. Most devs run pytest directly
> When I spoke to [~edimitrova] it seemed like most developers just run the
> tests directly with pytest which would explain why run_dtests.py has
> bitrotted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16623) Remove references to run_dtests from README
[
https://issues.apache.org/jira/browse/CASSANDRA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329194#comment-17329194
]
Matt Fleming commented on CASSANDRA-16623:
--
I think the big problem is that run_dtests.py doesn't actually provide any
useful output (see the suspected issue with pipe buffering mentioned in the GH
PR) which makes it a bad introduction for people with less experience.
Regardless of whether the execute dtest passes or fails, nothing is displayed
the user after the "test session starts" line.
> Remove references to run_dtests from README
> ---
>
> Key: CASSANDRA-16623
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16623
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
>Reporter: Matt Fleming
>Assignee: Matt Fleming
>Priority: Low
> Fix For: 4.0.x
>
>
> Newcomers to cassandra-dtest that look through README.md will see that the
> run_dtests.py script is the quickest way to get started running tests.
> Unfortunately, the script has a number of problems and I'm not sure it ever
> work properly after the move to the pytest framework.
> h2. Process stdout/stderr buffering
> Firstly, when I execute run_dtests.py I don't see any output after
> {{$ ./run_dtests.py --dtest-tests paging_test.py }}
> {{= test session starts
> ==}}
> This looks likely to be because of the buffering that pytest does internally
> for stdout and stderr and because of the way that it's executed by
> run_dtests.py, i.e. I suspect that run_dtests.py is blocked on the following
> line for most of the execution because there's no data available in the pipe
> for stderr:
> {{stderr_output = sp.stderr.readline()}}
> See also [https://github.com/pytest-dev/pytest/issues/1886]
> h2. --pytest-options doesn't work
> Secondly, the options specified in --pytest-options aren't actually passed
> through to pytest.
> h2. Most devs run pytest directly
> When I spoke to [~edimitrova] it seemed like most developers just run the
> tests directly with pytest which would explain why run_dtests.py has
> bitrotted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16623) Remove references to run_dtests from README
[
https://issues.apache.org/jira/browse/CASSANDRA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329175#comment-17329175
]
Ekaterina Dimitrova commented on CASSANDRA-16623:
-
We were considering that too but then I saw this
https://github.com/apache/cassandra-dtest/commit/ec84618b7450ef9357a3a88fc93e39d74a34b02e
Check the last section of the commit message. Also, now reading the README I
feel we can just improve the wording.
Seems to me this wrapper is just for someone who doesn't want to deal with
pytest and doesn't have a lot of experience; whoever just wants to validate the
tests.
And pytest for developers. WDYT? I left comments on the commit
> Remove references to run_dtests from README
> ---
>
> Key: CASSANDRA-16623
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16623
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
>Reporter: Matt Fleming
>Assignee: Matt Fleming
>Priority: Low
> Fix For: 4.0.x
>
>
> Newcomers to cassandra-dtest that look through README.md will see that the
> run_dtests.py script is the quickest way to get started running tests.
> Unfortunately, the script has a number of problems and I'm not sure it ever
> work properly after the move to the pytest framework.
> h2. Process stdout/stderr buffering
> Firstly, when I execute run_dtests.py I don't see any output after
> {{$ ./run_dtests.py --dtest-tests paging_test.py }}
> {{= test session starts
> ==}}
> This looks likely to be because of the buffering that pytest does internally
> for stdout and stderr and because of the way that it's executed by
> run_dtests.py, i.e. I suspect that run_dtests.py is blocked on the following
> line for most of the execution because there's no data available in the pipe
> for stderr:
> {{stderr_output = sp.stderr.readline()}}
> See also [https://github.com/pytest-dev/pytest/issues/1886]
> h2. --pytest-options doesn't work
> Secondly, the options specified in --pytest-options aren't actually passed
> through to pytest.
> h2. Most devs run pytest directly
> When I spoke to [~edimitrova] it seemed like most developers just run the
> tests directly with pytest which would explain why run_dtests.py has
> bitrotted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16623) Remove references to run_dtests from README
[
https://issues.apache.org/jira/browse/CASSANDRA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329171#comment-17329171
]
Brandon Williams commented on CASSANDRA-16623:
--
If we're removing this I don't see any reason to keep run_dtests.py
> Remove references to run_dtests from README
> ---
>
> Key: CASSANDRA-16623
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16623
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/python
>Reporter: Matt Fleming
>Assignee: Matt Fleming
>Priority: Low
> Fix For: 4.0.x
>
>
> Newcomers to cassandra-dtest that look through README.md will see that the
> run_dtests.py script is the quickest way to get started running tests.
> Unfortunately, the script has a number of problems and I'm not sure it ever
> work properly after the move to the pytest framework.
> h2. Process stdout/stderr buffering
> Firstly, when I execute run_dtests.py I don't see any output after
> {{$ ./run_dtests.py --dtest-tests paging_test.py }}
> {{= test session starts
> ==}}
> This looks likely to be because of the buffering that pytest does internally
> for stdout and stderr and because of the way that it's executed by
> run_dtests.py, i.e. I suspect that run_dtests.py is blocked on the following
> line for most of the execution because there's no data available in the pipe
> for stderr:
> {{stderr_output = sp.stderr.readline()}}
> See also [https://github.com/pytest-dev/pytest/issues/1886]
> h2. --pytest-options doesn't work
> Secondly, the options specified in --pytest-options aren't actually passed
> through to pytest.
> h2. Most devs run pytest directly
> When I spoke to [~edimitrova] it seemed like most developers just run the
> tests directly with pytest which would explain why run_dtests.py has
> bitrotted.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16623) Remove references to run_dtests from README
[ https://issues.apache.org/jira/browse/CASSANDRA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326599#comment-17326599 ] Matt Fleming commented on CASSANDRA-16623: -- A patch to update README.md can be found here https://github.com/mfleming/cassandra-dtest/tree/run_dtests > Remove references to run_dtests from README > --- > > Key: CASSANDRA-16623 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16623 > Project: Cassandra > Issue Type: Improvement > Components: Test/dtest/python >Reporter: Matt Fleming >Priority: Normal > > Newcomers to cassandra-dtest that look through README.md will see that the > run_dtests.py script is the quickest way to get started running tests. > Unfortunately, the script has a number of problems and I'm not sure it ever > work properly after the move to the pytest framework. > h2. Process stdout/stderr buffering > Firstly, when I execute run_dtests.py I don't see any output after > $ ./run_dtests.py --dtest-tests paging_test.py > = test session starts > == > This looks likely to be because of the buffering that pytest does internally > for stdout and stderr and because of the way that it's executed by > run_dtests.py, i.e. I suspect that run_dtests.py is blocked on the following > line for most of the execution because there's no data available in the pipe > for stderr: > stderr_output = sp.stderr.readline() > See also pytest-dev/pytest#1886 > h2. --pytest-options doesn't work > Secondly, the options specified in --pytest-options aren't actually passed > through to pytest. > h2. Most devs run pytest directly > When I spoke to @ekaterinadimitrova2 it seemed like most developers just run > the tests directly with pytest which would explain why run_dtests.py has > bitrotted. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
