[jira] [Commented] (CASSANDRA-16648) Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340655#comment-17340655 ] Berenguer Blasi commented on CASSANDRA-16648: - Committed thx [~mck] for all your help! > Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was > created) > - > > Key: CASSANDRA-16648 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16648 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.x > > > Python DTest upgrade manifest: > - > https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:mck/16642--introduce-cassandra-4.0 > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/645/ > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/273/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16648) Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340208#comment-17340208 ] Michael Semb Wever commented on CASSANDRA-16648: *CI runs look good.* 2.2-3.11 have lots of failures anyway (we should probably mark them all ignored, considering no one is going to fix them). devbranch doesn't run all the dtest variations, so you won't get the same number of tests… > Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was > created) > - > > Key: CASSANDRA-16648 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16648 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc, 4.x > > > Python DTest upgrade manifest: > - > https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:mck/16642--introduce-cassandra-4.0 > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/645/ > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/273/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16648) Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340206#comment-17340206 ] Berenguer Blasi commented on CASSANDRA-16648: - [~mck] I need you pick your brain here. 4.0 and trunk CI runs lgtm, aligned to what we know. 3.11 also looks aligned to the 3.11 CI runs except for the fact that it went red. The 3.0 run is hard to read as it can go as high as 50 failures. As you have more experience than me in older branches is what you see seem ok to you? Apologies for the delay on the CI runs, they've taken forever jenkins was very slow today for some reason. > Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was > created) > - > > Key: CASSANDRA-16648 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16648 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc, 4.x > > > Python DTest upgrade manifest: > - > https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:mck/16642--introduce-cassandra-4.0 > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/645/ > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/273/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16648) Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340061#comment-17340061 ] Michael Semb Wever commented on CASSANDRA-16648: +1 > Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was > created) > - > > Key: CASSANDRA-16648 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16648 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.x > > > Python DTest upgrade manifest: > - > https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:mck/16642--introduce-cassandra-4.0 > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/645/ > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/273/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16648) Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339993#comment-17339993 ] Berenguer Blasi commented on CASSANDRA-16648: - Running final CIs: - https://ci-cassandra.apache.org/job/Cassandra-devbranch/735/ - https://ci-cassandra.apache.org/job/Cassandra-devbranch/736/ > Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was > created) > - > > Key: CASSANDRA-16648 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16648 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0-rc2, 4.x > > > Python DTest upgrade manifest: > - > https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:mck/16642--introduce-cassandra-4.0 > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/645/ > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/273/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16648) Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339478#comment-17339478 ] Berenguer Blasi commented on CASSANDRA-16648: - [~mck] I am putting this up for review with the following proposal: - Merge my current PR - CASSANDRA-16653 for the remaining non obvious failure > Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was > created) > - > > Key: CASSANDRA-16648 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16648 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > > Python DTest upgrade manifest: > - > https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:mck/16642--introduce-cassandra-4.0 > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/645/ > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/273/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16648) Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338862#comment-17338862 ] Berenguer Blasi commented on CASSANDRA-16648: - Ok some progress. In [this|https://github.com/apache/cassandra-dtest/pull/134/files] PR we can see paging errors have been [fixed|https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/276/]. The problem now lies on cqlsh tests. Doing some local testing it seems some cqlsh that was legal on 3.11 it's not anymore on 4.0. So tests updating 4.0->4.1 fail bc they are using illegal syntax. I _think_ these tests need updating to the newer syntax rather than being a product problem. I need to confirm that and then fix accordingly. > Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was > created) > - > > Key: CASSANDRA-16648 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16648 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > > Python DTest upgrade manifest: > - > https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:mck/16642--introduce-cassandra-4.0 > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/645/ > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/273/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16648) Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was created)
[
https://issues.apache.org/jira/browse/CASSANDRA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338762#comment-17338762
]
Berenguer Blasi commented on CASSANDRA-16648:
-
cqlsh failures seem legit and not a test problem:
{noformat}
CREATE KEYSPACE foo WITH replication = {'class': 'SimpleStrategy',
'replication_factor': 1};
CREATE TABLE foo.test1 (k int, t int, v int, PRIMARY KEY(k, t));
CREATE MATERIALIZED VIEW foo.view1 AS SELECT * FROM foo.test1 WHERE v IS NOT
NULL AND t IS NOT NULL PRIMARY KEY (k, v, t);
InvalidRequest: Error from server: code=2200 [Invalid query] message="Primary
key columns k must be restricted with 'IS NOT NULL' or otherwise"
{noformat}
Let me investigate a bit more and I'll push a PR or raise tickets accordingly.
It's weird this started failing out of the blue...
> Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was
> created)
> -
>
> Key: CASSANDRA-16648
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16648
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/python
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> Python DTest upgrade manifest:
> -
> https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:mck/16642--introduce-cassandra-4.0
> - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/645/
> - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/273/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16648) Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was created)
[
https://issues.apache.org/jira/browse/CASSANDRA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338759#comment-17338759
]
Berenguer Blasi commented on CASSANDRA-16648:
-
It seems there is some python list expression somehwre that changed. When you
change the offending:
tables = ("test", "test2") if testing_compact_storage else ("test")
to
tables = ["test", "test2"] if testing_compact_storage else ["test"]
it seems to pass now but why was it passing before?
> Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was
> created)
> -
>
> Key: CASSANDRA-16648
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16648
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/python
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> Python DTest upgrade manifest:
> -
> https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:mck/16642--introduce-cassandra-4.0
> - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/645/
> - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/273/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16648) Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338754#comment-17338754 ] Berenguer Blasi commented on CASSANDRA-16648: - Well, not sure how nosetests/pytest/run_dtests all interact but I managed to repro locally. Thought I'd share it to save you some time: bq. pytest -vv --log-cli-level=DEBUG --junit-xml=nosetests.xml --junit-prefix=dtest-upgrade -s --cassandra-dir=/tmp/test --execute-upgrade-tests-only --upgrade-target-version-only --upgrade-version-selection all upgrade_tests/paging_test.py::TestPagingDataNodes3RF3_Upgrade_current_4_0_x_To_indev_trunk::test_basic_paging > Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was > created) > - > > Key: CASSANDRA-16648 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16648 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/python >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > > Python DTest upgrade manifest: > - > https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:mck/16642--introduce-cassandra-4.0 > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/645/ > - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/273/ -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16648) Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was created)
[
https://issues.apache.org/jira/browse/CASSANDRA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17338300#comment-17338300
]
Berenguer Blasi commented on CASSANDRA-16648:
-
[~mck] I've only managed to get where you are and a bit furtehr. If you setup
upgrade tests locally and try to run cqlsh tests you get:
{noformat}
nosetests -vs upgrade_tests/cql_tests.py
Failure: AttributeError ('NoneType' object has no attribute 'getoption') ...
ERROR
==
ERROR: Failure: AttributeError ('NoneType' object has no attribute 'getoption')
--
Traceback (most recent call last):
File
"/home/bereng/work/repos/bdpWS/dtests/lib/python3.8/site-packages/nose/failure.py",
line 39, in runTest
raise self.exc_val.with_traceback(self.tb)
File
"/home/bereng/work/repos/bdpWS/dtests/lib/python3.8/site-packages/nose/loader.py",
line 417, in loadTestsFromName
module = self.importer.importFromPath(
File
"/home/bereng/work/repos/bdpWS/dtests/lib/python3.8/site-packages/nose/importer.py",
line 47, in importFromPath
return self.importFromDir(dir_path, fqname)
File
"/home/bereng/work/repos/bdpWS/dtests/lib/python3.8/site-packages/nose/importer.py",
line 94, in importFromDir
mod = load_module(part_fqname, fh, filename, desc)
File "/usr/lib/python3.8/imp.py", line 234, in load_module
return load_source(name, filename, file)
File "/usr/lib/python3.8/imp.py", line 171, in load_source
module = _load(spec)
File "", line 702, in _load
File "", line 671, in _load_unlocked
File "", line 783, in exec_module
File "", line 219, in _call_with_frames_removed
File "/home/bereng/work/repos/bdpWS/dtests/upgrade_tests/cql_tests.py", line
5525, in
for s, p in itertools.product(topology_specs, build_upgrade_pairs())]
File
"/home/bereng/work/repos/bdpWS/dtests/upgrade_tests/upgrade_manifest.py", line
205, in build_upgrade_pairs
configured_strategy =
CONFIG.getoption("--upgrade-version-selection").upper()
AttributeError: 'NoneType' object has no attribute 'getoption'
>> begin captured logging <<
dtest: DEBUG: Python driver version in use: 3.24.0
- >> end captured logging << -
--
Ran 1 test in 0.000s
FAILED (errors=1)
{noformat}
This and the paging are the only 2 ones failing. I have followed the code a bit
and I think it's somehow missing to shuffle/read versions correctly. As you
mentioned me you intended to look into this today I'd thought I'd drop this in
case it helps. Now it's a matter of unraveling this last bit and it should be
good imo.
> Add 4_0_x to Python DTest's upgrade_manifest (after cassandra-4.0 branch was
> created)
> -
>
> Key: CASSANDRA-16648
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16648
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/python
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
>
> Python DTest upgrade manifest:
> -
> https://github.com/apache/cassandra-dtest/compare/trunk...thelastpickle:mck/16642--introduce-cassandra-4.0
> - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest/645/
> - https://ci-cassandra.apache.org/job/Cassandra-devbranch-dtest-upgrade/273/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
