[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379413#comment-17379413 ] Michael Semb Wever commented on CASSANDRA-16649: Committed as [b3f99218815c318eaf60e950300163463d2bdba4|https://github.com/apache/cassandra/commit/b3f99218815c318eaf60e950300163463d2bdba4]. > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.20, 3.0.25, 3.11.11, 4.0.1, 4.1 > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379384#comment-17379384 ] Michael Semb Wever commented on CASSANDRA-16649: CI full pipelines using the released 0.0.8: - 3.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/930/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/930/] - 3.11 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/931/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/931/] - 4.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/932/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/932/] - trunk [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/933/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/933/] > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379170#comment-17379170 ] Alex Petrov commented on CASSANDRA-16649: - +1 > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379150#comment-17379150 ] Michael Semb Wever commented on CASSANDRA-16649: dtest-api 0.0.8 [released|https://lists.apache.org/thread.html/r161c863fdcdffc63ea66852242f47b8a93a20e50e5bf8c7293a7406f%40%3Cdev.cassandra.apache.org%3E]. > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376698#comment-17376698 ] Michael Semb Wever commented on CASSANDRA-16649: CI full pipelines: - 3.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/894/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/894/] - 3.11 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/895/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/895/] - 4.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/898/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/898/] - trunk [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/899/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch/899/] > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[
https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17374327#comment-17374327
]
Michael Semb Wever commented on CASSANDRA-16649:
CI jvm-dtest-upgrade
- trunk
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/605/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/605/]
(it ran 35 tests versus 46 tests on trunk, zero of which before were upgrades
to 4.1)
- 4.0
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/602/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/602/]
(it ran 35 tests versus 40 tests on cassandra-4.0)
- 3.11
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/601/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/601/]
(it ran 16 tests, same as cassandra-3.11)
- 3.0
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/604/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/604/]
(it ran 16 tests versus 18 tests on cassandra-3.0)
- 2.2
[!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/600/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/600/]
(it ran 10 tests, while ci-cassandra.a.o doesn't run this post-commit 🤷🏻♀️ )
Fixes required (patches above updated accordingly)
- fix to include dtest jar files that didn't include a patch version number in
their name,
- the supported upgrade paths updated for each path, tests that don't apply to
older (or newer) branches are removed
- better info logging in UpgradeBaseTest
In the output of some of the failed tests above there is
{{"NoClassDefFoundError: com/vdurmont/semver4j/Semver"}} , but this happens
only on failures and against exceptions already found in the branches.
I also suspect there's a thorough review required of all the upgrade tests,
involving
- what upgrade paths (now and into the future) they are applicable to, and
- fixing asserts to be forward compatible with new upgrade paths.
> Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
> --
>
> Key: CASSANDRA-16649
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16649
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/java
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> -
> https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649
> -
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373508#comment-17373508 ] Michael Semb Wever commented on CASSANDRA-16649: Final patches - cassandra-in-jvm-dtest-api :: https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649_all - trunk :: https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649_all/trunk - cassandra-4.0 :: https://github.com/apache/cassandra/compare/cassandra-4.0...thelastpickle:mck/16649_all/4.0 - cassandra-4.0.0 :: https://github.com/apache/cassandra/compare/cassandra-4.0.0...thelastpickle:mck/16649_all/4.0.0 - cassandra-3.11 :: https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/16649_all/3.11 - cassandra-3.0 :: wip - cassandra-2.2 :: wip > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 2.2.x, 3.0.x, 3.11.x, 4.0.x, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365293#comment-17365293 ] Alex Petrov commented on CASSANDRA-16649: - Left a small comment (create files during tests vs storing them in repository) in dtest. Since most of version and comparing was already implemented, I personally would have just added support for 4.x and rc/beta/alpha. However, I do not have a strong opinion in this specific case, since it's used in tests. If we do run into dependency conflict and one of our dependencies has semver4j as a transitive dependency, we can just revert and implement it "natively". Just to make sure this is mentioned: changes made to dtests have to be applied to all branches that have dtest api referenced. +1 > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.0.x, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[
https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17365274#comment-17365274
]
Michael Semb Wever commented on CASSANDRA-16649:
bq. I'm thinking that solving that is going to be easier, and more
maintainable, by using SemVer4j inside Versions.Major.
The full suite of changes is the following:
For _cassandra-in-jvm-dtest-api _
1.
https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649
2. https://github.com/thelastpickle/cassandra-in-jvm-dtest-api/pull/1
3. https://github.com/thelastpickle/cassandra-in-jvm-dtest-api/pull/2
That implements version 4.0 and 4.1 in (1), introduces the SemVer4j library for
internal version parsing and handling in (2), and introduces SemVer4j into the
API replacing the {{Versions.Major}} enum with SemVer4j's {{Semer}} class in
(3).
For _cassandra-4.0_
A.
https://github.com/apache/cassandra/compare/cassandra-4.0...thelastpickle:mck/16649/4.0
B. https://github.com/thelastpickle/cassandra/pull/1
(A) is the changes required for 1, and (B) is the changes required for 3.
In addition, (A) changes upgrades from testing the single explicit path, to
testing all upgrade paths that are (globally) supported within the specified
{{from}} and {{to}} range. Where {{to}} is not specified it is implied to be
the {{CURRENT}} version.
The final patches for all of these put together are
- cassandra-in-jvm-dtest-api ::
https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649_all
- cassandra-4.0 ::
https://github.com/apache/cassandra/compare/cassandra-4.0...thelastpickle:mck/16649_all/4.0
> Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
> --
>
> Key: CASSANDRA-16649
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16649
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/java
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
>
> -
> https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649
> -
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364119#comment-17364119 ] Alex Petrov commented on CASSANDRA-16649: - +1 on both dtest and Cassandra changes, thank you for the patch and sorry for such a long delay with a review. > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.0.x, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[ https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17345079#comment-17345079 ] Michael Semb Wever commented on CASSANDRA-16649: Patches: - https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 - https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/487/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/487/] - https://github.com/apache/cassandra/compare/cassandra-4.0...thelastpickle:mck/16649/4.0 [!https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/488/badge/icon!|https://ci-cassandra.apache.org/job/Cassandra-devbranch-jvm-dtest-upgrade/488/] > Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created) > -- > > Key: CASSANDRA-16649 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16649 > Project: Cassandra > Issue Type: Sub-task > Components: Test/dtest/java >Reporter: Michael Semb Wever >Assignee: Michael Semb Wever >Priority: Normal > Fix For: 4.0-rc, 4.x > > > - > https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649 > - > https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[
https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341919#comment-17341919
]
Michael Semb Wever commented on CASSANDRA-16649:
bq. Wanted to discuss this change in more details. …
Now that we don't keep jar files in the {{lib/}}, adding a snapshot maven
repository to download is going to be more common for patches that cross code
repos. That change was intentionally in a separate commit, to be thrown away
before merge (I should have prefixed the commit msg: 'THROWAWAY …'). I too am
not sure how we should be standardising this…
bq. Do you plan to address rc/beta/alpha comparisons in this patch (see this
todo)?
I'm thinking that solving that is going to be easier, and more maintainable, by
using [SemVer4j|https://github.com/vdurmont/semver4j] inside
{{Versions.Major}}. I plan on doing that in a separate ticket. WDYT?
> Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
> --
>
> Key: CASSANDRA-16649
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16649
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/java
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 4.0-rc, 4.x
>
>
> -
> https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649
> -
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16649) Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
[
https://issues.apache.org/jira/browse/CASSANDRA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341901#comment-17341901
]
Alex Petrov commented on CASSANDRA-16649:
-
Wanted to discuss [this
change|https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk#diff-b7d8cc9a23d28a1713d5242f83da30838851d0685528abdb937afe7d9b899de6R59]
in more details. I think it's a good idea to allow people to test out
dtest-api changes using a snapshot, however it seems that allowing people to
commit these things to `trunk` might be a bit dangerous, since we won't be able
to reproduce the builds. I'm not sure what's the best way to mitigate this
though.
Do you plan to address {{rc/beta/alpha}} comparisons in this patch (see [this
todo|https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649#diff-871746bc8496d850d8660ffd287e44fcc60c9050e17f12c45ab8c9ece49c3acdR122])?
The rest of the change looks good to me.
> Add Versions.Major.v4X to Java DTests (after cassandra-4.0 branch was created)
> --
>
> Key: CASSANDRA-16649
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16649
> Project: Cassandra
> Issue Type: Sub-task
> Components: Test/dtest/java
>Reporter: Michael Semb Wever
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 4.0-rc, 4.x
>
>
> -
> https://github.com/apache/cassandra-in-jvm-dtest-api/compare/trunk...thelastpickle:mck/16649
> -
> https://github.com/apache/cassandra/compare/trunk...thelastpickle:mck/16649/trunk
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
