[jira] [Commented] (CASSANDRA-16774) BinLog does not close chronicle queue leaving this to GC to cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376677#comment-17376677 ] Caleb Rackliffe commented on CASSANDRA-16774: - 4.0.0 back-port committed as https://github.com/apache/cassandra/commit/68bf950f72d20be9f31fd3f91669be7e28c050e4 > BinLog does not close chronicle queue leaving this to GC to cleanup > --- > > Key: CASSANDRA-16774 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16774 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python, Tool/fql >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.1, 4.1 > > > auditlog_test.py::TestAuditlog::test_archiving_fql and > test_fql_nodetool_options fail from time to time due to the test relying on a > race condition; we do not close chronicle queue so rotation may not happen > before stopping archiver, the tests fail if rotation happens before stopping > archiver (which is done based off GC). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16774) BinLog does not close chronicle queue leaving this to GC to cleanup
[
https://issues.apache.org/jira/browse/CASSANDRA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376245#comment-17376245
]
Berenguer Blasi commented on CASSANDRA-16774:
-
The failures are unrelated. And that {{UnableToParseClientMessageTest}} I'd
swear I've seen before. So I think we're good to merge imo. +1
> BinLog does not close chronicle queue leaving this to GC to cleanup
> ---
>
> Key: CASSANDRA-16774
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16774
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python, Tool/fql
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0.1, 4.1
>
>
> auditlog_test.py::TestAuditlog::test_archiving_fql and
> test_fql_nodetool_options fail from time to time due to the test relying on a
> race condition; we do not close chronicle queue so rotation may not happen
> before stopping archiver, the tests fail if rotation happens before stopping
> archiver (which is done based off GC).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16774) BinLog does not close chronicle queue leaving this to GC to cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376136#comment-17376136 ] Ekaterina Dimitrova commented on CASSANDRA-16774: - I haven't seen it before. It doesn't fail for me locally in 4.0.0. Considering that the assert is based on a grep in the logs, I would say probably there is some test flakiness somewhere and we should improve the test... I can take a look these days. This failing test doesn't exercise the code you changed > BinLog does not close chronicle queue leaving this to GC to cleanup > --- > > Key: CASSANDRA-16774 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16774 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python, Tool/fql >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.1, 4.1 > > > auditlog_test.py::TestAuditlog::test_archiving_fql and > test_fql_nodetool_options fail from time to time due to the test relying on a > race condition; we do not close chronicle queue so rotation may not happen > before stopping archiver, the tests fail if rotation happens before stopping > archiver (which is done based off GC). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16774) BinLog does not close chronicle queue leaving this to GC to cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17376048#comment-17376048 ] Caleb Rackliffe commented on CASSANDRA-16774: - Tests [look good|https://ci-cassandra.apache.org/job/Cassandra-devbranch/897/], outside what appear to be 3 entirely unrelated failures. [~edimitrova] [~bereng] Any idea if the failure in [UnableToParseClientMessageTest|https://ci-cassandra.apache.org/job/Cassandra-devbranch/897/testReport/junit/org.apache.cassandra.distributed.test/UnableToParseClientMessageTest/badHeader_version_4_v4_/] is new. That's the only one I didn't find a Jira for. > BinLog does not close chronicle queue leaving this to GC to cleanup > --- > > Key: CASSANDRA-16774 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16774 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python, Tool/fql >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.1, 4.1 > > > auditlog_test.py::TestAuditlog::test_archiving_fql and > test_fql_nodetool_options fail from time to time due to the test relying on a > race condition; we do not close chronicle queue so rotation may not happen > before stopping archiver, the tests fail if rotation happens before stopping > archiver (which is done based off GC). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16774) BinLog does not close chronicle queue leaving this to GC to cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375966#comment-17375966 ] Jon Meredith commented on CASSANDRA-16774: -- +1, change looks good pending tests. > BinLog does not close chronicle queue leaving this to GC to cleanup > --- > > Key: CASSANDRA-16774 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16774 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python, Tool/fql >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.1, 4.1 > > > auditlog_test.py::TestAuditlog::test_archiving_fql and > test_fql_nodetool_options fail from time to time due to the test relying on a > race condition; we do not close chronicle queue so rotation may not happen > before stopping archiver, the tests fail if rotation happens before stopping > archiver (which is done based off GC). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16774) BinLog does not close chronicle queue leaving this to GC to cleanup
[
https://issues.apache.org/jira/browse/CASSANDRA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375946#comment-17375946
]
Caleb Rackliffe commented on CASSANDRA-16774:
-
[~bereng] [~marcuse] [~e.dimitrova] [~jmeredithco] [~dcapwell] Here is a small
patch to back-port the change to {{cassandra-4.0.0}} (with a Jenkins run in
progress):
[branch|https://github.com/apache/cassandra/pull/1102],
[Jenkins|https://ci-cassandra.apache.org/job/Cassandra-devbranch/897/]
> BinLog does not close chronicle queue leaving this to GC to cleanup
> ---
>
> Key: CASSANDRA-16774
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16774
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python, Tool/fql
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Fix For: 4.0.1, 4.1
>
>
> auditlog_test.py::TestAuditlog::test_archiving_fql and
> test_fql_nodetool_options fail from time to time due to the test relying on a
> race condition; we do not close chronicle queue so rotation may not happen
> before stopping archiver, the tests fail if rotation happens before stopping
> archiver (which is done based off GC).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16774) BinLog does not close chronicle queue leaving this to GC to cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375869#comment-17375869 ] Caleb Rackliffe commented on CASSANDRA-16774: - [~bereng] I think you are correct. The simplest fix is probably just to make sure that the two line change from [this commit|https://github.com/dcapwell/cassandra/commit/f0a7ea411fe237543200b3c67a2f0fb34536c162] ends up in 4.0.0 instead of just 4.0. Seems like a reasonable candidate for a ninja-fix. > BinLog does not close chronicle queue leaving this to GC to cleanup > --- > > Key: CASSANDRA-16774 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16774 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python, Tool/fql >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.1, 4.1 > > > auditlog_test.py::TestAuditlog::test_archiving_fql and > test_fql_nodetool_options fail from time to time due to the test relying on a > race condition; we do not close chronicle queue so rotation may not happen > before stopping archiver, the tests fail if rotation happens before stopping > archiver (which is done based off GC). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16774) BinLog does not close chronicle queue leaving this to GC to cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17375228#comment-17375228 ] Berenguer Blasi commented on CASSANDRA-16774: - Hi, I have been bisecting a bit and I think recent 4.0.0 [failures|https://ci-cassandra.apache.org/job/Cassandra-4.0.0/44/] and due to this ticket? Could sbdy familiar with it confirm please? Thx in advance > BinLog does not close chronicle queue leaving this to GC to cleanup > --- > > Key: CASSANDRA-16774 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16774 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python, Tool/fql >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.1, 4.1 > > > auditlog_test.py::TestAuditlog::test_archiving_fql and > test_fql_nodetool_options fail from time to time due to the test relying on a > race condition; we do not close chronicle queue so rotation may not happen > before stopping archiver, the tests fail if rotation happens before stopping > archiver (which is done based off GC). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16774) BinLog does not close chronicle queue leaving this to GC to cleanup
[ https://issues.apache.org/jira/browse/CASSANDRA-16774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17373701#comment-17373701 ] David Capwell commented on CASSANDRA-16774: --- Starting commit CI Results (pending): ||Branch||Source||Circle CI||Jenkins|| |cassandra-4.0|[branch|https://github.com/dcapwell/cassandra/tree/commit_remote_branch/CASSANDRA-16774-cassandra-4.0-F7958CBF-9DF6-44CE-A83C-E236C6694AFF]|[build|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-16774-cassandra-4.0-F7958CBF-9DF6-44CE-A83C-E236C6694AFF]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/888/]| |trunk|[branch|https://github.com/dcapwell/cassandra/tree/commit_remote_branch/CASSANDRA-16774-trunk-F7958CBF-9DF6-44CE-A83C-E236C6694AFF]|[build|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-16774-trunk-F7958CBF-9DF6-44CE-A83C-E236C6694AFF]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/889/]| > BinLog does not close chronicle queue leaving this to GC to cleanup > --- > > Key: CASSANDRA-16774 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16774 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/python, Tool/fql >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Fix For: 4.0.1, 4.1 > > > auditlog_test.py::TestAuditlog::test_archiving_fql and > test_fql_nodetool_options fail from time to time due to the test relying on a > race condition; we do not close chronicle queue so rotation may not happen > before stopping archiver, the tests fail if rotation happens before stopping > archiver (which is done based off GC). -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
