[jira] [Commented] (CASSANDRA-17001) Optionally prune CDC segments if consumer fails to consume them fast enough
[ https://issues.apache.org/jira/browse/CASSANDRA-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453784#comment-17453784 ] Yifan Cai commented on CASSANDRA-17001: --- Starting commit CI Results: green with some known flaky/broken tests. ||Branch||Source||Circle CI|| |trunk|[branch|https://github.com/yifan-c/cassandra/tree/commit_remote_branch/CASSANDRA-17001-trunk-AD06D20D-CC56-4243-B3B5-7D5974415AC4]|[build|https://app.circleci.com/pipelines/github/yifan-c/cassandra?branch=commit_remote_branch%2FCASSANDRA-17001-trunk-AD06D20D-CC56-4243-B3B5-7D5974415AC4]| > Optionally prune CDC segments if consumer fails to consume them fast enough > --- > > Key: CASSANDRA-17001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17001 > Project: Cassandra > Issue Type: Improvement > Components: Local/Commit Log >Reporter: Dinesh Joshi >Assignee: Yifan Cai >Priority: Normal > Time Spent: 1h 20m > Remaining Estimate: 0h > > Current CDC implementation blocks writes if the CDC segments have filled up. > This makes sense for some use-cases. In other cases it would be beneficial > for C* to prune the CDC segments if they haven't been consumed. This will > prevent blocking of writes. With this change we will introduce a flag to > prune CDC segments much like a circular buffer. This will prevent the writes > being blocked. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17001) Optionally prune CDC segments if consumer fails to consume them fast enough
[ https://issues.apache.org/jira/browse/CASSANDRA-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451951#comment-17451951 ] Josh McKenzie commented on CASSANDRA-17001: --- Had one other nit / question / thought, but otherwise LGTM. +1 > Optionally prune CDC segments if consumer fails to consume them fast enough > --- > > Key: CASSANDRA-17001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17001 > Project: Cassandra > Issue Type: Improvement > Components: Local/Commit Log >Reporter: Dinesh Joshi >Assignee: Yifan Cai >Priority: Normal > Time Spent: 1h 10m > Remaining Estimate: 0h > > Current CDC implementation blocks writes if the CDC segments have filled up. > This makes sense for some use-cases. In other cases it would be beneficial > for C* to prune the CDC segments if they haven't been consumed. This will > prevent blocking of writes. With this change we will introduce a flag to > prune CDC segments much like a circular buffer. This will prevent the writes > being blocked. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17001) Optionally prune CDC segments if consumer fails to consume them fast enough
[ https://issues.apache.org/jira/browse/CASSANDRA-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451942#comment-17451942 ] Yifan Cai commented on CASSANDRA-17001: --- Thanks [~jmckenzie] for the review. I pushed new commits to address the comments. > Optionally prune CDC segments if consumer fails to consume them fast enough > --- > > Key: CASSANDRA-17001 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17001 > Project: Cassandra > Issue Type: Improvement > Components: Local/Commit Log >Reporter: Dinesh Joshi >Assignee: Yifan Cai >Priority: Normal > Time Spent: 1h > Remaining Estimate: 0h > > Current CDC implementation blocks writes if the CDC segments have filled up. > This makes sense for some use-cases. In other cases it would be beneficial > for C* to prune the CDC segments if they haven't been consumed. This will > prevent blocking of writes. With this change we will introduce a flag to > prune CDC segments much like a circular buffer. This will prevent the writes > being blocked. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
