[jira] [Commented] (CASSANDRA-17126) Remove use of deprecated Files in tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483250#comment-17483250 ] Brandon Williams commented on CASSANDRA-17126: -- You put it in the correct state, thanks 👍 > Remove use of deprecated Files in tests > --- > > Key: CASSANDRA-17126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17126 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Venkata Harikrishna Nukala >Priority: Normal > Fix For: 4.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > From checkstyle: > {noformat} > 5 Illegal import - java.io.File. [IllegalImport] > 3 Illegal import - java.io.FileInputStream. [IllegalImport] > 2 Illegal import - java.io.FileOutputStream. [IllegalImport] > 3 Illegal import - java.io.FileWriter. [IllegalImport] > 16 Illegal import - java.io.RandomAccessFile. [IllegalImport] > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17126) Remove use of deprecated Files in tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483247#comment-17483247 ] Ekaterina Dimitrova commented on CASSANDRA-17126: - I hope you don't mind I changed the ticket status so it doesn't confuse people you still need a committer :) > Remove use of deprecated Files in tests > --- > > Key: CASSANDRA-17126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17126 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Venkata Harikrishna Nukala >Priority: Normal > Fix For: 4.x > > Time Spent: 1.5h > Remaining Estimate: 0h > > From checkstyle: > {noformat} > 5 Illegal import - java.io.File. [IllegalImport] > 3 Illegal import - java.io.FileInputStream. [IllegalImport] > 2 Illegal import - java.io.FileOutputStream. [IllegalImport] > 3 Illegal import - java.io.FileWriter. [IllegalImport] > 16 Illegal import - java.io.RandomAccessFile. [IllegalImport] > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17126) Remove use of deprecated Files in tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482908#comment-17482908 ] Berenguer Blasi commented on CASSANDRA-17126: - Code lgtm. The failing junit passes locally. I left a few nits that can be addressed on commit. +1 > Remove use of deprecated Files in tests > --- > > Key: CASSANDRA-17126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17126 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Venkata Harikrishna Nukala >Priority: Normal > Fix For: 4.x > > Time Spent: 1h > Remaining Estimate: 0h > > From checkstyle: > {noformat} > 5 Illegal import - java.io.File. [IllegalImport] > 3 Illegal import - java.io.FileInputStream. [IllegalImport] > 2 Illegal import - java.io.FileOutputStream. [IllegalImport] > 3 Illegal import - java.io.FileWriter. [IllegalImport] > 16 Illegal import - java.io.RandomAccessFile. [IllegalImport] > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17126) Remove use of deprecated Files in tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482788#comment-17482788 ] Brandon Williams commented on CASSANDRA-17126: -- +1 > Remove use of deprecated Files in tests > --- > > Key: CASSANDRA-17126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17126 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Venkata Harikrishna Nukala >Priority: Normal > Fix For: 4.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > From checkstyle: > {noformat} > 5 Illegal import - java.io.File. [IllegalImport] > 3 Illegal import - java.io.FileInputStream. [IllegalImport] > 2 Illegal import - java.io.FileOutputStream. [IllegalImport] > 3 Illegal import - java.io.FileWriter. [IllegalImport] > 16 Illegal import - java.io.RandomAccessFile. [IllegalImport] > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17126) Remove use of deprecated Files in tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17482717#comment-17482717 ] Brandon Williams commented on CASSANDRA-17126: -- [Circle|https://app.circleci.com/pipelines/github/driftx/cassandra?branch=CASSANDRA-17126&filter=all] in progress. > Remove use of deprecated Files in tests > --- > > Key: CASSANDRA-17126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17126 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Venkata Harikrishna Nukala >Priority: Normal > Fix For: 4.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > From checkstyle: > {noformat} > 5 Illegal import - java.io.File. [IllegalImport] > 3 Illegal import - java.io.FileInputStream. [IllegalImport] > 2 Illegal import - java.io.FileOutputStream. [IllegalImport] > 3 Illegal import - java.io.FileWriter. [IllegalImport] > 16 Illegal import - java.io.RandomAccessFile. [IllegalImport] > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17126) Remove use of deprecated Files in tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476869#comment-17476869 ] Ekaterina Dimitrova commented on CASSANDRA-17126: - Hi [~n.v.harikrishna], Thank you for your work, I moved the ticket to Patch Available. Please ensure when you work on a patch to change the ticket status respectively to the phase it is in (Work in Progress, Patch Available, Needs Committer, etc) to signal the community that this work needs attention. I saw you posted a patch just by chance. :-) > Remove use of deprecated Files in tests > --- > > Key: CASSANDRA-17126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17126 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Venkata Harikrishna Nukala >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > From checkstyle: > {noformat} > 5 Illegal import - java.io.File. [IllegalImport] > 3 Illegal import - java.io.FileInputStream. [IllegalImport] > 2 Illegal import - java.io.FileOutputStream. [IllegalImport] > 3 Illegal import - java.io.FileWriter. [IllegalImport] > 16 Illegal import - java.io.RandomAccessFile. [IllegalImport] > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17126) Remove use of deprecated Files in tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17471318#comment-17471318 ] Venkata Harikrishna Nukala commented on CASSANDRA-17126: Made the changes. PR: https://github.com/apache/cassandra/pull/1381 Circle CI: https://app.circleci.com/pipelines/github/nvharikrishna/cassandra/60/workflows/cb6858cb-6c0d-401f-b77c-64ee517c22af > Remove use of deprecated Files in tests > --- > > Key: CASSANDRA-17126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17126 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Venkata Harikrishna Nukala >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > From checkstyle: > {noformat} > 5 Illegal import - java.io.File. [IllegalImport] > 3 Illegal import - java.io.FileInputStream. [IllegalImport] > 2 Illegal import - java.io.FileOutputStream. [IllegalImport] > 3 Illegal import - java.io.FileWriter. [IllegalImport] > 16 Illegal import - java.io.RandomAccessFile. [IllegalImport] > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17126) Remove use of deprecated Files in tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459945#comment-17459945 ] Brandon Williams commented on CASSANDRA-17126: -- Sure! Assigned to you. > Remove use of deprecated Files in tests > --- > > Key: CASSANDRA-17126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17126 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: Brandon Williams >Assignee: Venkata Harikrishna Nukala >Priority: Normal > > From checkstyle: > {noformat} > 5 Illegal import - java.io.File. [IllegalImport] > 3 Illegal import - java.io.FileInputStream. [IllegalImport] > 2 Illegal import - java.io.FileOutputStream. [IllegalImport] > 3 Illegal import - java.io.FileWriter. [IllegalImport] > 16 Illegal import - java.io.RandomAccessFile. [IllegalImport] > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17126) Remove use of deprecated Files in tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459787#comment-17459787 ] Venkata Harikrishna Nukala commented on CASSANDRA-17126: Can I pick it? > Remove use of deprecated Files in tests > --- > > Key: CASSANDRA-17126 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17126 > Project: Cassandra > Issue Type: Sub-task > Components: Test/unit >Reporter: Brandon Williams >Priority: Normal > > From checkstyle: > {noformat} > 5 Illegal import - java.io.File. [IllegalImport] > 3 Illegal import - java.io.FileInputStream. [IllegalImport] > 2 Illegal import - java.io.FileOutputStream. [IllegalImport] > 3 Illegal import - java.io.FileWriter. [IllegalImport] > 16 Illegal import - java.io.RandomAccessFile. [IllegalImport] > {noformat} -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org