[jira] [Commented] (CASSANDRA-17154) Guardrail to disable read-before-write list operations
[
https://issues.apache.org/jira/browse/CASSANDRA-17154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460115#comment-17460115
]
Andres de la Peña commented on CASSANDRA-17154:
---
The proposed PR adds a new guardrails named
{{read_before_write_list_operations_enabled}} that disables setting list
elements by index and removing list elements by either index or value.
||PR||CI||
|[trunk|https://github.com/apache/cassandra/pull/1366]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1212/workflows/752519f8-afa1-4813-a9fd-c8b06211854d]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1212/workflows/7734e98f-93c2-4bbb-993a-7523d9669a94]|
The guardrail itself is quite simple, but getting the {{ClientState}} into the
proper methods in {{Lists}} is a bit noisy.
> Guardrail to disable read-before-write list operations
> --
>
> Key: CASSANDRA-17154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17154
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
>
> Add guardrail to disable list operations implying read-before-write. For
> example:
> {code}
> # Whether read-before-write operation is allowed, eg. setting list element by
> index, removing list element.
> # Defaults to true to allow read before write operations
> read_before_write_list_operations_enabled: true
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17154) Guardrail to disable read-before-write list operations
[
https://issues.apache.org/jira/browse/CASSANDRA-17154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461159#comment-17461159
]
Ekaterina Dimitrova commented on CASSANDRA-17154:
-
It looks good to me, I left only a few tiny formatting suggestions. Rebase and
last CI run and I think it is ready to commit. Thank you :)
> Guardrail to disable read-before-write list operations
> --
>
> Key: CASSANDRA-17154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17154
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add guardrail to disable list operations implying read-before-write. For
> example:
> {code}
> # Whether read-before-write operation is allowed, eg. setting list element by
> index, removing list element.
> # Defaults to true to allow read before write operations
> read_before_write_list_operations_enabled: true
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17154) Guardrail to disable read-before-write list operations
[
https://issues.apache.org/jira/browse/CASSANDRA-17154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461423#comment-17461423
]
Andres de la Peña commented on CASSANDRA-17154:
---
Thanks for reviewing :)
I have addressed the formatting suggestions, rebased and run CI again:
||PR||CI||
|[PR|https://github.com/apache/cassandra/pull/1366]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1221/workflows/1ab46212-639d-40ba-a16e-05e0e3244fda]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1221/workflows/737d6c4a-8396-4b64-8d26-d8611ebf2964]|
> Guardrail to disable read-before-write list operations
> --
>
> Key: CASSANDRA-17154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17154
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add guardrail to disable list operations implying read-before-write. For
> example:
> {code}
> # Whether read-before-write operation is allowed, eg. setting list element by
> index, removing list element.
> # Defaults to true to allow read before write operations
> read_before_write_list_operations_enabled: true
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17154) Guardrail to disable read-before-write list operations
[
https://issues.apache.org/jira/browse/CASSANDRA-17154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461497#comment-17461497
]
Ekaterina Dimitrova commented on CASSANDRA-17154:
-
h4. The patch looks good to me, only known issues from CI:
h4. hintedhandoff_test.TestHintedHandoff.test_hintedhandoff_window -
CASSANDRA-17144, I linked it in Butler too
readWriteDuringBootstrapTest -
org.apache.cassandra.distributed.test.ring.BootstrapTest - CASSANDRA-17139,
also linked it in butler
+1, thank you
> Guardrail to disable read-before-write list operations
> --
>
> Key: CASSANDRA-17154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17154
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add guardrail to disable list operations implying read-before-write. For
> example:
> {code}
> # Whether read-before-write operation is allowed, eg. setting list element by
> index, removing list element.
> # Defaults to true to allow read before write operations
> read_before_write_list_operations_enabled: true
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17154) Guardrail to disable read-before-write list operations
[
https://issues.apache.org/jira/browse/CASSANDRA-17154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461504#comment-17461504
]
Andres de la Peña commented on CASSANDRA-17154:
---
Great, thanks. As for the entry in NEWS.txt, we are going to add around a dozen
on guardrails on this epic, do we want an entry on every single guardrail? I
was thinking on a single entry for all the guardrails once we finish the epic
(CASSANDRA-17146).
> Guardrail to disable read-before-write list operations
> --
>
> Key: CASSANDRA-17154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17154
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add guardrail to disable list operations implying read-before-write. For
> example:
> {code}
> # Whether read-before-write operation is allowed, eg. setting list element by
> index, removing list element.
> # Defaults to true to allow read before write operations
> read_before_write_list_operations_enabled: true
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17154) Guardrail to disable read-before-write list operations
[
https://issues.apache.org/jira/browse/CASSANDRA-17154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461505#comment-17461505
]
Brandon Williams commented on CASSANDRA-17154:
--
I think doing a single entry to cover them all makes the most sense.
> Guardrail to disable read-before-write list operations
> --
>
> Key: CASSANDRA-17154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17154
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add guardrail to disable list operations implying read-before-write. For
> example:
> {code}
> # Whether read-before-write operation is allowed, eg. setting list element by
> index, removing list element.
> # Defaults to true to allow read before write operations
> read_before_write_list_operations_enabled: true
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17154) Guardrail to disable read-before-write list operations
[
https://issues.apache.org/jira/browse/CASSANDRA-17154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461517#comment-17461517
]
Ekaterina Dimitrova commented on CASSANDRA-17154:
-
Agreed, thanks
> Guardrail to disable read-before-write list operations
> --
>
> Key: CASSANDRA-17154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17154
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add guardrail to disable list operations implying read-before-write. For
> example:
> {code}
> # Whether read-before-write operation is allowed, eg. setting list element by
> index, removing list element.
> # Defaults to true to allow read before write operations
> read_before_write_list_operations_enabled: true
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17154) Guardrail to disable read-before-write list operations
[
https://issues.apache.org/jira/browse/CASSANDRA-17154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461565#comment-17461565
]
Andres de la Peña commented on CASSANDRA-17154:
---
Great, I'll add the combined entry in NEWS.txt about the new set of guardrails
when we close the epic.
Committed to trunk as
[95522f85d5e14734f9af3096953974a4f48a884f|https://github.com/apache/cassandra/commit/95522f85d5e14734f9af3096953974a4f48a884f].
Thanks for the review.
> Guardrail to disable read-before-write list operations
> --
>
> Key: CASSANDRA-17154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17154
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Andres de la Peña
>Assignee: Andres de la Peña
>Priority: Normal
> Fix For: 4.1
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add guardrail to disable list operations implying read-before-write. For
> example:
> {code}
> # Whether read-before-write operation is allowed, eg. setting list element by
> index, removing list element.
> # Defaults to true to allow read before write operations
> read_before_write_list_operations_enabled: true
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
