[jira] [Commented] (CASSANDRA-17174) Harden resource management on SSTable components to prevent further leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451937#comment-17451937
]
Josh McKenzie commented on CASSANDRA-17174:
---
Revised, added JVMStabilityInspector check against it, and committed. Thanks!
> Harden resource management on SSTable components to prevent further leaks
> -
>
> Key: CASSANDRA-17174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17174
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/SSTable
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
> Fix For: 4.1
>
>
> We've seen resource leaks pop up w/histogram overflows repeatedly; the code
> in {{BigTableWriter.openEarly()}} and {{BigTableWriter.openFinal()}} doesn't
> appropriately catch and handle any exceptions during creation before things
> are registered with a {{LifecycleTransaction}} so any errors there will leak.
> We should clean that up.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17174) Harden resource management on SSTable components to prevent further leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451350#comment-17451350
]
Caleb Rackliffe commented on CASSANDRA-17174:
-
+1
The only minor question I have is whether we want to catch {{Throwable}}
[here|https://github.com/apache/cassandra/commit/532ee78a11668f6e8206b3060b8626fcc0b524e2#diff-b2d3079f6ed6b50a76ee1ebc12f03cbe59750fc7f6887b08f4175842d0e25b5aR377]
to account for {{Error}} possibly being thrown out of the {{try}} block.
> Harden resource management on SSTable components to prevent further leaks
> -
>
> Key: CASSANDRA-17174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17174
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/SSTable
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
> Fix For: 4.x
>
>
> We've seen resource leaks pop up w/histogram overflows repeatedly; the code
> in {{BigTableWriter.openEarly()}} and {{BigTableWriter.openFinal()}} doesn't
> appropriately catch and handle any exceptions during creation before things
> are registered with a {{LifecycleTransaction}} so any errors there will leak.
> We should clean that up.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17174) Harden resource management on SSTable components to prevent further leaks
[
https://issues.apache.org/jira/browse/CASSANDRA-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17450594#comment-17450594
]
Josh McKenzie commented on CASSANDRA-17174:
---
[Branch|https://github.com/apache/cassandra/commit/532ee78a11668f6e8206b3060b8626fcc0b524e2]
[CI|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/141/workflows/cc872579-850d-4db6-ae6b-e80515898615]
> Harden resource management on SSTable components to prevent further leaks
> -
>
> Key: CASSANDRA-17174
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17174
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/SSTable
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
>
> We've seen resource leaks pop up w/histogram overflows repeatedly; the code
> in {{BigTableWriter.openEarly()}} and {{BigTableWriter.openFinal()}} doesn't
> appropriately catch and handle any exceptions during creation before things
> are registered with a {{LifecycleTransaction}} so any errors there will leak.
> We should clean that up.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
