[jira] [Commented] (CASSANDRA-17225) Add a virtual table for exposing batch metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-17225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490046#comment-17490046
]
Benjamin Lerer commented on CASSANDRA-17225:
[~burmanm] Thanks for your contribution :-)
> Add a virtual table for exposing batch metrics
> --
>
> Key: CASSANDRA-17225
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17225
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables
>Reporter: Benjamin Lerer
>Assignee: Michael Burman
>Priority: Normal
> Labels: AdventCalendar2021, lhf
> Fix For: 4.x
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> There are some existing metrics within BatchMetrics that provide metrics
> about related to the different types of Batches being executed. We should
> expose those through a virtual table.
> +Additional information for newcomers:+
> A new class should be created for representing the new Virtual Table in
> {{org.apache.cassandra.db.virtual}}. You can look at {{ThreadPoolsTable}} for
> an example of virtual table implementation and to {{TableMetricTables}} for
> how Histogram metrics can be exposed. The new table will need to be
> registered in {{SystemViewsKeyspace}}.
> Some unit tests should be added. For some example of virtual table tests you
> can look at {{SystemPropertiesTableTest}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17225) Add a virtual table for exposing batch metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-17225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490030#comment-17490030
]
Benjamin Lerer commented on CASSANDRA-17225:
The patch looks good to me with the addition of [~azotcsit] upon commit.
> Add a virtual table for exposing batch metrics
> --
>
> Key: CASSANDRA-17225
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17225
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables
>Reporter: Benjamin Lerer
>Assignee: Michael Burman
>Priority: Normal
> Labels: AdventCalendar2021, lhf
> Fix For: 4.x
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> There are some existing metrics within BatchMetrics that provide metrics
> about related to the different types of Batches being executed. We should
> expose those through a virtual table.
> +Additional information for newcomers:+
> A new class should be created for representing the new Virtual Table in
> {{org.apache.cassandra.db.virtual}}. You can look at {{ThreadPoolsTable}} for
> an example of virtual table implementation and to {{TableMetricTables}} for
> how Histogram metrics can be exposed. The new table will need to be
> registered in {{SystemViewsKeyspace}}.
> Some unit tests should be added. For some example of virtual table tests you
> can look at {{SystemPropertiesTableTest}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17225) Add a virtual table for exposing batch metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-17225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490028#comment-17490028
]
Benjamin Lerer commented on CASSANDRA-17225:
The CI
[run|https://app.circleci.com/pipelines/github/blerer/cassandra/264/workflows/21f7deb3-a721-424d-b1af-742411616e93]
looks fine. Failures are unrelated.
> Add a virtual table for exposing batch metrics
> --
>
> Key: CASSANDRA-17225
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17225
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables
>Reporter: Benjamin Lerer
>Assignee: Michael Burman
>Priority: Normal
> Labels: AdventCalendar2021, lhf
> Fix For: 4.x
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> There are some existing metrics within BatchMetrics that provide metrics
> about related to the different types of Batches being executed. We should
> expose those through a virtual table.
> +Additional information for newcomers:+
> A new class should be created for representing the new Virtual Table in
> {{org.apache.cassandra.db.virtual}}. You can look at {{ThreadPoolsTable}} for
> an example of virtual table implementation and to {{TableMetricTables}} for
> how Histogram metrics can be exposed. The new table will need to be
> registered in {{SystemViewsKeyspace}}.
> Some unit tests should be added. For some example of virtual table tests you
> can look at {{SystemPropertiesTableTest}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17225) Add a virtual table for exposing batch metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-17225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476300#comment-17476300
]
Ekaterina Dimitrova commented on CASSANDRA-17225:
-
Overall the latest version LGTM. I left only one formatting comment. We need to
add CHANGES.txt and NEW.txt entries but we often do that on commit too.
I can submit full CI run after [~blerer] also approves the latest version.
Thank you for your work [~burmanm] !
> Add a virtual table for exposing batch metrics
> --
>
> Key: CASSANDRA-17225
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17225
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables
>Reporter: Benjamin Lerer
>Assignee: Michael Burman
>Priority: Normal
> Labels: AdventCalendar2021, lhf
> Fix For: 4.x
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> There are some existing metrics within BatchMetrics that provide metrics
> about related to the different types of Batches being executed. We should
> expose those through a virtual table.
> +Additional information for newcomers:+
> A new class should be created for representing the new Virtual Table in
> {{org.apache.cassandra.db.virtual}}. You can look at {{ThreadPoolsTable}} for
> an example of virtual table implementation and to {{TableMetricTables}} for
> how Histogram metrics can be exposed. The new table will need to be
> registered in {{SystemViewsKeyspace}}.
> Some unit tests should be added. For some example of virtual table tests you
> can look at {{SystemPropertiesTableTest}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17225) Add a virtual table for exposing batch metrics
[
https://issues.apache.org/jira/browse/CASSANDRA-17225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470986#comment-17470986
]
Ekaterina Dimitrova commented on CASSANDRA-17225:
-
Hi Michael,
I noticed you added a PR. Is it ready for review or you are still working on
it? Also, please, let me know if you want me to run CI for you?
> Add a virtual table for exposing batch metrics
> --
>
> Key: CASSANDRA-17225
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17225
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Virtual Tables
>Reporter: Benjamin Lerer
>Assignee: Michael Burman
>Priority: Normal
> Labels: AdventCalendar2021, lhf
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are some existing metrics within BatchMetrics that provide metrics
> about related to the different types of Batches being executed. We should
> expose those through a virtual table.
> +Additional information for newcomers:+
> A new class should be created for representing the new Virtual Table in
> {{org.apache.cassandra.db.virtual}}. You can look at {{ThreadPoolsTable}} for
> an example of virtual table implementation and to {{TableMetricTables}} for
> how Histogram metrics can be exposed. The new table will need to be
> registered in {{SystemViewsKeyspace}}.
> Some unit tests should be added. For some example of virtual table tests you
> can look at {{SystemPropertiesTableTest}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
