[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584834#comment-17584834 ] Ekaterina Dimitrova commented on CASSANDRA-17293: - Nothing super urgent, just figured I can run it through you as you already tackled the problem here. Enjoy your vacation! I just opened CASSANDRA-17861 > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1-alpha1, 4.1 > > Time Spent: 10m > Remaining Estimate: 0h > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584554#comment-17584554 ] Brad Schoening commented on CASSANDRA-17293: [~e.dimitrova] the switch to pytest was quite easy. I'm open to helping, but will be on vacation until mid September. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1, 4.1-alpha1 > > Time Spent: 10m > Remaining Estimate: 0h > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17584532#comment-17584532 ] Ekaterina Dimitrova commented on CASSANDRA-17293: - I noticed ccm still uses nose too and I have the same issue trying to run its tests locally. Anyone of you interested to migrate that one to pytest too? :) Those tests do not run in CI and we do not have many ccm changes but it is good people to be able to run them locally before new commits. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1, 4.1-alpha1 > > Time Spent: 10m > Remaining Estimate: 0h > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17499368#comment-17499368 ] Berenguer Blasi commented on CASSANDRA-17293: - These look unrelated to me. Rrandom timeouts are usually an indication of CI env being in bad shape as we can see from the immediate following stream of aborted runs. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1 > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498995#comment-17498995 ] Josh McKenzie commented on CASSANDRA-17293: --- Have a handful of test failures that are showing up for the first time in the past 30 runs on ASF CI infra; don't see how this ticket could be related to them though. [CI Results] Branch: trunk, build number: 970 jenkins url: [https://ci-cassandra.apache.org/job/Cassandra-trunk/970/] JIRA: CASSANDRA-17293 commit url: [https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=ab7ee5001301925495105d8372cd9a8f965da0a6] affected paths: * pylib/cassandra-cqlsh-tests.sh * .gitignore Build Result: UNSTABLE Passing Tests: 45491 Failing Tests: 12 ||Test|Failures|JIRA| |dtest.gossip_test.TestGossip.test_2dc_parallel_startup|1 of 30|CASSANDRA-17366?| |org.apache.cassandra.cql3.validation.operations.SelectTest.testAllowFilteringOnPartitionAndClusteringKey|1 of 30|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496=2252]| |org.apache.cassandra.distributed.test.ring.BootstrapTest.bootstrapTest|2 of 30|CASSANDRA-17139?| |dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X.test_rolling_upgrade_with_internode_ssl|16 of 30|CASSANDRA-17306?| |dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_EndsAt_3_11_X.test_rolling_upgrade|16 of 30|CASSANDRA-17306?| |dtest-novnode.materialized_views_test.TestMaterializedViewsConsistency.test_multi_partition_consistent_reads_after_write|2 of 30|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496=2252]| |dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade|16 of 30|CASSANDRA-17306?| |dtest-upgrade.upgrade_tests.upgrade_through_versions_test.TestProtoV3Upgrade_AllVersions_RandomPartitioner_EndsAt_3_11_X_HEAD.test_rolling_upgrade_with_internode_ssl|16 of 30|CASSANDRA-17306?| |org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testCDCIndexFileWriteOnSync-compression|2 of 30|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496=2252]| |org.apache.cassandra.cql3.KeywordTest.test[keyword FROM isReserved true]|1 of 30|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496=2252]| |dtest.hintedhandoff_test.TestHintedHandoff.test_hintedhandoff_window|1 of 30|CASSANDRA-17144?| |org.apache.cassandra.distributed.test.ring.AutoBootstrapTest.bootstrapTest|1 of 30|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496=2252]| > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1 > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[
https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496335#comment-17496335
]
Stefan Miklosovic commented on CASSANDRA-17293:
---
[~mck] if you look here (1) (that is "new test") it says that there is a test
called "testrun_cqlsh". However, if you look what test_unicode looks like, it
consists of four tests (2).
If you take a look how it look in the code for one of these methods, there is,
for example:
{code}
def test_unicode_value_round_trip(self):
with testrun_cqlsh(tty=True, env=self.default_env) as c:
{code}
Hence, to me, it looks like it will report that "testrun_cqlsh" is also a test
which "passed".
I am not sure how to get rid of this. Maybe we might programmatically remove
that entry from xml, not sure how complicated that would be.
(1)
https://ci-cassandra.apache.org/job/Cassandra-trunk-cqlsh-tests/lastSuccessfulBuild/cython=yes,jdk=jdk_1.8_latest,label=cassandra/testReport/cqlshlib.python3.jdk8.no_cython.test/test_unicode/
(2)
https://ci-cassandra.apache.org/job/Cassandra-trunk-cqlsh-tests/lastSuccessfulBuild/cython=yes,jdk=jdk_1.8_latest,label=cassandra/testReport/cqlshlib.python3.jdk8.no_cython.test.test_unicode/TestCqlshUnicode/
> Update python test framework from nose to pytest
>
>
> Key: CASSANDRA-17293
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17293
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Fix For: 4.1
>
>
> I had trouble trying to install and run the python nose test from pip
> (nosetest not found).
> According to the homepage of nose at [https://nose.readthedocs.io/en/latest/]
> h1. _Note to Users_
> _Nose has been in maintenance mode for the past several years and will likely
> cease without a new person/team to take over maintainership. New projects
> should consider using [Nose2|https://github.com/nose-devs/nose2],
> [py.test|http://pytest.org/], or just plain unittest/unittest2._
>
> Upgrading to pytest is likely the least effort.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496331#comment-17496331 ] Stefan Miklosovic commented on CASSANDRA-17293: --- Wow, seems like it! I ll take a closer look tomorrow. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1 > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496256#comment-17496256 ] Michael Semb Wever commented on CASSANDRA-17293: Thank you [~smiklosovic] for the attention and quick fix. The addition fix looks good to me. One question though… there appears to be four additional tests now, is that intentional? Compare - https://ci-cassandra.apache.org/job/Cassandra-trunk-cqlsh-tests/lastSuccessfulBuild/cython=yes,jdk=jdk_1.8_latest,label=cassandra/testReport/ - https://ci-cassandra.apache.org/job/Cassandra-trunk-cqlsh-tests/1137/cython=yes,jdk=jdk_1.8_latest,label=cassandra/testReport/ These tests appear, where they didn't before… - https://ci-cassandra.apache.org/job/Cassandra-trunk-cqlsh-tests/lastSuccessfulBuild/cython=yes,jdk=jdk_1.8_latest,label=cassandra/testReport/cqlshlib.python3.jdk8.no_cython.test/ Those tests have been around for a while, so it looks like this has fixed something? > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1 > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495739#comment-17495739 ] Brad Schoening commented on CASSANDRA-17293: [~smiklosovic] thank you for correcting that so quickly! > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1 > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495628#comment-17495628 ] Stefan Miklosovic commented on CASSANDRA-17293: --- from (1) you can see that we are putting the output from cqlsh tests back into the report https://ci-cassandra.apache.org/job/Cassandra-devbranch/1438/testReport/ > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1 > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495435#comment-17495435 ] Stefan Miklosovic commented on CASSANDRA-17293: --- Building fix (1) here (2) (1) https://github.com/apache/cassandra/pull/1464 (2) https://ci-cassandra.apache.org/job/Cassandra-devbranch/1437/ > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1 > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495418#comment-17495418 ] Stefan Miklosovic commented on CASSANDRA-17293: --- sorry [~mck], I just looked into this (1) and I saw few flakies so I went ahead. I would rather do a ninja than reverting whole thing. Seems to be just a detail to finish. (1) https://ci-cassandra.apache.org/job/Cassandra-devbranch/1433/ > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1 > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[
https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495254#comment-17495254
]
Brad Schoening commented on CASSANDRA-17293:
cassandra/.jenkins/Jenkinsfile does reference cqlshlib.xml and nosetest.xml,
but the later file did not exit because the prior code in
[cassandra-cqlsh-tests.sh|https://github.com/apache/cassandra/blob/trunk/pylib/cassandra-cqlsh-tests.sh]
renamed it:
mv nosetests.xml ${WORKSPACE}/cqlshlib.xml
How is cassandra_job_dsl_seed.groovy using this? I wasn't aware there was
another repo dependency.
> Update python test framework from nose to pytest
>
>
> Key: CASSANDRA-17293
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17293
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Fix For: 4.1
>
>
> I had trouble trying to install and run the python nose test from pip
> (nosetest not found).
> According to the homepage of nose at [https://nose.readthedocs.io/en/latest/]
> h1. _Note to Users_
> _Nose has been in maintenance mode for the past several years and will likely
> cease without a new person/team to take over maintainership. New projects
> should consider using [Nose2|https://github.com/nose-devs/nose2],
> [py.test|http://pytest.org/], or just plain unittest/unittest2._
>
> Upgrading to pytest is likely the least effort.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495250#comment-17495250 ] Michael Semb Wever commented on CASSANDRA-17293: cqlshlib.xml is still required. It is the test result file, see cassandra-builds/jenkins-dsl/cassandra_job_dsl_seed.groovy and cassandra/.jenkins/Jenkinsfile I recommend reverting the commit while the patch continues to be worked on… > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1 > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495245#comment-17495245 ] Brad Schoening commented on CASSANDRA-17293: It seems ./cassandra-builds/build-scripts/cassandra-test-docker.sh: line 137 is looking to tail [cqlshlib.xml|https://ci-cassandra.apache.org/job/Cassandra-trunk-cqlsh-tests/cython=no,jdk=jdk_1.8_latest,label=cassandra/lastSuccessfulBuild/artifact/cqlshlib.xml] which is no longer generated and should not be needed. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1 > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495242#comment-17495242 ] Michael Semb Wever commented on CASSANDRA-17293: Why was this committed? It failed here in [devbranch|https://ci-cassandra.apache.org/job/Cassandra-devbranch-cqlsh-tests/1285/] and it has now broken [trunk|https://ci-cassandra.apache.org/view/Cassandra%204.1/job/Cassandra-trunk-cqlsh-tests/1138/]. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.1 > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494969#comment-17494969 ] Brandon Williams commented on CASSANDRA-17293: -- I am out for a week but am +1 here if CI looks good. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494882#comment-17494882 ] Brad Schoening commented on CASSANDRA-17293: I've updated this with complete removal of nose, which was just two imports. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494631#comment-17494631 ] Brandon Williams commented on CASSANDRA-17293: -- I've opened CASSANDRA-17393 to remove futures. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494628#comment-17494628 ] Brad Schoening commented on CASSANDRA-17293: This would seem to be a different issue and maybe should be a Jira to remove futures from requirements.txt. The Cassandra requirements.txt states: requirements.txt:# See python driver docs: futures and six have to be installed before requirements.txt:futures And the cassandra-driver states: futures <=2.2.0 # Futures is not required for Python 3, but it works up through 2.2.0 (after which it introduced breaking syntax). # This is left here to make sure install -r works with any runtime. When installing via setup.py, futures is omitted # for Python 3, in favor of the standard library implementation. # see PYTHON-393 https://github.com/datastax/python-driver/blob/master/requirements.txt > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494599#comment-17494599 ] Stefan Miklosovic commented on CASSANDRA-17293: --- trunk is same for me, unless i comment futures out, it fails. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494378#comment-17494378 ] Berenguer Blasi commented on CASSANDRA-17293: - [~smiklosovic] check if you get a clean pass with current trunk? > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494223#comment-17494223 ] Stefan Miklosovic commented on CASSANDRA-17293: --- Nevermind then, I have to have some weird distro then, running on Mint here which is a derivate of Ubuntu ... strange. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494199#comment-17494199 ] Brandon Williams commented on CASSANDRA-17293: -- It's been there 3 years, pip should handle it properly. In any case, not related here. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494195#comment-17494195 ] Stefan Miklosovic commented on CASSANDRA-17293: --- it is as dependency to install here (1) When I commented that out, it passed. (1) https://github.com/apache/cassandra/blob/trunk/pylib/requirements.txt#L4 > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494095#comment-17494095 ] Brandon Williams commented on CASSANDRA-17293: -- For whatever reason your pip is trying to install futures...which is builtin to python 3. Doesn't look related to this ticket. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17494055#comment-17494055 ] Stefan Miklosovic commented on CASSANDRA-17293: --- I tried to test this and this is what I got: https://gist.githubusercontent.com/smiklosovic/9bf6f116c362b246b3cb29ec87523cb4/raw/731aaedccd41cf7ef218f96409f17b74aec10a43/CASSANDRA-17293 python 3.8.10 any ideas? ccm dirs and venv's are deleted before the command execution. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493672#comment-17493672 ] Berenguer Blasi commented on CASSANDRA-17293: - [~brandon.williams] the jenkins run I linked does run the tests indeed as I can see them in the console output. Having said that maybe jenkins was broken in some other way bc your run passes the tests indeed. Weird. Regarding local execution yes, clearing the .ccm folder fixed it :) : 87 passed, 18 warnings in 215.45s (0:03:35) I dropped a comment on the PR about some nose comments that we can remove but otherwise +1. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493475#comment-17493475 ] Brandon Williams commented on CASSANDRA-17293: -- [~bereng] I think your problem locally is you need to clean up '.ccm' from a previous run, the script doesn't do it. The jenkins run you linked is broken in some other way, it says no tests were run so there's nothing to troubleshoot. This passes on circle and it passes for me locally and I've got another jenkins attempt going: [!https://ci-cassandra.apache.org/job/Cassandra-devbranch/1430/badge/icon!|https://ci-cassandra.apache.org/blue/organizations/jenkins/Cassandra-devbranch/detail/Cassandra-devbranch/1430/pipeline] > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[
https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493031#comment-17493031
]
Berenguer Blasi commented on CASSANDRA-17293:
-
Hi,
the failure is legit imo. I can run all tests locally from trunk without a
failure:
{noformat}
nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
test_cql_reserved_keywords (cqlshlib.test.test_constants.TestConstants) ... ok
Test behavior of ExportTask internal get_ranges function ... ok
test_colons_in_string_literals (cqlshlib.test.test_cql_parsing.TestCqlParsing)
... ok
test_comments_in_string_literals
(cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_alter_table (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_batch (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_create_index (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_create_keyspace (cqlshlib.test.test_cql_parsing.TestCqlParsing) ...
ok
test_parse_create_table (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_delete (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_drop_index (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_drop_keyspace (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_drop_table (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_insert (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_numbers (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_pgstring_literals (cqlshlib.test.test_cql_parsing.TestCqlParsing)
... ok
test_parse_select (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_select_token (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_string_literals (cqlshlib.test.test_cql_parsing.TestCqlParsing) ...
ok
test_parse_truncate (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_update (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_use (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_parse_uuid (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_partial_parsing (cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_strip_comment_blocks_from_input
(cqlshlib.test.test_cql_parsing.TestCqlParsing) ... ok
test_complete_command_words
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_alter_keyspace
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_batch
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_create_columnfamily
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_create_keyspace
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_create_table
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_delete
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_describe
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_drop (cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion)
... ok
test_complete_in_drop_keyspace
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_grant
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_insert
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_revoke
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_select
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_string_literals
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_update
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_complete_in_uuid (cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion)
... ok
test_complete_on_empty_string
(cqlshlib.test.test_cqlsh_completion.TestCqlshCompletion) ... ok
test_blob_output (cqlshlib.test.test_cqlsh_output.TestCqlshOutput) ... ok
test_boolean_output (cqlshlib.test.test_cqlsh_output.TestCqlshOutput) ... ok
test_cancel_statement (cqlshlib.test.test_cqlsh_output.TestCqlshOutput) ... ok
test_color_output (cqlshlib.test.test_cqlsh_output.TestCqlshOutput) ... ok
test_columnless_key_output (cqlshlib.test.test_cqlsh_output.TestCqlshOutput)
... ok
test_count_output (cqlshlib.test.test_cqlsh_output.TestCqlshOutput) ... ok
test_describe_cluster_output (cqlshlib.test.test_cqlsh_output.TestCqlshOutput)
... ok
test_describe_columnfamilies_output
(cqlshlib.test.test_cqlsh_output.TestCqlshOutput) ... ok
test_describe_columnfamily_output
(cqlshlib.test.test_cqlsh_output.TestCqlshOutput) ... ok
test_describe_keyspace_output (cqlshlib.test.test_cqlsh_output.TestCqlshOutput)
... ok
test_describe_schema_output (cqlshlib.test.test_cqlsh_output.TestCqlshOutput)
... ok
test_empty_cf_output
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492962#comment-17492962 ] Brandon Williams commented on CASSANDRA-17293: -- [Circle|https://app.circleci.com/pipelines/github/driftx/cassandra/362/workflows/216c1567-9aaa-4a53-b39d-c2ff99a10e37] > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492955#comment-17492955 ] Brad Schoening commented on CASSANDRA-17293: The issue reproducing this was the base directory chosen to run the tests, cassandra/pylib vs cassandra/pylib/cqlshlib. They yield different outputs for test_sslhandling.py depending upon if test/config files for ssl were found or not. A new fix has been checked in, and (fingers crossed) should resolve the test_sslhandling.py failures. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492675#comment-17492675 ] Brandon Williams commented on CASSANDRA-17293: -- I put this through [circle|https://app.circleci.com/pipelines/github/driftx/cassandra/361/workflows/e6dd2c5a-7c3b-4ca3-b2d1-9ed86c739166/jobs/4096] to doublecheck and it fails there as well. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492615#comment-17492615 ] Berenguer Blasi commented on CASSANDRA-17293: - I get: OpenSSL 1.1.1f 31 Mar 2020 > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492595#comment-17492595 ] Brad Schoening commented on CASSANDRA-17293: What version of openssl do you have when testing? % openssl version > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[
https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492419#comment-17492419
]
Berenguer Blasi commented on CASSANDRA-17293:
-
Hi [~bschoeni]
SSL is still failing for me. You mean you cannot repro locally? I am on Ubuntu
20.04, I test with your branch under j8
{noformat}
platform linux -- Python 3.8.10, pytest-7.0.1, pluggy-1.0.0
rootdir: /tmp/cassandra-trunk/pylib
plugins: flaky-3.7.0
collected 87 items
test/test_constants.py .
[ 1%]
test/test_copyutil.py .
[ 2%]
test/test_cql_parsing.py ...
[ 28%]
test/test_cqlsh_completion.py ..
[ 49%]
test/test_cqlsh_output.py ...
[ 89%]
test/test_sslhandling.py .F.F.
[ 95%]
test/test_unicode.py
[100%]
FAILURES
=
_
SslSettingsTest.test_invalid_ssl_version_config
_
self =
def test_invalid_ssl_version_config(self):
> ssl_ret_val = ssl_settings(self.host, os.path.join('test', 'config',
> 'sslhandling_invalid.config'))
test/test_sslhandling.py:72:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
host = , config_file =
'test/config/sslhandling_invalid.config'
env = environ({'SHELL': '/bin/bash', 'QT_ACCESSIBILITY': '1', 'COLORTERM':
'truecolor', 'PYENV_SHELL': 'bash', 'XDG_CONFIG_D..., 'PYTEST_CURRENT_TEST':
'cqlshlib/test/test_sslhandling.py::SslSettingsTest::test_invalid_ssl_version_config
(call)'})
def ssl_settings(host, config_file, env=os.environ):
"""
Function which generates SSL setting for cassandra.Cluster
Params:
* host .: hostname of Cassandra node.
* env ..: environment variables. SSL factory will use, if
passed,
SSL_CERTFILE and SSL_VALIDATE variables.
* config_file ..: path to cqlsh config file (usually ~/.cqlshrc).
SSL factory will use, if set, certfile and validate
options in [ssl] section, as well as host to certfile
mapping in [certfiles] section.
[certfiles] section is optional, 'validate' setting in [ssl] section is
optional too. If validation is enabled then SSL certfile must be
provided
either in the config file or as an environment variable.
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492364#comment-17492364 ] Brad Schoening commented on CASSANDRA-17293: I've found the problem and patched the test_numeric_output issue. I was not able to see test_sslhandling.py fail but changed the code so this failure shouldn't happen (and aligned with CASSANDRA-17365). Please retry. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17492329#comment-17492329 ] Brad Schoening commented on CASSANDRA-17293: I'm checking. What version of the python driver and Cassandra did you test with? It ran cleanly for me locally, but clearly the display width for double is different in my env and then there are the minor TLS version issues. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[
https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491857#comment-17491857
]
Berenguer Blasi commented on CASSANDRA-17293:
-
There are failures for me. Can you doublecheck please?:
{noformat}
platform linux -- Python 3.8.10, pytest-7.0.1, pluggy-1.0.0
rootdir: /tmp/cassandra-trunk/pylib
plugins: flaky-3.7.0
collected 87 items
test/test_constants.py .
[ 1%]
test/test_copyutil.py .
[ 2%]
test/test_cql_parsing.py ...
[ 28%]
test/test_cqlsh_completion.py ..
[ 49%]
test/test_cqlsh_output.py ..F
[ 89%]
test/test_sslhandling.py .F.F.
[ 95%]
test/test_unicode.py
[100%]
FAILURES
=
___
TestCqlshOutput.test_numeric_output
___
self =
def test_numeric_output(self):
> self.assertQueriesGiveColoredOutput((
('''select intcol, bigintcol, varintcol \
from has_all_types \
where num in (0, 1, 2, 3, 4);''', """
intcol | bigintcol| varintcol
MMM M
-+--+-
-12 | 1234567890123456789 | 10
GGG GGG
2147483647 | 9223372036854775807 | 9
GGG GGG
0 |0 | 0
GGG GGG
-2147483648 | -9223372036854775808 | -10
GGG GGG
| |
nnn nnn
(5 rows)
"""),
('''select decimalcol, doublecol, floatcol \
from has_all_types \
where num in (0, 1, 2, 3, 4);''', """
decimalcol | doublecol | floatcol
MM M
--+-+--
19952.11882 | 1 | -2.1
GGG G
[jira] [Commented] (CASSANDRA-17293) Update python test framework from nose to pytest
[ https://issues.apache.org/jira/browse/CASSANDRA-17293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17491233#comment-17491233 ] Brad Schoening commented on CASSANDRA-17293: I first looked at nose2, but nose2 does not fully support nose. But pytest required fewer changes and is a more popular framework, so I've updated it to run with pytest. > Update python test framework from nose to pytest > > > Key: CASSANDRA-17293 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17293 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > I had trouble trying to install and run the python nose test from pip > (nosetest not found). > According to the homepage of nose at [https://nose.readthedocs.io/en/latest/] > h1. _Note to Users_ > _Nose has been in maintenance mode for the past several years and will likely > cease without a new person/team to take over maintainership. New projects > should consider using [Nose2|https://github.com/nose-devs/nose2], > [py.test|http://pytest.org/], or just plain unittest/unittest2._ > > Upgrading to pytest is likely the least effort. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
