[jira] [Commented] (CASSANDRA-17353) Flatten guardrails configuration
[ https://issues.apache.org/jira/browse/CASSANDRA-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489734#comment-17489734 ] Andres de la Peña commented on CASSANDRA-17353: --- Committed to {{trunk}} as [8e1c8f986358aee51dd565a5a2917cb5554ed0c7|https://github.com/apache/cassandra/commit/8e1c8f986358aee51dd565a5a2917cb5554ed0c7]. Thanks for the quick review. > Flatten guardrails configuration > > > Key: CASSANDRA-17353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17353 > Project: Cassandra > Issue Type: Task > Components: Feature/Guardrails >Reporter: Andres de la Peña >Priority: Normal > Fix For: 4.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Modify guardrails configuration at {{cassandra.yaml}} to have a flat format, > instead of the current nested format. This ticket comes from the discussion > around guardrails config on CASSANDRA-17292, CASSANDRA-17188 and > CASSANDRA-17212, and doesn't include any of the other nested properties on > {{cassandra.yaml}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17353) Flatten guardrails configuration
[ https://issues.apache.org/jira/browse/CASSANDRA-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489643#comment-17489643 ] Andres de la Peña commented on CASSANDRA-17353: --- Here is a much better looking CI run after following Ekaterina's advice and using her fixed ccm branch: ||PR||CI|| |[trunk|https://github.com/apache/cassandra/pull/1440]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1290/workflows/ccf7a456-2614-4b84-a3df-0549df6969b0] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1290/workflows/cef70256-7d28-4e89-8011-f5ecfd0c79e4] > Flatten guardrails configuration > > > Key: CASSANDRA-17353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17353 > Project: Cassandra > Issue Type: Task > Components: Feature/Guardrails >Reporter: Andres de la Peña >Priority: Normal > Fix For: 4.x > > Time Spent: 20m > Remaining Estimate: 0h > > Modify guardrails configuration at {{cassandra.yaml}} to have a flat format, > instead of the current nested format. This ticket comes from the discussion > around guardrails config on CASSANDRA-17292, CASSANDRA-17188 and > CASSANDRA-17212, and doesn't include any of the other nested properties on > {{cassandra.yaml}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17353) Flatten guardrails configuration
[ https://issues.apache.org/jira/browse/CASSANDRA-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489489#comment-17489489 ] Andres de la Peña commented on CASSANDRA-17353: --- The recent changes in trunk make it difficult to get a clean CI run, since Circle has problems due to CCM retagging. These runs alternatively hit those issues in j8 or j11: ||CI|| |[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1287/workflows/61ef391d-431c-4a3d-901e-780be96ab204] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1287/workflows/ed5f725d-5988-4ff9-89c3-ac9b45ee1d98]| |[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1288/workflows/b373737c-529e-4a88-891f-36cf565ccb31] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1288/workflows/0ae4e55a-1b4e-4483-9918-d7ee49ee9d99]| |[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1289/workflows/a4298bbf-c43e-459a-953f-96515a2a0a11] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1289/workflows/90a7c3b4-5de5-4edf-895c-5425a40326e3]| We also have [this run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1360/workflows/016168ce-cba1-47b2-986a-cb188959dd51] kindly started by [~e.dimitrova], with [an additional run|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1365/workflows/8e8e9477-ad80-4171-81c3-58a4d1b7775d/jobs/8785/parallel-runs/56?filterBy=ALL] for upgrade tests. I'd say that none of the failures are caused by the proposed changes, and we are ready to commit. > Flatten guardrails configuration > > > Key: CASSANDRA-17353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17353 > Project: Cassandra > Issue Type: Task > Components: Feature/Guardrails >Reporter: Andres de la Peña >Priority: Normal > Fix For: 4.x > > Time Spent: 20m > Remaining Estimate: 0h > > Modify guardrails configuration at {{cassandra.yaml}} to have a flat format, > instead of the current nested format. This ticket comes from the discussion > around guardrails config on CASSANDRA-17292, CASSANDRA-17188 and > CASSANDRA-17212, and doesn't include any of the other nested properties on > {{cassandra.yaml}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17353) Flatten guardrails configuration
[ https://issues.apache.org/jira/browse/CASSANDRA-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488501#comment-17488501 ] David Capwell commented on CASSANDRA-17353: --- +1 the latest commit > Flatten guardrails configuration > > > Key: CASSANDRA-17353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17353 > Project: Cassandra > Issue Type: Task > Components: Feature/Guardrails >Reporter: Andres de la Peña >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Modify guardrails configuration at {{cassandra.yaml}} to have a flat format, > instead of the current nested format. This ticket comes from the discussion > around guardrails config on CASSANDRA-17292, CASSANDRA-17188 and > CASSANDRA-17212, and doesn't include any of the other nested properties on > {{cassandra.yaml}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17353) Flatten guardrails configuration
[ https://issues.apache.org/jira/browse/CASSANDRA-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488376#comment-17488376 ] Andres de la Peña commented on CASSANDRA-17353: --- Just added [a commit|https://github.com/apache/cassandra/pull/1440/commits/2f12c72469ba73a6f9cd4f8f7e3bb44a76e60967] renaming "abort" to "fail". The change is quite noisy but mostly trivial: ||PR||CI|| |[trunk|https://github.com/apache/cassandra/pull/1440]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1283/workflows/d624e34d-dd03-4db5-b8b6-c84d380777bd] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1283/workflows/48eb4c17-55ee-46d8-8c91-41beec84d2bb] > Flatten guardrails configuration > > > Key: CASSANDRA-17353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17353 > Project: Cassandra > Issue Type: Task > Components: Feature/Guardrails >Reporter: Andres de la Peña >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Modify guardrails configuration at {{cassandra.yaml}} to have a flat format, > instead of the current nested format. This ticket comes from the discussion > around guardrails config on CASSANDRA-17292, CASSANDRA-17188 and > CASSANDRA-17212, and doesn't include any of the other nested properties on > {{cassandra.yaml}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17353) Flatten guardrails configuration
[ https://issues.apache.org/jira/browse/CASSANDRA-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488331#comment-17488331 ] David Capwell commented on CASSANDRA-17353: --- +1 from me. I am ok renaming abort to fail in this patch or not. > Flatten guardrails configuration > > > Key: CASSANDRA-17353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17353 > Project: Cassandra > Issue Type: Task > Components: Feature/Guardrails >Reporter: Andres de la Peña >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Modify guardrails configuration at {{cassandra.yaml}} to have a flat format, > instead of the current nested format. This ticket comes from the discussion > around guardrails config on CASSANDRA-17292, CASSANDRA-17188 and > CASSANDRA-17212, and doesn't include any of the other nested properties on > {{cassandra.yaml}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17353) Flatten guardrails configuration
[ https://issues.apache.org/jira/browse/CASSANDRA-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488304#comment-17488304 ] Ekaterina Dimitrova commented on CASSANDRA-17353: - No worries, there were too many discussions and venues for them lately. I am absolutely fine to do it myself in follow up ticket, I also ended up not changing the track warnings as it seems they might be even moved to JMX (maybe? I just saw somewhere discussions on that). Just pointing it for the future. Thanks :) > Flatten guardrails configuration > > > Key: CASSANDRA-17353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17353 > Project: Cassandra > Issue Type: Task > Components: Feature/Guardrails >Reporter: Andres de la Peña >Priority: Normal > Fix For: 4.x > > > Modify guardrails configuration at {{cassandra.yaml}} to have a flat format, > instead of the current nested format. This ticket comes from the discussion > around guardrails config on CASSANDRA-17292, CASSANDRA-17188 and > CASSANDRA-17212, and doesn't include any of the other nested properties on > {{cassandra.yaml}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17353) Flatten guardrails configuration
[ https://issues.apache.org/jira/browse/CASSANDRA-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488301#comment-17488301 ] Andres de la Peña commented on CASSANDRA-17353: --- Oh, I missed that one. Guardrails were initially proposed with "fail" instead of "abort", we changed to "abort" during the review of CASSANDRA-17147. If we have agreed on consistently using "fail", this ticket seems a good place to update that on guardrails config, I'll do it in a bit. > Flatten guardrails configuration > > > Key: CASSANDRA-17353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17353 > Project: Cassandra > Issue Type: Task > Components: Feature/Guardrails >Reporter: Andres de la Peña >Priority: Normal > Fix For: 4.x > > > Modify guardrails configuration at {{cassandra.yaml}} to have a flat format, > instead of the current nested format. This ticket comes from the discussion > around guardrails config on CASSANDRA-17292, CASSANDRA-17188 and > CASSANDRA-17212, and doesn't include any of the other nested properties on > {{cassandra.yaml}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17353) Flatten guardrails configuration
[ https://issues.apache.org/jira/browse/CASSANDRA-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488282#comment-17488282 ] Ekaterina Dimitrova commented on CASSANDRA-17353: - [~adelapena] , thank you for all your work, not a review, but I just wanted to mention that on 15234 we agreed last week to use "fail" instead of "abort" for config. I agreed this change to be done in a follow up ticket as the patch was already super big. I can open a follow up ticket after you to change that but wanted to mention it for next guardrails you work on. Also, it will be in the docs I work on already. > Flatten guardrails configuration > > > Key: CASSANDRA-17353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17353 > Project: Cassandra > Issue Type: Task > Components: Feature/Guardrails >Reporter: Andres de la Peña >Priority: Normal > Fix For: 4.x > > > Modify guardrails configuration at {{cassandra.yaml}} to have a flat format, > instead of the current nested format. This ticket comes from the discussion > around guardrails config on CASSANDRA-17292, CASSANDRA-17188 and > CASSANDRA-17212, and doesn't include any of the other nested properties on > {{cassandra.yaml}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17353) Flatten guardrails configuration
[ https://issues.apache.org/jira/browse/CASSANDRA-17353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488279#comment-17488279 ] Andres de la Peña commented on CASSANDRA-17353: --- Here is the patch flattening the configuration for guardrails, CI is still running: ||PR||CI|| |[trunk|https://github.com/apache/cassandra/pull/1440]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1282/workflows/55a06910-8ede-4699-9d81-cd6e50fd00c4] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1282/workflows/2f54901b-4328-4097-ba4d-1ac217f94fd2]| CC [~dcapwell] [~maedhroz] > Flatten guardrails configuration > > > Key: CASSANDRA-17353 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17353 > Project: Cassandra > Issue Type: Task > Components: Feature/Guardrails >Reporter: Andres de la Peña >Priority: Normal > > Modify guardrails configuration at {{cassandra.yaml}} to have a flat format, > instead of the current nested format. This ticket comes from the discussion > around guardrails config on CASSANDRA-17292, CASSANDRA-17188 and > CASSANDRA-17212, and doesn't include any of the other nested properties on > {{cassandra.yaml}}. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org