[jira] [Commented] (CASSANDRA-17413) Remove unused imports
[ https://issues.apache.org/jira/browse/CASSANDRA-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502796#comment-17502796 ] Stefan Miklosovic commented on CASSANDRA-17413: --- https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1478 > Remove unused imports > - > > Key: CASSANDRA-17413 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17413 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > Python3 no longer requires the import of unicode_literals from futures. This > and a few other unused imports, should be removed. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17413) Remove unused imports
[ https://issues.apache.org/jira/browse/CASSANDRA-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501343#comment-17501343 ] Stefan Miklosovic commented on CASSANDRA-17413: --- I fixed it, I am just trying to get a nice Jenkins build. Low on diskspace again. > Remove unused imports > - > > Key: CASSANDRA-17413 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17413 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > Python3 no longer requires the import of unicode_literals from futures. This > and a few other unused imports, should be removed. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17413) Remove unused imports
[
https://issues.apache.org/jira/browse/CASSANDRA-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501241#comment-17501241
]
Stefan Miklosovic commented on CASSANDRA-17413:
---
the tests are failing for me:
{code}
self =
def test_timestamp_output(self):
env = self.default_env
env['TZ'] = 'Etc/UTC'
self.assertQueriesGiveColoredOutput((
('''select timestampcol from has_all_types where num = 0;''', """
timestampcol
-
2012-05-14 12:53:20.00+
GGG
(1 rows)
"""),
), env=env)
try:
env['TZ'] = 'America/Sao_Paulo'
> self.assertQueriesGiveColoredOutput((
('''select timestampcol from has_all_types where num = 0;''',
"""
timestampcol
-
2012-05-14 09:53:20.00-0300
GGG
(1 rows)
"""),
), env=env)
test/test_cqlsh_output.py:406:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _
test/test_cqlsh_output.py:100: in assertQueriesGiveColoredOutput
self.assertEqual(outputline.plain().rstrip(), plain)
E AssertionError: ' 2012-05-14 12:53:20.00+' != ' 2012-05-14
09:53:20.00-0300'
E - 2012-05-14 12:53:20.00+
E ? ^^ ^ ^
E + 2012-05-14 09:53:20.00-0300
E ? ^^ ^ ^
=
warnings summary
=
test/run_cqlsh.py:33
{code}
> Remove unused imports
> -
>
> Key: CASSANDRA-17413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17413
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Fix For: 4.x
>
>
> Python3 no longer requires the import of unicode_literals from futures. This
> and a few other unused imports, should be removed.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17413) Remove unused imports
[ https://issues.apache.org/jira/browse/CASSANDRA-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501074#comment-17501074 ] Brandon Williams commented on CASSANDRA-17413: -- I think we should leave the rest to different tickets, there's no need to block this one. > Remove unused imports > - > > Key: CASSANDRA-17413 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17413 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > Python3 no longer requires the import of unicode_literals from futures. This > and a few other unused imports, should be removed. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17413) Remove unused imports
[ https://issues.apache.org/jira/browse/CASSANDRA-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501066#comment-17501066 ] Brad Schoening commented on CASSANDRA-17413: [~smiklosovic] sure thing, I've fixed most of the above. Resolving profile_on/off and timedelta require some more careful consideration but we're down to 4 issues with pyflake now. Note that PyCharm flags dozens more problems. > Remove unused imports > - > > Key: CASSANDRA-17413 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17413 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > Python3 no longer requires the import of unicode_literals from futures. This > and a few other unused imports, should be removed. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17413) Remove unused imports
[
https://issues.apache.org/jira/browse/CASSANDRA-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500917#comment-17500917
]
Stefan Miklosovic commented on CASSANDRA-17413:
---
[~bschoeni]
could you spend more time on this, please? I used "pyflakes" (installed by pip)
against the sources and this is what I got:
{code}
$ pyflakes .
./copyutil.py:53:1 'cassandra.cqltypes.BytesType' imported but unused
./copyutil.py:58:1 redefinition of unused 'profile_on' from line 44
./copyutil.py:58:1 redefinition of unused 'profile_off' from line 44
./copyutil.py:204:30 undefined name 'errno'
./tracing.py:17:1 'datetime.timedelta' imported but unused
./cqlhandling.py:118:13 local variable 'str_token' is assigned to but never used
./test/test_cqlsh_output.py:405:13 'pytz' imported but unused
./test/ansi_colors.py:153:9 local variable 'oldclr' is assigned to but never
used
./test/__init__.py:17:1 '.cassconnect.create_db' imported but unused
./test/__init__.py:17:1 '.cassconnect.remove_db' imported but unused
{code}
this is against cqlsh.py
{code}
$ pyflakes cqlsh.py
cqlsh.py:141:1 'cassandra.metadata.protect_name' imported but unused
cqlsh.py:141:1 'cassandra.metadata.protect_names' imported but unused
cqlsh.py:153:1 'cqlshlib.cqlhandling' imported but unused
cqlsh.py:157:1 'cqlshlib.formatting.formatter_for' imported but unused
cqlsh.py:161:1 'cqlshlib.util.trim_if_present' imported but unused
cqlsh.py:259:17 '...'.format(...) has unused arguments at position(s): 0, 1
{code}
Would be nice if we took more in-depth approach here!
> Remove unused imports
> -
>
> Key: CASSANDRA-17413
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17413
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Interpreter
>Reporter: Brad Schoening
>Assignee: Brad Schoening
>Priority: Normal
> Fix For: 4.x
>
>
> Python3 no longer requires the import of unicode_literals from futures. This
> and a few other unused imports, should be removed.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17413) Remove unused imports
[ https://issues.apache.org/jira/browse/CASSANDRA-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500878#comment-17500878 ] Stefan Miklosovic commented on CASSANDRA-17413: --- [~bschoeni] could you double check this whole import is useless there? It seems like it is not only about unicode_literals but two other imports are not used anywhere ... from __future__ import division, unicode_literals, print_function > Remove unused imports > - > > Key: CASSANDRA-17413 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17413 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > Python3 no longer requires the import of unicode_literals from futures. This > and a few other unused imports, should be removed. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17413) Remove unused imports
[ https://issues.apache.org/jira/browse/CASSANDRA-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500861#comment-17500861 ] Brad Schoening commented on CASSANDRA-17413: I should include bin/cqlsh.py also > Remove unused imports > - > > Key: CASSANDRA-17413 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17413 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > Python3 no longer requires the import of unicode_literals from futures. This > and a few other unused imports, should be removed. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17413) Remove unused imports
[ https://issues.apache.org/jira/browse/CASSANDRA-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500860#comment-17500860 ] Brandon Williams commented on CASSANDRA-17413: -- +1 > Remove unused imports > - > > Key: CASSANDRA-17413 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17413 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > Python3 no longer requires the import of unicode_literals from futures. This > and a few other unused imports, should be removed. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17413) Remove unused imports
[ https://issues.apache.org/jira/browse/CASSANDRA-17413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500851#comment-17500851 ] Stefan Miklosovic commented on CASSANDRA-17413: --- [https://app.circleci.com/pipelines/github/instaclustr/cassandra/777/workflows/544b0994-210c-4523-a478-42a8c46894a1] https://github.com/instaclustr/cassandra/tree/CASSANDRA-17413 > Remove unused imports > - > > Key: CASSANDRA-17413 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17413 > Project: Cassandra > Issue Type: Task > Components: CQL/Interpreter >Reporter: Brad Schoening >Assignee: Brad Schoening >Priority: Normal > Fix For: 4.x > > > Python3 no longer requires the import of unicode_literals from futures. This > and a few other unused imports, should be removed. > -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
