[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511957#comment-17511957 ] Brandon Williams commented on CASSANDRA-17448: -- Left a comment on the PR that can be addressed on commit, CI looks good. +1 > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511641#comment-17511641 ] Stefan Miklosovic commented on CASSANDRA-17448: --- [~brandon.williams] I think this is way better https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1537/ > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511254#comment-17511254 ] Berenguer Blasi commented on CASSANDRA-17448: - Jenkins might be running out of space or similar bc all the latest runs look horrible. > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511250#comment-17511250 ] Stefan Miklosovic commented on CASSANDRA-17448: --- Yeah I am thinking the same ... lets give it another shot. > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511211#comment-17511211 ] Brandon Williams commented on CASSANDRA-17448: -- That run has a lot of failures that are probably just noise but we should check again. > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511209#comment-17511209 ] Stefan Miklosovic commented on CASSANDRA-17448: --- https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/1531 > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510695#comment-17510695 ] Brandon Williams commented on CASSANDRA-17448: -- bq. I am building it as we speak, will put it here later. Well, that is part of the review. > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510691#comment-17510691 ] Stefan Miklosovic commented on CASSANDRA-17448: --- [~brandon.williams] would you mind to review? Same PR [https://github.com/apache/cassandra/pull/1508/files] I am building it as we speak, will put it here later. > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510134#comment-17510134 ] Brandon Williams commented on CASSANDRA-17448: -- bq. So it tells that if cqlshrc is not set, it will take the directory of history dir as parent The history dir at that point in time will be ~/.cassandra, so it's just using the variable for convenience there. bq. I would say if it is not set on the command line, we will always use "~/.cassandra" no matter what and we "decouple" from history dir stuff completely. Yes, exactly. > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510118#comment-17510118 ] Stefan Miklosovic commented on CASSANDRA-17448: --- [~brandon.williams] this is interesting check it out (1) So it tells that if cqlshrc is not set, it will take the directory of history dir as parent and it will look for cqlshrc there. Now if we allow CQL_HISTORY to be /dev/null, based on this logic, it would start to look for cqlshr in /dev/ which does not make sense. Any ideas what is the ideal approach here? (1) https://github.com/apache/cassandra/blob/trunk/bin/cqlsh.py#L224-L232 > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509067#comment-17509067 ] Brandon Williams commented on CASSANDRA-17448: -- Or better yet always write it and users can point it at /dev/null. > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509031#comment-17509031 ] Brandon Williams commented on CASSANDRA-17448: -- If the var is set to empty, do not write history. If the var is completely unset, preserve the current behavior. > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509029#comment-17509029 ] Stefan Miklosovic commented on CASSANDRA-17448: --- [~brandon.williams] I dont think this is a good idea. Hear me out please. Currently, users do not set this variable (CQL_HISTORY) and CQL history written to cqlsh_history file. If we control wether history should be written to a file or not, from 4.1 onwards, effectively, users will not have any history persisted without setting that variable first. So we go from "by default writing history" to "by default do not write history". Is this really something we want? I think it is pretty inconvenient to suddenly not have history written. > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508902#comment-17508902 ] Brandon Williams commented on CASSANDRA-17448: -- I think there are too many ways to do things here, leading to the override. Instead, if we're going to respect the CQL_HISTORY env variable let's just use that, and if set to empty consider that as the signal to not store history. > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17448) allow users to change cqlsh history location using env variable
[ https://issues.apache.org/jira/browse/CASSANDRA-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508284#comment-17508284 ] Stefan Miklosovic commented on CASSANDRA-17448: --- PSQL has PSQL_HISTORY which is file https://www.postgresql.org/docs/9.2/app-psql.html The current patch the user sent (1) is setting CQL_HISTORY to a directory to which "cqlsh_history" file is appended so in fact the history is written to $CQL_HISTORY/cqlsh_history which is quite missleading. I would expect that CQL_HISTORY will lead to a file, not directory. I am trying to modify the patch in such a way that CQL_HISTORY is file, not dir. (1) https://github.com/apache/cassandra/pull/672 > allow users to change cqlsh history location using env variable > --- > > Key: CASSANDRA-17448 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17448 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 4.1 > > > User on GH sent: > I just started using cassandra and found that it creates history folder in my > home directory. I personally don't like it and all my folders follow XDG > standard. I found stackoverflow question related to it which says that it's > not possible to do without configuring source code of cqlsh.py. > In this pull request I added a feature to choose history directory using > environment variable. The name of variable is CQL_HISTORY. Why ? Because > postgres and node-repl use approximately the same convention > (NODE_REPL_HISTORY,PSQL_HISTORY). If you want I can change the name. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
