[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541657#comment-17541657 ] Andres de la Peña commented on CASSANDRA-17509: --- I forgot about that failure, and I can't find any ticket for it. The failure can be reproduced on the CircleCI's multiplexer for both 4.1 and trunk, although I think we haven't seen it yet on Jenkins. I have created CASSANDRA-17658 for fixing it. > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.1 > > Time Spent: 1.5h > Remaining Estimate: 0h > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17537877#comment-17537877 ] Ekaterina Dimitrova commented on CASSANDRA-17509: - I just saw testMetricsCleanupOnDrop in my runs, was there a ticket opened or should I open? (wasn't sure whether there is not some umbrella ticket or anything that I am missing) > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Fix For: 4.1 > > Time Spent: 1.5h > Remaining Estimate: 0h > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521365#comment-17521365 ] Josh McKenzie commented on CASSANDRA-17509: --- bq. we should probably create tickets for them. Agree; I ran a clean (i.e. vanilla trunk) circle run earlier today as a reference and am planning on getting together a focused effort to get us to stable green there in the run up to the freeze. I'll make sure failures from here make it to that effort. > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Time Spent: 1h 20m > Remaining Estimate: 0h > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521237#comment-17521237 ] Andres de la Peña commented on CASSANDRA-17509: --- The failures at [testMetricsCleanupOnDrop|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1977] and [testConnectionsAreRejectedWithInvalidConfig|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851/jobs/1983] in the runs above don't seem related to the changes, so I think the results look good. Those tests failures don't appear on [Butler|https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-trunk/trunk] though, and I haven't found tickets for them, so we should probably create tickets for them. > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Time Spent: 1h 20m > Remaining Estimate: 0h > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520716#comment-17520716 ] Josh McKenzie commented on CASSANDRA-17509: --- Had a rebase w/clean run last Friday; went ahead and did one final one this morning and CI kicked off. [JDK8 CI|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/2cbb5465-a970-440b-a502-06e380ce6851] [JDK11 CI|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/211/workflows/abb10877-f285-49b4-9d44-fb852fb8a584] > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Time Spent: 1h 20m > Remaining Estimate: 0h > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519487#comment-17519487 ] Andres de la Peña commented on CASSANDRA-17509: --- Looks good to me, we only need a rebase fixing the (trivial) conflicts with the recently added guardrails and a final CI round. > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Time Spent: 1h 10m > Remaining Estimate: 0h > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519262#comment-17519262 ] David Capwell commented on CASSANDRA-17509: --- latest changes LGTM > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Time Spent: 1h 10m > Remaining Estimate: 0h > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519043#comment-17519043 ] Josh McKenzie commented on CASSANDRA-17509: --- Added the couple extra tests and tweaked the query so we didn't need to differentiate warning type on query results and force pushed. We good to go here [~adelapena]? > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Time Spent: 1h 10m > Remaining Estimate: 0h > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518847#comment-17518847 ] Stefan Miklosovic commented on CASSANDRA-17509: --- yes, I think you are right, thanks for testing that. Please add that test there. > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Time Spent: 0.5h > Remaining Estimate: 0h > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[
https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518806#comment-17518806
]
Andres de la Peña commented on CASSANDRA-17509:
---
[~smiklosovic] I might be wrong but I think that {{View#getSelectStatement()}}
is only used by internal queries to get the query used on the {{CREATE VIEW}}
query to populate the MV table from the base table contents. I think that query
never supports {{{}GROUP BY{}}}. The path for querying MVs seems to work as
expected:
{code:java}
@Test
public void checkView() throws Throwable
{
setGuardrail(false);
createTable( "CREATE TABLE %s(pk int, ck int, v int, PRIMARY KEY(pk, ck))");
String viewName = createView("CREATE MATERIALIZED VIEW %s AS " +
"SELECT * FROM %s WHERE pk IS NOT null and ck
IS NOT null " +
"PRIMARY KEY(ck, pk)");
String viewQuery = "SELECT * FROM " + viewName + " WHERE ck=0 GROUP BY pk";
assertFails(viewQuery, "GROUP BY functionality");
testExcludedUsers(() -> viewQuery);
} {code}
> Add Guardrail to disable GROUP BY functionality
> ---
>
> Key: CASSANDRA-17509
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17509
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
>Reporter: Josh McKenzie
>Assignee: Josh McKenzie
>Priority: Normal
> Time Spent: 20m
> Remaining Estimate: 0h
>
> GROUP BY can be expensive and troublesome on large tables. We should have a
> guardrail to disable this in clusters where we don't want users to have this
> functionality.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518509#comment-17518509 ] Stefan Miklosovic commented on CASSANDRA-17509: --- SelectStatement#prepare(boolean forView) is called from View#getSelectStatement() but once that code path is executed, SelectStatement#prepare(ClientState state) is not called. I would say there is a need to propagate ClientState to SelectStatement#prepare(boolean forView) > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518480#comment-17518480 ] David Capwell commented on CASSANDRA-17509: --- Patch LGTM, I left small comments mostly about "is" vs "get" in MBeans/Interfaces... I see that we use "get" already, but this is actually incorrect... so think we should also fix (100% cool not in this patch, I accept consistency here over correctness) > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17509) Add Guardrail to disable GROUP BY functionality
[ https://issues.apache.org/jira/browse/CASSANDRA-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515528#comment-17515528 ] Josh McKenzie commented on CASSANDRA-17509: --- [PR|https://github.com/apache/cassandra/pull/1543] [JDK8 CI|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/199/workflows/94525b46-3917-428f-bf96-f8671b1a7ac3] [JDK11 CI|https://app.circleci.com/pipelines/github/josh-mckenzie/cassandra/199/workflows/df58d46d-cf06-4f00-869c-0f1a8752f1c6] > Add Guardrail to disable GROUP BY functionality > --- > > Key: CASSANDRA-17509 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17509 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails >Reporter: Josh McKenzie >Assignee: Josh McKenzie >Priority: Normal > > GROUP BY can be expensive and troublesome on large tables. We should have a > guardrail to disable this in clusters where we don't want users to have this > functionality. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
