[jira] [Commented] (CASSANDRA-17537) nodetool compact should support using a key string to find the range to avoid operators having to manually do this
[ https://issues.apache.org/jira/browse/CASSANDRA-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519169#comment-17519169 ] Brandon Williams commented on CASSANDRA-17537: -- We should probably accept the same syntax (for compound keys) as getendpoints currently does. > nodetool compact should support using a key string to find the range to avoid > operators having to manually do this > -- > > Key: CASSANDRA-17537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17537 > Project: Cassandra > Issue Type: New Feature > Components: Local/Compaction, Tool/nodetool >Reporter: David Capwell >Priority: Normal > > Its common that a single key needs to be compact, and operators need to do > the following > 1) go from key -> token > 2) generate range > 3) call nodetool compact with this range > We can simply this workflow by adding this to compact > nodetool compact ks.tbl -k “key1" -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17537) nodetool compact should support using a key string to find the range to avoid operators having to manually do this
[
https://issues.apache.org/jira/browse/CASSANDRA-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519185#comment-17519185
]
David Capwell commented on CASSANDRA-17537:
---
Thanks for calling out, to anyone who takes this, [~brandon.williams] comment
is implemented in
org.apache.cassandra.service.StorageService#getNaturalReplicasForToken(java.lang.String,
java.lang.String, java.lang.String)
{code}
TableMetadata metadata = ksMetaData.getTableOrViewNullable(cf);
return getNaturalReplicasForToken(keyspaceName,
metadata.partitionKeyType.fromString(key));
{code}
Aka, it would be good to reuse the syntax from the partition key's type
> nodetool compact should support using a key string to find the range to avoid
> operators having to manually do this
> --
>
> Key: CASSANDRA-17537
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17537
> Project: Cassandra
> Issue Type: New Feature
> Components: Local/Compaction, Tool/nodetool
>Reporter: David Capwell
>Priority: Normal
>
> Its common that a single key needs to be compact, and operators need to do
> the following
> 1) go from key -> token
> 2) generate range
> 3) call nodetool compact with this range
> We can simply this workflow by adding this to compact
> nodetool compact ks.tbl -k “key1"
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17537) nodetool compact should support using a key string to find the range to avoid operators having to manually do this
[ https://issues.apache.org/jira/browse/CASSANDRA-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525323#comment-17525323 ] David Capwell commented on CASSANDRA-17537: --- pushed feedback [~marcuse] > nodetool compact should support using a key string to find the range to avoid > operators having to manually do this > -- > > Key: CASSANDRA-17537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17537 > Project: Cassandra > Issue Type: New Feature > Components: Local/Compaction, Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Time Spent: 40m > Remaining Estimate: 0h > > Its common that a single key needs to be compact, and operators need to do > the following > 1) go from key -> token > 2) generate range > 3) call nodetool compact with this range > We can simply this workflow by adding this to compact > nodetool compact ks.tbl -k “key1" -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17537) nodetool compact should support using a key string to find the range to avoid operators having to manually do this
[ https://issues.apache.org/jira/browse/CASSANDRA-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525442#comment-17525442 ] Marcus Eriksson commented on CASSANDRA-17537: - +1 > nodetool compact should support using a key string to find the range to avoid > operators having to manually do this > -- > > Key: CASSANDRA-17537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17537 > Project: Cassandra > Issue Type: New Feature > Components: Local/Compaction, Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Time Spent: 50m > Remaining Estimate: 0h > > Its common that a single key needs to be compact, and operators need to do > the following > 1) go from key -> token > 2) generate range > 3) call nodetool compact with this range > We can simply this workflow by adding this to compact > nodetool compact ks.tbl -k “key1" -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17537) nodetool compact should support using a key string to find the range to avoid operators having to manually do this
[ https://issues.apache.org/jira/browse/CASSANDRA-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526100#comment-17526100 ] David Capwell commented on CASSANDRA-17537: --- Starting commit CI Results (pending): ||Branch||Source||Circle CI||Jenkins|| |trunk|[branch|https://github.com/dcapwell/cassandra/tree/commit_remote_branch/CASSANDRA-17537-trunk-A80909E5-5C23-42D0-A279-AFF09B8E92A0]|[build|https://app.circleci.com/pipelines/github/dcapwell/cassandra?branch=commit_remote_branch%2FCASSANDRA-17537-trunk-A80909E5-5C23-42D0-A279-AFF09B8E92A0]|[build|https://ci-cassandra.apache.org/job/Cassandra-devbranch/1625/]| > nodetool compact should support using a key string to find the range to avoid > operators having to manually do this > -- > > Key: CASSANDRA-17537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17537 > Project: Cassandra > Issue Type: New Feature > Components: Local/Compaction, Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Time Spent: 1h > Remaining Estimate: 0h > > Its common that a single key needs to be compact, and operators need to do > the following > 1) go from key -> token > 2) generate range > 3) call nodetool compact with this range > We can simply this workflow by adding this to compact > nodetool compact ks.tbl -k “key1" -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17537) nodetool compact should support using a key string to find the range to avoid operators having to manually do this
[
https://issues.apache.org/jira/browse/CASSANDRA-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526107#comment-17526107
]
David Capwell commented on CASSANDRA-17537:
---
ok so that new assert breaks things, so canceling the commit
https://app.circleci.com/pipelines/github/dcapwell/cassandra/1389/workflows/b987634e-a680-4b3f-bee7-e7e11e8e4b29/jobs/11372
{code}
Attempted to force compact
[BigTableReader(path='/tmp/cassandra/build/test/cassandra/data/LeveledCompactionStrategyTest/StandardLeveled-4892b7b0c1bc11ecbcb76d3ce7d88979/nb-226-big-Data.db'),
BigTableReader(path='/tmp/cassandra/build/test/cassandra/data/LeveledCompactionStrategyTest/StandardLeveled-4892b7b0c1bc11ecbcb76d3ce7d88979/nb-216-big-Data.db'),
BigTableReader(path='/tmp/cassandra/build/test/cassandra/data/LeveledCompactionStrategyTest/StandardLeveled-4892b7b0c1bc11ecbcb76d3ce7d88979/nb-214-big-Data.db'),
BigTableReader(path='/tmp/cassandra/build/test/cassandra/data/LeveledCompactionStrategyTest/StandardLeveled-4892b7b0c1bc11ecbcb76d3ce7d88979/nb-228-big-Data.db'),
BigTableReader(path='/tmp/cassandra/build/test/cassandra/data/LeveledCompactionStrategyTest/StandardLeveled-4892b7b0c1bc11ecbcb76d3ce7d88979/nb-218-big-Data.db'),
BigTableReader(path='/tmp/cassandra/build/test/cassandra/data/LeveledCompactionStrategyTest/StandardLeveled-4892b7b0c1bc11ecbcb76d3ce7d88979/nb-224-big-Data.db'),
BigTableReader(path='/tmp/cassandra/build/test/cassandra/data/LeveledCompactionStrategyTest/StandardLeveled-4892b7b0c1bc11ecbcb76d3ce7d88979/nb-222-big-Data.db'),
BigTableReader(path='/tmp/cassandra/build/test/cassandra/data/LeveledCompactionStrategyTest/StandardLeveled-4892b7b0c1bc11ecbcb76d3ce7d88979/nb-220-big-Data.db'),
BigTableReader(path='/tmp/cassandra/build/test/cassandra/data/LeveledCompactionStrategyTest/StandardLeveled-4892b7b0c1bc11ecbcb76d3ce7d88979/nb-210-big-Data.db'),
BigTableReader(path='/tmp/cassandra/build/test/cassandra/data/LeveledCompactionStrategyTest/StandardLeveled-4892b7b0c1bc11ecbcb76d3ce7d88979/nb-212-big-Data.db')],
but predicate does not include
{code}
> nodetool compact should support using a key string to find the range to avoid
> operators having to manually do this
> --
>
> Key: CASSANDRA-17537
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17537
> Project: Cassandra
> Issue Type: New Feature
> Components: Local/Compaction, Tool/nodetool
>Reporter: David Capwell
>Assignee: David Capwell
>Priority: Normal
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Its common that a single key needs to be compact, and operators need to do
> the following
> 1) go from key -> token
> 2) generate range
> 3) call nodetool compact with this range
> We can simply this workflow by adding this to compact
> nodetool compact ks.tbl -k “key1"
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17537) nodetool compact should support using a key string to find the range to avoid operators having to manually do this
[ https://issues.apache.org/jira/browse/CASSANDRA-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526671#comment-17526671 ] David Capwell commented on CASSANDRA-17537: --- spoke with [~marcuse] and looks like sstablesInBounds is returning SSTables not within the range, which causes the above to fail; filing a different ticket for this and removed the assert from this block > nodetool compact should support using a key string to find the range to avoid > operators having to manually do this > -- > > Key: CASSANDRA-17537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17537 > Project: Cassandra > Issue Type: New Feature > Components: Local/Compaction, Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Time Spent: 1h 10m > Remaining Estimate: 0h > > Its common that a single key needs to be compact, and operators need to do > the following > 1) go from key -> token > 2) generate range > 3) call nodetool compact with this range > We can simply this workflow by adding this to compact > nodetool compact ks.tbl -k “key1" -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17537) nodetool compact should support using a key string to find the range to avoid operators having to manually do this
[ https://issues.apache.org/jira/browse/CASSANDRA-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526701#comment-17526701 ] David Capwell commented on CASSANDRA-17537: --- CI was clean other than org.apache.cassandra.net.ConnectionTest, rerunning locally as I think its just flaky... if passes will merge > nodetool compact should support using a key string to find the range to avoid > operators having to manually do this > -- > > Key: CASSANDRA-17537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17537 > Project: Cassandra > Issue Type: New Feature > Components: Local/Compaction, Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Time Spent: 1h 10m > Remaining Estimate: 0h > > Its common that a single key needs to be compact, and operators need to do > the following > 1) go from key -> token > 2) generate range > 3) call nodetool compact with this range > We can simply this workflow by adding this to compact > nodetool compact ks.tbl -k “key1" -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17537) nodetool compact should support using a key string to find the range to avoid operators having to manually do this
[ https://issues.apache.org/jira/browse/CASSANDRA-17537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526702#comment-17526702 ] Brandon Williams commented on CASSANDRA-17537: -- That is an old known flaky: CASSANDRA-16677 > nodetool compact should support using a key string to find the range to avoid > operators having to manually do this > -- > > Key: CASSANDRA-17537 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17537 > Project: Cassandra > Issue Type: New Feature > Components: Local/Compaction, Tool/nodetool >Reporter: David Capwell >Assignee: David Capwell >Priority: Normal > Time Spent: 1h 10m > Remaining Estimate: 0h > > Its common that a single key needs to be compact, and operators need to do > the following > 1) go from key -> token > 2) generate range > 3) call nodetool compact with this range > We can simply this workflow by adding this to compact > nodetool compact ks.tbl -k “key1" -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
