[jira] [Commented] (CASSANDRA-18553) Generate.sh -s param to skip autodetection of tests
[ https://issues.apache.org/jira/browse/CASSANDRA-18553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730922#comment-17730922 ] Andres de la Peña commented on CASSANDRA-18553: --- They look good to me, +1 > Generate.sh -s param to skip autodetection of tests > --- > > Key: CASSANDRA-18553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18553 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > When using generate.sh auto detection of modified tests always kicks in. That > can be a problem during dev when you want to test a given set of tests > without getting all the others in the way. Also when you want to run the > script without having to checkout the extra branches auto detection needs. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18553) Generate.sh -s param to skip autodetection of tests
[ https://issues.apache.org/jira/browse/CASSANDRA-18553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730858#comment-17730858 ] Berenguer Blasi commented on CASSANDRA-18553: - All PRs added and tested manually > Generate.sh -s param to skip autodetection of tests > --- > > Key: CASSANDRA-18553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18553 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > When using generate.sh auto detection of modified tests always kicks in. That > can be a problem during dev when you want to test a given set of tests > without getting all the others in the way. Also when you want to run the > script without having to checkout the extra branches auto detection needs. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18553) Generate.sh -s param to skip autodetection of tests
[ https://issues.apache.org/jira/browse/CASSANDRA-18553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730092#comment-17730092 ] Berenguer Blasi commented on CASSANDRA-18553: - I was going to, just waiting on your +1 so thanks. I'll do this next :-) > Generate.sh -s param to skip autodetection of tests > --- > > Key: CASSANDRA-18553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18553 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > When using generate.sh auto detection of modified tests always kicks in. That > can be a problem during dev when you want to test a given set of tests > without getting all the others in the way. Also when you want to run the > script without having to checkout the extra branches auto detection needs. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18553) Generate.sh -s param to skip autodetection of tests
[ https://issues.apache.org/jira/browse/CASSANDRA-18553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730050#comment-17730050 ] Andres de la Peña commented on CASSANDRA-18553: --- I've just merged CASSANDRA-17997. > Generate.sh -s param to skip autodetection of tests > --- > > Key: CASSANDRA-18553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18553 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > When using generate.sh auto detection of modified tests always kicks in. That > can be a problem during dev when you want to test a given set of tests > without getting all the others in the way. Also when you want to run the > script without having to checkout the extra branches auto detection needs. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18553) Generate.sh -s param to skip autodetection of tests
[ https://issues.apache.org/jira/browse/CASSANDRA-18553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729659#comment-17729659 ] Berenguer Blasi commented on CASSANDRA-18553: - CASSANDRA-17997 should merge soon. Let's wait and I'll get this done. > Generate.sh -s param to skip autodetection of tests > --- > > Key: CASSANDRA-18553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18553 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > When using generate.sh auto detection of modified tests always kicks in. That > can be a problem during dev when you want to test a given set of tests > without getting all the others in the way. Also when you want to run the > script without having to checkout the extra branches auto detection needs. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18553) Generate.sh -s param to skip autodetection of tests
[ https://issues.apache.org/jira/browse/CASSANDRA-18553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726610#comment-17726610 ] Andres de la Peña commented on CASSANDRA-18553: --- [~bereng] you might be interested in being second reviewer on CASSANDRA-17997. It adds a parameter to specify the base branch, which is one of the reasons why the detector of changes sometimes add more tests than expected when the patch hasn't been rebased in a while. > Generate.sh -s param to skip autodetection of tests > --- > > Key: CASSANDRA-18553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18553 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > > When using generate.sh auto detection of modified tests always kicks in. That > can be a problem during dev when you want to test a given set of tests > without getting all the others in the way. Also when you want to run the > script without having to checkout the extra branches auto detection needs. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18553) Generate.sh -s param to skip autodetection of tests
[ https://issues.apache.org/jira/browse/CASSANDRA-18553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726603#comment-17726603 ] Andres de la Peña commented on CASSANDRA-18553: --- Looks good to me, I have left a couple of nits on the PR. This should also be applied to 3.0 and 3.11, since the automatic detection also exists on those branches. By the way, shouldn't this be a new feature rather than a bug? > Generate.sh -s param to skip autodetection of tests > --- > > Key: CASSANDRA-18553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18553 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > When using generate.sh auto detection of modified tests always kicks in. That > can be a problem during dev when you want to test a given set of tests > without getting all the others in the way. Also when you want to run the > script without having to checkout the extra branches auto detection needs. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18553) Generate.sh -s param to skip autodetection of tests
[ https://issues.apache.org/jira/browse/CASSANDRA-18553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726490#comment-17726490 ] Berenguer Blasi commented on CASSANDRA-18553: - [~adelapena] this should be a quick one as we've already talked about it. If you're happy I'll push the rest of the PRs. > Generate.sh -s param to skip autodetection of tests > --- > > Key: CASSANDRA-18553 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18553 > Project: Cassandra > Issue Type: Bug > Components: CI >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.x > > > When using generate.sh auto detection of modified tests always kicks in. That > can be a problem during dev when you want to test a given set of tests > without getting all the others in the way. Also when you want to run the > script without having to checkout the extra branches auto detection needs. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
