[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847146#comment-17847146 ] Stefan Miklosovic commented on CASSANDRA-18712: --- Oh well, so there are failures when upgrading to this version. It is all in the respective logs. I think it is not just about bumping the versions ... Naively bumping it compiles but tests are failing. The failure is something like this: {noformat} failed on teardown with "Unexpected error found in node logs (see stdout for full details). Errors: [[node1] "WARN [RMI TCP Connection(2)-127.0.0.1] 2024-05-16 13:47:46,320 Slf4jExceptionHandler.java:50 - You've configured your queue to use a deprecated RollCycle (net.openhft.chronicle.queue.RollCycles.TEST_SECONDLY) please consider switching to net.openhft.chronicle.queue.rollcycles.TestRollCycles.TEST_SECONDLY, as the RollCycle constant you've nominated will be removed in a future release!"]" {noformat} [CASSANDRA-18712|https://github.com/instaclustr/cassandra/tree/CASSANDRA-18712] {noformat} java17_pre-commit_tests ✓ j17_build4m 30s ✓ j17_cqlsh_dtests_py311 6m 57s ✓ j17_cqlsh_dtests_py311_vnode 7m 18s ✓ j17_cqlsh_dtests_py387m 17s ✓ j17_cqlsh_dtests_py38_vnode 7m 20s ✓ j17_cqlshlib_cython_tests8m 15s ✓ j17_cqlshlib_tests 6m 42s ✓ j17_jvm_dtests_latest_vnode 21m 0s ✓ j17_unit_tests 14m 12s ✓ j17_utests_oa13m 5s ✕ j17_dtests 36m 30s auditlog_test.TestAuditlog test_archive_on_shutdown auditlog_test.TestAuditlog test_archive_on_startup auditlog_test.TestAuditlog test_archiving auditlog_test.TestAuditlog test_archiving_fql auditlog_test.TestAuditlog test_fql_nodetool_options fqltool_test.TestFQLTool test_compare fqltool_test.TestFQLTool test_compare_mismatch fqltool_test.TestFQLTool test_jvmdtest fqltool_test.TestFQLTool test_replay fqltool_test.TestFQLTool test_unclean_enable ✕ j17_dtests_latest 36m 43s auditlog_test.TestAuditlog test_archive_on_shutdown auditlog_test.TestAuditlog test_archive_on_startup auditlog_test.TestAuditlog test_archiving auditlog_test.TestAuditlog test_archiving_fql auditlog_test.TestAuditlog test_fql_nodetool_options fqltool_test.TestFQLTool test_compare fqltool_test.TestFQLTool test_compare_mismatch fqltool_test.TestFQLTool test_jvmdtest fqltool_test.TestFQLTool test_replay configuration_test.TestConfiguration test_change_durable_writes fqltool_test.TestFQLTool test_unclean_enable ✕ j17_dtests_vnode38m 20s auditlog_test.TestAuditlog test_archive_on_shutdown auditlog_test.TestAuditlog test_archive_on_startup auditlog_test.TestAuditlog test_archiving auditlog_test.TestAuditlog test_archiving_fql auditlog_test.TestAuditlog test_fql_nodetool_options fqltool_test.TestFQLTool test_compare fqltool_test.TestFQLTool test_compare_mismatch fqltool_test.TestFQLTool test_jvmdtest fqltool_test.TestFQLTool test_replay fqltool_test.TestFQLTool test_unclean_enable ✕ j17_jvm_dtests 22m 57s ✕ j17_utests_latest 14m 25s org.apache.cassandra.net.ConnectionTest testTimeout java17_separate_tests java11_pre-commit_tests ✓ j11_build7m 33s ✓ j11_cqlsh_dtests_py311 8m 26s ✓ j11_cqlsh_dtests_py311_vnode 8m 8s ✓ j11_cqlsh_dtests_py388m 29s ✓ j11_cqlsh_dtests_py38_vnode 10m 33s ✓ j11_cqlshlib_cython_tests11m 8s ✓ j11_cqlshlib_tests 11m 39s ✓ j11_jvm_dtests 27m 21s ✓ j11_jvm_dtests_latest_vnode 21m 8s ✓ j11_unit_tests 17m 33s ✓ j11_utests_oa 18m 53s ✓ j11_utests_system_keyspace_directory18m 43s ✓ j17_cqlsh_dtests_py311 6m 51s ✓ j17_cqlsh_dtests_py311_vnode 7m 20s ✓ j17_cqlsh_dtests_py38 7m 6s ✓ j17_cqlsh_dtests_py38_vnode 7m 33s ✓ j17_cqlshlib_cython_tests7m 28s ✓ j17_cqlshlib_tests 8m 41s ✓ j17_unit_tests 14m 23s ✓ j17_utests_latest
[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846989#comment-17846989 ] Michael Semb Wever commented on CASSANDRA-18712: Upgrading these dependencies repeatedly is a PITA – you have to make sure they're compatible with each other, have a clean transitive tree with no conflicts, all found in public repos, all found in the bom, and ideally not early-access versions. But we do want to encourage s390x work, or it'll never have any chance of being _officially accepted_. [~Nayana], how difficult it is for you to continue your s390x work having to manually re-apply this patch…? bq. I checked that the versions match the versions in the bom. Which bom version ? (link please) bq. there is not any "not early access" of 2.24, they stopped with 2.24ea28 and next one was 2.25ea0. 2.24 releases do exist, ref: https://github.com/OpenHFT/Chronicle-Bytes/releases/tag/chronicle-bytes-2.24.29. And the bom in repo1 has them ( https://repo1.maven.org/maven2/net/openhft/chronicle-bom/ ) but I've no idea about where the other 2.24 releases are to be found in public maven repos. We can build and deploy them to https://repository.apache.org/content/groups/public/ if we really want to… > Update Chronicle bytes > -- > > Key: CASSANDRA-18712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18712 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Nayana Thorat >Assignee: Nayana Thorat >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/OpenHFT/Chronicle-Bytes/pull/485] fixes test failures of > cassandra on s390x. > This patch is merged and available in chronicle-bytes-2.24ea7 and later > releases. > possible to update Chronicle bytes and related pkg versions in Cassandra > (https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml)? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846988#comment-17846988 ] Brandon Williams commented on CASSANDRA-18712: -- It looks like this version has the same concerns as we had in CASSANDRA-18538, namely that chronicle will spy on users. See https://github.com/OpenHFT/Chronicle-Queue/blob/chronicle-queue-5.25ea13/DISCLAIMER.adoc We first upgraded to a problematic version in CASSANDRA-18049 though. I think we need to revisit this. /cc [~mck] > Update Chronicle bytes > -- > > Key: CASSANDRA-18712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18712 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Nayana Thorat >Assignee: Nayana Thorat >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/OpenHFT/Chronicle-Bytes/pull/485] fixes test failures of > cassandra on s390x. > This patch is merged and available in chronicle-bytes-2.24ea7 and later > releases. > possible to update Chronicle bytes and related pkg versions in Cassandra > (https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml)? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846941#comment-17846941 ] Stefan Miklosovic commented on CASSANDRA-18712: --- What I would personally do is that I would wait with this ticket until 5.1 is imminent. The reason for doing so is that while we release 5.1, we will most likely want to update these dependencies again because they are being actively developed. I do not see any critical reason why should be this merged _right now_ - only if we want to enable people to test trunk on s390x as mentioned in the description that this is a blocker for them, but we do not officially support that architecture anyway ... > Update Chronicle bytes > -- > > Key: CASSANDRA-18712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18712 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Nayana Thorat >Assignee: Nayana Thorat >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/OpenHFT/Chronicle-Bytes/pull/485] fixes test failures of > cassandra on s390x. > This patch is merged and available in chronicle-bytes-2.24ea7 and later > releases. > possible to update Chronicle bytes and related pkg versions in Cassandra > (https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml)? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846919#comment-17846919 ] Stefan Miklosovic commented on CASSANDRA-18712: --- I verified that a tarball with this change contains {code:java} chronicle-bytes-2.25ea9.jar chronicle-core-2.25ea13.jar chronicle-queue-5.25ea13.jar chronicle-threads-2.25ea6.jar chronicle-wire-2.25ea12.jar{code} while the old tarball contains {code:java} chronicle-bytes-2.23.33.jar chronicle-core-2.23.36.jar chronicle-queue-5.23.37.jar chronicle-threads-2.23.25.jar chronicle-wire-2.23.39.jar{code} There are no changes in libs dir except these. When it comes to pom.xml (after ant mvn-install), it is same. > Update Chronicle bytes > -- > > Key: CASSANDRA-18712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18712 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Nayana Thorat >Assignee: Nayana Thorat >Priority: Normal > Fix For: 5.x > > > [https://github.com/OpenHFT/Chronicle-Bytes/pull/485] fixes test failures of > cassandra on s390x. > This patch is merged and available in chronicle-bytes-2.24ea7 and later > releases. > possible to update Chronicle bytes and related pkg versions in Cassandra > (https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml)? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846897#comment-17846897 ] Stefan Miklosovic commented on CASSANDRA-18712: --- thanks [~Nayana] , I ll take a look. > Update Chronicle bytes > -- > > Key: CASSANDRA-18712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18712 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Nayana Thorat >Assignee: Nayana Thorat >Priority: Normal > Fix For: 5.x > > > [https://github.com/OpenHFT/Chronicle-Bytes/pull/485] fixes test failures of > cassandra on s390x. > This patch is merged and available in chronicle-bytes-2.24ea7 and later > releases. > possible to update Chronicle bytes and related pkg versions in Cassandra > (https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml)? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846889#comment-17846889 ] Nayana Thorat commented on CASSANDRA-18712: --- [~mck] I have verified current Cassandra master (commit : 48f6a318796c02ba8e2f22b078958200ba37c9a6) with upgraded chronicle versions. Build is successful as well as tests are passing. Below are the chronicle versions tested: {code:java} diff --git a/.build/parent-pom-template.xml b/.build/parent-pom-template.xml index 0c0e5d4ccc..89334e943c 100644 --- a/.build/parent-pom-template.xml +++ b/.build/parent-pom-template.xml @@ -828,7 +828,7 @@ net.openhft chronicle-queue - 5.23.37 + 5.25ea13 tools @@ -844,7 +844,7 @@ net.openhft chronicle-core - 2.23.36 + 2.25ea13 chronicle-analytics @@ -859,7 +859,7 @@ net.openhft chronicle-bytes - 2.23.33 + 2.25ea9 annotations @@ -870,7 +870,7 @@ net.openhft chronicle-wire - 2.23.39 + 2.25ea12 compiler @@ -886,7 +886,7 @@ net.openhft chronicle-threads - 2.23.25 + 2.25ea6 {code} > Update Chronicle bytes > -- > > Key: CASSANDRA-18712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18712 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Nayana Thorat >Priority: Normal > Fix For: 5.x > > > [https://github.com/OpenHFT/Chronicle-Bytes/pull/485] fixes test failures of > cassandra on s390x. > This patch is merged and available in chronicle-bytes-2.24ea7 and later > releases. > possible to update Chronicle bytes and related pkg versions in Cassandra > (https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml)? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802107#comment-17802107 ] Michael Semb Wever commented on CASSANDRA-18712: For chronicle-bytes 2.24 the latest early access release is now 2.24ea20 https://repo1.maven.org/maven2/net/openhft/chronicle-bytes/ Are we confident that - this is stable enough for us? and - this is compatible with our existing versions of chronicle dependencies we use ? https://repo1.maven.org/maven2/net/openhft/chronicle-bytes/2.24ea20/chronicle-bytes-2.24ea20.pom We need to ensure both stability and compatibility over all chronicle deps. Can you try bumping the chronicle-bytes version, and seeing how our transitive dep tree changes ? All chronicle deps included should only be those we have already declared in the pom, and match the version numbers as declared. (It is ok to bump other chronicle versions if we must, but all must be downloadable from repo1.m.o and no boms must be pulled in.) > Update Chronicle bytes > -- > > Key: CASSANDRA-18712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18712 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Nayana Thorat >Priority: Normal > Fix For: 5.x > > > [https://github.com/OpenHFT/Chronicle-Bytes/pull/485] fixes test failures of > cassandra on s390x. > This patch is merged and available in chronicle-bytes-2.24ea7 and later > releases. > possible to update Chronicle bytes and related pkg versions in Cassandra > (https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml)? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17800491#comment-17800491 ] Nayana Thorat commented on CASSANDRA-18712: --- Any update on this? > Update Chronicle bytes > -- > > Key: CASSANDRA-18712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18712 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Nayana Thorat >Priority: Normal > Fix For: 5.x > > > [https://github.com/OpenHFT/Chronicle-Bytes/pull/485] fixes test failures of > cassandra on s390x. > This patch is merged and available in chronicle-bytes-2.24ea7 and later > releases. > possible to update Chronicle bytes and related pkg versions in Cassandra > (https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml)? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749261#comment-17749261 ] Brandon Williams commented on CASSANDRA-18712: -- We also need to be cognizant of CASSANDRA-18538 > Update Chronicle bytes > -- > > Key: CASSANDRA-18712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18712 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Nayana Thorat >Priority: Normal > Fix For: 5.x > > > [https://github.com/OpenHFT/Chronicle-Bytes/pull/485] fixes test failures of > cassandra on s390x. > This patch is merged and available in chronicle-bytes-2.24ea7 and later > releases. > possible to update Chronicle bytes and related pkg versions in Cassandra > (https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml)? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749257#comment-17749257 ] Michael Semb Wever commented on CASSANDRA-18712: Yes, and all the Chronicle deps need upgrading together, and done are not always available from maven repos we pull from. Needs a bit of investigation, but might need waiting... > Update Chronicle bytes > -- > > Key: CASSANDRA-18712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18712 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Nayana Thorat >Priority: Normal > Fix For: 5.x > > > [https://github.com/OpenHFT/Chronicle-Bytes/pull/485] fixes test failures of > cassandra on s390x. > This patch is merged and available in chronicle-bytes-2.24ea7 and later > releases. > possible to update Chronicle bytes and related pkg versions in Cassandra > (https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml)? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18712) Update Chronicle bytes
[ https://issues.apache.org/jira/browse/CASSANDRA-18712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17749159#comment-17749159 ] Brandon Williams commented on CASSANDRA-18712: -- Judging by how many 2.24 'ea' releases there have been, that doesn't seem like a fully baked version yet to me. Are these beta releases? > Update Chronicle bytes > -- > > Key: CASSANDRA-18712 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18712 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Nayana Thorat >Priority: Normal > Fix For: 5.x > > > [https://github.com/OpenHFT/Chronicle-Bytes/pull/485] fixes test failures of > cassandra on s390x. > This patch is merged and available in chronicle-bytes-2.24ea7 and later > releases. > possible to update Chronicle bytes and related pkg versions in Cassandra > (https://github.com/apache/cassandra/blob/trunk/.build/parent-pom-template.xml)? > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org