[jira] [Commented] (CASSANDRA-18734) SAI result retriever is filtering too many rows
[
https://issues.apache.org/jira/browse/CASSANDRA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762701#comment-17762701
]
Andres de la Peña commented on CASSANDRA-18734:
---
Committed to 5.0 as
[9ce86e0ff8b6344b528a0640f9dafa23f97dd85a|https://github.com/apache/cassandra/commit/9ce86e0ff8b6344b528a0640f9dafa23f97dd85a]
and merged to
[{{trunk}}|https://github.com/apache/cassandra/commit/1ba458c900fd5f5c41e341a195402b9f7acb12ab].
> SAI result retriever is filtering too many rows
> ---
>
> Key: CASSANDRA-18734
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18734
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/SAI
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
> Attachments: flamegraph.svg, image-2023-08-08-13-48-19-701.png,
> image-2023-08-08-13-49-19-576.png
>
>
> Performance tests on SAI have shown that the number of rows being filtered
> for wide row partitions is more than expected. For a 10k row/partition test -
> limit 10, the following has been observed.
> !image-2023-08-08-13-49-19-576.png|width=952,height=368!
> This is not the expected outcome of row-awareness and needs investigating.
> The number of rows read should, roughly, match the number of partitions read.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18734) SAI result retriever is filtering too many rows
[ https://issues.apache.org/jira/browse/CASSANDRA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762695#comment-17762695 ] Andres de la Peña commented on CASSANDRA-18734: --- The only CI failure is CASSANDRA-16677. I'm committing. > SAI result retriever is filtering too many rows > --- > > Key: CASSANDRA-18734 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18734 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Attachments: flamegraph.svg, image-2023-08-08-13-48-19-701.png, > image-2023-08-08-13-49-19-576.png > > > Performance tests on SAI have shown that the number of rows being filtered > for wide row partitions is more than expected. For a 10k row/partition test - > limit 10, the following has been observed. > !image-2023-08-08-13-49-19-576.png|width=952,height=368! > This is not the expected outcome of row-awareness and needs investigating. > The number of rows read should, roughly, match the number of partitions read. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18734) SAI result retriever is filtering too many rows
[
https://issues.apache.org/jira/browse/CASSANDRA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762457#comment-17762457
]
Andres de la Peña commented on CASSANDRA-18734:
---
CI for {{trunk}}:
|[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/3199/workflows/43169f30-ca8f-41e5-9e04-28700d1e8bb9]|[j17|https://app.circleci.com/pipelines/github/adelapena/cassandra/3199/workflows/dcd4e5e1-cd7a-4972-9a4f-3b7b7e44efb9]|
> SAI result retriever is filtering too many rows
> ---
>
> Key: CASSANDRA-18734
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18734
> Project: Cassandra
> Issue Type: Bug
> Components: Feature/SAI
>Reporter: Mike Adamson
>Assignee: Mike Adamson
>Priority: Normal
> Attachments: flamegraph.svg, image-2023-08-08-13-48-19-701.png,
> image-2023-08-08-13-49-19-576.png
>
>
> Performance tests on SAI have shown that the number of rows being filtered
> for wide row partitions is more than expected. For a 10k row/partition test -
> limit 10, the following has been observed.
> !image-2023-08-08-13-49-19-576.png|width=952,height=368!
> This is not the expected outcome of row-awareness and needs investigating.
> The number of rows read should, roughly, match the number of partitions read.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18734) SAI result retriever is filtering too many rows
[ https://issues.apache.org/jira/browse/CASSANDRA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762454#comment-17762454 ] Andres de la Peña commented on CASSANDRA-18734: --- That failure on the j17 run is CASSANDRA-18737. Looks good to me, +1. > SAI result retriever is filtering too many rows > --- > > Key: CASSANDRA-18734 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18734 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Attachments: flamegraph.svg, image-2023-08-08-13-48-19-701.png, > image-2023-08-08-13-49-19-576.png > > > Performance tests on SAI have shown that the number of rows being filtered > for wide row partitions is more than expected. For a 10k row/partition test - > limit 10, the following has been observed. > !image-2023-08-08-13-49-19-576.png|width=952,height=368! > This is not the expected outcome of row-awareness and needs investigating. > The number of rows read should, roughly, match the number of partitions read. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18734) SAI result retriever is filtering too many rows
[ https://issues.apache.org/jira/browse/CASSANDRA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17762448#comment-17762448 ] Mike Adamson commented on CASSANDRA-18734: -- Final test runs are here: |[JDK11|https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/278/workflows/2b0d0a26-c175-4ef2-bf7d-6df982f9dfa6]| |[JDK17|https://app.circleci.com/pipelines/github/mike-tr-adamson/cassandra/278/workflows/1643c3f9-b55f-4285-bfce-0c792fc36a71]| There is a failure on the 17 test run that looks unrelated. > SAI result retriever is filtering too many rows > --- > > Key: CASSANDRA-18734 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18734 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Attachments: flamegraph.svg, image-2023-08-08-13-48-19-701.png, > image-2023-08-08-13-49-19-576.png > > > Performance tests on SAI have shown that the number of rows being filtered > for wide row partitions is more than expected. For a 10k row/partition test - > limit 10, the following has been observed. > !image-2023-08-08-13-49-19-576.png|width=952,height=368! > This is not the expected outcome of row-awareness and needs investigating. > The number of rows read should, roughly, match the number of partitions read. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18734) SAI result retriever is filtering too many rows
[ https://issues.apache.org/jira/browse/CASSANDRA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761334#comment-17761334 ] Caleb Rackliffe commented on CASSANDRA-18734: - +1 (w/ one small outstanding comment [here|https://github.com/apache/cassandra/pull/2645#discussion_r1313190721]) > SAI result retriever is filtering too many rows > --- > > Key: CASSANDRA-18734 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18734 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Attachments: flamegraph.svg, image-2023-08-08-13-48-19-701.png, > image-2023-08-08-13-49-19-576.png > > > Performance tests on SAI have shown that the number of rows being filtered > for wide row partitions is more than expected. For a 10k row/partition test - > limit 10, the following has been observed. > !image-2023-08-08-13-49-19-576.png|width=952,height=368! > This is not the expected outcome of row-awareness and needs investigating. > The number of rows read should, roughly, match the number of partitions read. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18734) SAI result retriever is filtering too many rows
[ https://issues.apache.org/jira/browse/CASSANDRA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17761093#comment-17761093 ] Caleb Rackliffe commented on CASSANDRA-18734: - Made my first pass at review, and things mostly look good. Left my comments in the PR. > SAI result retriever is filtering too many rows > --- > > Key: CASSANDRA-18734 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18734 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Attachments: flamegraph.svg, image-2023-08-08-13-48-19-701.png, > image-2023-08-08-13-49-19-576.png > > > Performance tests on SAI have shown that the number of rows being filtered > for wide row partitions is more than expected. For a 10k row/partition test - > limit 10, the following has been observed. > !image-2023-08-08-13-49-19-576.png|width=952,height=368! > This is not the expected outcome of row-awareness and needs investigating. > The number of rows read should, roughly, match the number of partitions read. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18734) SAI result retriever is filtering too many rows
[ https://issues.apache.org/jira/browse/CASSANDRA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759914#comment-17759914 ] Mike Adamson commented on CASSANDRA-18734: -- 5.0 and trunk here: |[5.0|https://github.com/apache/cassandra/pull/2645]|Circle CI| |[trunk|https://github.com/apache/cassandra/pull/2646]|Circle CI| > SAI result retriever is filtering too many rows > --- > > Key: CASSANDRA-18734 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18734 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Attachments: flamegraph.svg, image-2023-08-08-13-48-19-701.png, > image-2023-08-08-13-49-19-576.png > > > Performance tests on SAI have shown that the number of rows being filtered > for wide row partitions is more than expected. For a 10k row/partition test - > limit 10, the following has been observed. > !image-2023-08-08-13-49-19-576.png|width=952,height=368! > This is not the expected outcome of row-awareness and needs investigating. > The number of rows read should, roughly, match the number of partitions read. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18734) SAI result retriever is filtering too many rows
[ https://issues.apache.org/jira/browse/CASSANDRA-18734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754707#comment-17754707 ] Mike Adamson commented on CASSANDRA-18734: -- Here is a flamegraph against the latest changes: [^flamegraph.svg] > SAI result retriever is filtering too many rows > --- > > Key: CASSANDRA-18734 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18734 > Project: Cassandra > Issue Type: Bug > Components: Feature/SAI >Reporter: Mike Adamson >Assignee: Mike Adamson >Priority: Normal > Attachments: image-2023-08-08-13-48-19-701.png, > image-2023-08-08-13-49-19-576.png > > > Performance tests on SAI have shown that the number of rows being filtered > for wide row partitions is more than expected. For a 10k row/partition test - > limit 10, the following has been observed. > !image-2023-08-08-13-49-19-576.png|width=952,height=368! > This is not the expected outcome of row-awareness and needs investigating. > The number of rows read should, roughly, match the number of partitions read. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
