[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785485#comment-17785485 ] Stefan Miklosovic commented on CASSANDRA-18903: --- 4.0 j11 https://app.circleci.com/pipelines/github/instaclustr/cassandra/3480/workflows/823e1f3e-e12b-41ee-a67d-2e2ffa767549 4.0 j8 https://app.circleci.com/pipelines/github/instaclustr/cassandra/3480/workflows/935f41e4-4f5d-4a49-8a79-f5b632c5ea5a 4.1 j11 https://app.circleci.com/pipelines/github/instaclustr/cassandra/3479/workflows/0aa0c9cb-0fdb-41f2-b29c-246a38d742e9 4.1 j8 https://app.circleci.com/pipelines/github/instaclustr/cassandra/3479/workflows/83b0103e-5484-405d-bfc1-3969f55f7928 5.0 j17 https://app.circleci.com/pipelines/github/instaclustr/cassandra/3481/workflows/8cbdeb03-5be7-49f9-bc36-63e457e37a7d 5.0 j11 https://app.circleci.com/pipelines/github/instaclustr/cassandra/3478/workflows/8068b707-0a2a-4324-b86f-e63e99d6b36d trunk j17 https://app.circleci.com/pipelines/github/instaclustr/cassandra/3477/workflows/819f2e20-1767-48f2-9755-b89561f8b5a4 trunk j11 https://app.circleci.com/pipelines/github/instaclustr/cassandra/3483/workflows/6e7a85b7-7c51-401f-9107-12592e0e69cc > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-beta, 5.x > > Attachments: ci_summary.html, result_details.tar.gz > > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785086#comment-17785086 ] Stefan Miklosovic commented on CASSANDRA-18903: --- I ll take care of the mergring next week (Monday-ish) if nobody beats me to it. I ll do the builds during weekend if necessary. > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-beta, 5.x > > Attachments: ci_summary.html, result_details.tar.gz > > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785076#comment-17785076 ] Brandon Williams commented on CASSANDRA-18903: -- FWIW, I don't think the upgrade dtests are necessary here. > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-beta, 5.x > > Attachments: ci_summary.html, result_details.tar.gz > > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17785073#comment-17785073 ] Abe Ratnofsky commented on CASSANDRA-18903: --- Tests are blocked on a Python environment issue for the python-upgrade-dtests suite - see: https://the-asf.slack.com/archives/CK23JSY2K/p1699649583486419?thread_ts=1699633023.063369=CK23JSY2K > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-beta, 5.x > > Attachments: ci_summary.html, result_details.tar.gz > > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784985#comment-17784985 ] Abe Ratnofsky commented on CASSANDRA-18903: --- I'm running the tests for all branches now - for some reason Jira is failing when I try to upload ci_summary + result_details multiple times - so far haven't seen any test failures for touched / related tests, only unrelated tests. Will post more results when they're done processing. > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-beta, 5.x > > Attachments: ci_summary.html, result_details.tar.gz > > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784984#comment-17784984 ] Michael Semb Wever commented on CASSANDRA-18903: Don't we need CI runs for all branches ? (and strictly speaking repeated runs on all touched/related tests) > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-beta, 5.x > > Attachments: ci_summary.html, result_details.tar.gz > > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784981#comment-17784981 ] Abe Ratnofsky commented on CASSANDRA-18903: --- Results for trunk patch: Results for 4.1 patch: Only test failures are related to CI infrastructure behaving weirdly for dtest / upgrade. [^ci_summary.html] [^result_details.tar.gz] Results for trunk patch: failures in bootstrap_test.py::TestBootstrap::test_cleanup and replica_side_filtering_test.py::TestSecondaryIndexes::test_complementary_update_with_limit_on_static_column_with_not_empty_partitions which both seem like flakes to me. All branches have been rebased and are ready to commit. > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-beta, 5.x > > Attachments: ci_summary.html, result_details.tar.gz > > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784955#comment-17784955 ] Stefan Miklosovic commented on CASSANDRA-18903: --- [~aratnofsky] can be this merged? I see all necessary approvals. This would be great to see in 5.0. I can merge that on your behalf. > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > Attachments: ci_summary.html, result_details.tar.gz > > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780912#comment-17780912 ] Marcus Eriksson commented on CASSANDRA-18903: - +1 > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1499#comment-1499 ] Caleb Rackliffe commented on CASSANDRA-18903: - Approved all 4 PRs w/ a couple minor nits. > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776370#comment-17776370 ] Abe Ratnofsky commented on CASSANDRA-18903: --- PRs up: ||Release branch||PR|| |trunk|https://github.com/apache/cassandra/pull/2810| |5.0|https://github.com/apache/cassandra/pull/2811| |4.1|https://github.com/apache/cassandra/pull/2812| |4.0|https://github.com/apache/cassandra/pull/2813| > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771986#comment-17771986 ] Abe Ratnofsky commented on CASSANDRA-18903: --- Yep, looks like it. I'll prep branches against all the relevant versions. > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18903) Incremental repair never cleans up completed sessions from CoordinatorSessions.sessions
[ https://issues.apache.org/jira/browse/CASSANDRA-18903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771648#comment-17771648 ] Brandon Williams commented on CASSANDRA-18903: -- Looks like 4.0-5.0 are also affected? > Incremental repair never cleans up completed sessions from > CoordinatorSessions.sessions > --- > > Key: CASSANDRA-18903 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18903 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair >Reporter: Abe Ratnofsky >Assignee: Abe Ratnofsky >Priority: Normal > > Currently, there is nothing cleaning up repaired sessions from > org.apache.cassandra.repair.consistent.CoordinatorSessions#sessions. This > causes memory to leak for cluster members with long uptimes and lots of > incremental repair. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
