[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786243#comment-17786243 ] Stefan Miklosovic commented on CASSANDRA-18992: --- [5.0 j17 pre-commit|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3499/workflows/7c1c8d38-12ae-4c09-821e-51a466afb246] [5.0 j11 pre-commit|https://app.circleci.com/pipelines/github/instaclustr/cassandra/3499/workflows/375ed1ad-4c45-4a13-99dd-73810aa63bbb] I consider builds for trunk the waste of resources, there is no difference. I am starting the merging process. > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786036#comment-17786036 ] Stefan Miklosovic commented on CASSANDRA-18992: --- Thanks, I will take care of the merging. > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786034#comment-17786034 ] Ariel Weisberg commented on CASSANDRA-18992: +1 TY for cleaning this up. Sorry again for the delay. > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17786026#comment-17786026 ] Ariel Weisberg commented on CASSANDRA-18992: Sorry for the delay, looking now. > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[
https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784589#comment-17784589
]
Ekaterina Dimitrova commented on CASSANDRA-18992:
-
{quote}Anything else to add to this one? Shall we approach formal builds? I am
+1 on this.
{quote}
[~aweisberg] 's final approval, he promised to take a look soon :)
> Exclude jna transitive dependecy from the ohc library
> -
>
> Key: CASSANDRA-18992
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18992
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0-beta, 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The concern is related to the JNA dependency on the ohc library. We are now
> using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on
> version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has
> been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212
> to support running nodes on the arm64 architecture, so I assume that JNA
> 4.1.0 is no longer in Casssandra's classpath.
> The common practice in the Cassandra project is to exclude these kinds of
> transitive dependencies when they are explicitly mentioned in the main parent
> pom, since Ant may resolve them incorrectly. See comment:
> https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784079#comment-17784079 ] Stefan Miklosovic commented on CASSANDRA-18992: --- Anything else to add to this one? Shell we approach formal builds? I am +1 on this. > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784069#comment-17784069 ] Ekaterina Dimitrova commented on CASSANDRA-18992: - You are right,[~smiklosovic], that was already explored in CASSANDRA-18799. We will take care of this later. > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784067#comment-17784067 ] Stefan Miklosovic commented on CASSANDRA-18992: --- Good work on the verification of ohc running with 5.13! I agree with Maxim's observation that ohc is running with 5.13 already as that is what we ship with libs. Anyway it is good to see that tests for ohc with jna 5.13 are still looking good for extra assurance. This might theoretically affect people importing Cassandra into a Maven project as a dependency, but I checked it there and it is already overriden by 5.13.0 neverthless we can still exclude this explicitly. BTW what is also interesting is that, if you notice, there is "ohc-core-j8-0.5.1.jar" among libs too. Is not it strange that there is "Java 8" dependency for a project running with Java 11+ only? Should not be that removed too? Is that still necessary to have around? > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[
https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783701#comment-17783701
]
Maxim Muzafarov commented on CASSANDRA-18992:
-
{quote}
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18992-review-5.0
{quote}
The test results look good as well. As for the asm dependency, it only appears
in the 0.7.5 release and it doesn't exist in 0.5.1
https://github.com/snazy/ohc/blob/develop/pom.xml#L162
https://github.com/snazy/ohc/blob/0.5.1/pom.xml
> Exclude jna transitive dependecy from the ohc library
> -
>
> Key: CASSANDRA-18992
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18992
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0-beta, 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The concern is related to the JNA dependency on the ohc library. We are now
> using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on
> version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has
> been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212
> to support running nodes on the arm64 architecture, so I assume that JNA
> 4.1.0 is no longer in Casssandra's classpath.
> The common practice in the Cassandra project is to exclude these kinds of
> transitive dependencies when they are explicitly mentioned in the main parent
> pom, since Ant may resolve them incorrectly. See comment:
> https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[
https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783695#comment-17783695
]
Maxim Muzafarov commented on CASSANDRA-18992:
-
So I can't get a clean run on the 0.5.1 branch, because the following tests
fail (this failure is related to release/0.5.1 branch):
https://github.com/Mmuzaf/ohc/actions/runs/6787087412/job/18449112785
{code}
Failed tests:
ChunkedCacheImplTest.testHotKeyBufferIterator:573 expected [true] but found
[false]
ChunkedCacheImplTest.testHotKeyIterator:417 expected [true] but found [false]
ChunkedFixedCacheImplTest.testHotKeyBufferIterator:499 expected [true] but
found [false]
ChunkedFixedCacheImplTest.testHotKeyIterator:365 expected [true] but found
[false]
{code}
If we ignore these tests, then the execution of all tests will be successful
for both
JNA 4.1.0
https://github.com/Mmuzaf/ohc/actions/runs/6787282956/job/18449740138
JNA 5.13.0
https://github.com/Mmuzaf/ohc/actions/runs/6787399168/job/18450119146
> Exclude jna transitive dependecy from the ohc library
> -
>
> Key: CASSANDRA-18992
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18992
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0-beta, 5.0.x, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The concern is related to the JNA dependency on the ohc library. We are now
> using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on
> version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has
> been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212
> to support running nodes on the arm64 architecture, so I assume that JNA
> 4.1.0 is no longer in Casssandra's classpath.
> The common practice in the Cassandra project is to exclude these kinds of
> transitive dependencies when they are explicitly mentioned in the main parent
> pom, since Ant may resolve them incorrectly. See comment:
> https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17783442#comment-17783442 ] Ekaterina Dimitrova commented on CASSANDRA-18992: - In the meantime, I started the preliminary 5.0 CI run here - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=18992-review-5.0] Let's see what it will show. [~aweisberg], can you be a second reviewer here, please? > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782309#comment-17782309 ] Ekaterina Dimitrova commented on CASSANDRA-18992: - I agree with you, but also, there was a mention on the other ticket that we do not exercise in tests very well the usage of ohc in the C* codebase. Thus, I was trying to be more careful. Any thoughts about what I mentioned about ASM? > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782274#comment-17782274 ] Maxim Muzafarov commented on CASSANDRA-18992: - [~e.dimitrova] Sure, give me a few days to build the ohc project and re-check all tests, I'll check it and get back here. However, since we use the Cassandra build/lib/jar classpath directory, which contains a newer version of the JNA library, to run tests it should be enough to run CI on the Cassandra side to ensure that this exclusion doesn't break anything. A newer version of the JNA will be in use by the tests that have row cache enabled (basically row_cache_size > 0). > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0-beta, 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781893#comment-17781893 ] Ekaterina Dimitrova commented on CASSANDRA-18992: - My understanding is that we want the exclusion so that ohc uses the newer version of JNA we provide to Cassandra. [~mmuzaf] , to be on the safe side, do you mind to run the ohc tests in its repo with the bumped JNA version, please? (From the commit which points to the ohc version we are on) Looking into the ohc dependencies, I am not sure also about asm which was bumped in C* to accommodate newer JDK version. [~aweisberg], do you mind to take a look, too? > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18992) Exclude jna transitive dependecy from the ohc library
[ https://issues.apache.org/jira/browse/CASSANDRA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781891#comment-17781891 ] Maxim Muzafarov commented on CASSANDRA-18992: - [~e.dimitrova] Hi, I've prepared an exclution for both the trunk and 5.0 branches. Can you take a look? > Exclude jna transitive dependecy from the ohc library > - > > Key: CASSANDRA-18992 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18992 > Project: Cassandra > Issue Type: Task > Components: Dependencies >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > The concern is related to the JNA dependency on the ohc library. We are now > using version 0.5.1 of the ohc library in Cassandra. The ohc 0.5.1 depends on > version 4.1.0 of the net.java.dev.jna . For the Cassandra project, JNA has > been updated since the 4.0 release version up to JNA 5.6.0 in CASSANDRA-16212 > to support running nodes on the arm64 architecture, so I assume that JNA > 4.1.0 is no longer in Casssandra's classpath. > The common practice in the Cassandra project is to exclude these kinds of > transitive dependencies when they are explicitly mentioned in the main parent > pom, since Ant may resolve them incorrectly. See comment: > https://issues.apache.org/jira/browse/CASSANDRA-14667?focusedCommentId=17765091=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17765091 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
