[jira] [Commented] (CASSANDRA-19393) Introduce nodetool command to dump cluster metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817325#comment-17817325 ] Stefan Miklosovic commented on CASSANDRA-19393: --- Well, this is something I would like to address as well. The current implementation of dumping in MBean is creating a file, as you said, and it will return just a file name. However, nodetool is meant to be used anywhere, remotely, so what happens when I execute nodetool on a machine different from a machine the node runs on? You see? E.g. admins can just have some jumbox to a cluster they manage, they do not necessarily have access to nodes themselves. So they would not be able to read it. I think that we could return the whole string and it would be then parsed on the nodetool. It might be also possible to send the format as an agrument to MBean method and server would returned that formatted already. If the string is "too big", we could compress it on server and decompress it on the client but this is not the objective of this ticket and it is a subject of further discussion. > Introduce nodetool command to dump cluster metadata > --- > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Adding a nodetool command for dumping cluster metadata would be handy when > compared to making a JMX call. Nodetool has two more commands related to > cluster metadata service (describecms and reconfigurecms). These commands can > be grouped for simplicity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) Introduce nodetool command to dump cluster metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817315#comment-17817315 ] n.v.harikrishna commented on CASSANDRA-19393: - The current dump command calls `CMSOperations.dumpClusterMetadata` mbean which dumps the serialized metadata to a file and this command just prints the file location. Printing metadata probably can go as part of CASSANDRA-19151 (another ticket I'm working on)? There I can make it to print as JSON/YAML format. > Introduce nodetool command to dump cluster metadata > --- > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Adding a nodetool command for dumping cluster metadata would be handy when > compared to making a JMX call. Nodetool has two more commands related to > cluster metadata service (describecms and reconfigurecms). These commands can > be grouped for simplicity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) Introduce nodetool command to dump cluster metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817310#comment-17817310 ] Stefan Miklosovic commented on CASSANDRA-19393: --- Thanks [~marcuse] , I needed to see this example ... [~n.v.harikrishna] btw while you go to dump it, would it be possible to also support YAML and JSON formats so somebody else might consume it programmatically / more comfortably? YAML / JSON format upon dumping is quite widespread in nodetool. > Introduce nodetool command to dump cluster metadata > --- > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Adding a nodetool command for dumping cluster metadata would be handy when > compared to making a JMX call. Nodetool has two more commands related to > cluster metadata service (describecms and reconfigurecms). These commands can > be grouped for simplicity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) Introduce nodetool command to dump cluster metadata
[
https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817307#comment-17817307
]
Marcus Eriksson commented on CASSANDRA-19393:
-
I think this makes sense, we have {{repair_admin}} which does sub commands for
example:
https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/RepairAdmin.java
> Introduce nodetool command to dump cluster metadata
> ---
>
> Key: CASSANDRA-19393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19393
> Project: Cassandra
> Issue Type: Improvement
> Components: Transactional Cluster Metadata
>Reporter: n.v.harikrishna
>Assignee: n.v.harikrishna
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Adding a nodetool command for dumping cluster metadata would be handy when
> compared to making a JMX call. Nodetool has two more commands related to
> cluster metadata service (describecms and reconfigurecms). These commands can
> be grouped for simplicity.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) Introduce nodetool command to dump cluster metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817305#comment-17817305 ] Stefan Miklosovic commented on CASSANDRA-19393: --- I am on the edge if we should do this or not. While it does make sense to group this, there is some kind of a habit in nodetool that each command is standalone. Is there any precedent in nodetool which would do it like you suggest? Also, there is a lot of references in the tests which use existing commands. You will need to fix all the tests which are calling the existing commands and change them. > Introduce nodetool command to dump cluster metadata > --- > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Adding a nodetool command for dumping cluster metadata would be handy when > compared to making a JMX call. Nodetool has two more commands related to > cluster metadata service (describecms and reconfigurecms). These commands can > be grouped for simplicity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) Introduce nodetool command to dump cluster metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817296#comment-17817296 ] n.v.harikrishna commented on CASSANDRA-19393: - Raised PR with the changes: [https://github.com/apache/cassandra/pull/3101] Just realized that there is one more command `initializecms`. It can be moved too under the same command group if agreed. > Introduce nodetool command to dump cluster metadata > --- > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Adding a nodetool command for dumping cluster metadata would be handy when > compared to making a JMX call. Nodetool has two more commands related to > cluster metadata service (describecms and reconfigurecms). These commands can > be grouped for simplicity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) Introduce nodetool command to dump cluster metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817291#comment-17817291 ] Stefan Miklosovic commented on CASSANDRA-19393: --- Ah right ... interesting. > Introduce nodetool command to dump cluster metadata > --- > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > > Adding a nodetool command for dumping cluster metadata would be handy when > compared to making a JMX call. Nodetool has two more commands related to > cluster metadata service (describecms and reconfigurecms). These commands can > be grouped for simplicity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) Introduce nodetool command to dump cluster metadata
[
https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817289#comment-17817289
]
n.v.harikrishna commented on CASSANDRA-19393:
-
Sorry! I think I did not mention clearly in the description. I mean to make all
cms related commands as sub commands under command group "cms" so that it would
look something like:
{code:java}
nodetool cms describe
nodetool cms reconfigure
nodetool cms dump
{code}
> Introduce nodetool command to dump cluster metadata
> ---
>
> Key: CASSANDRA-19393
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19393
> Project: Cassandra
> Issue Type: Improvement
> Components: Transactional Cluster Metadata
>Reporter: n.v.harikrishna
>Assignee: n.v.harikrishna
>Priority: Normal
>
> Adding a nodetool command for dumping cluster metadata would be handy when
> compared to making a JMX call. Nodetool has two more commands related to
> cluster metadata service (describecms and reconfigurecms). These commands can
> be grouped for simplicity.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-19393) Introduce nodetool command to dump cluster metadata
[ https://issues.apache.org/jira/browse/CASSANDRA-19393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17817279#comment-17817279 ] Stefan Miklosovic commented on CASSANDRA-19393: --- I think we can hide dumping behind / as part of describe but I am not sure we should merge describe command with reconfigure one. cc [~marcuse] > Introduce nodetool command to dump cluster metadata > --- > > Key: CASSANDRA-19393 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19393 > Project: Cassandra > Issue Type: Improvement > Components: Transactional Cluster Metadata >Reporter: n.v.harikrishna >Assignee: n.v.harikrishna >Priority: Normal > > Adding a nodetool command for dumping cluster metadata would be handy when > compared to making a JMX call. Nodetool has two more commands related to > cluster metadata service (describecms and reconfigurecms). These commands can > be grouped for simplicity. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
