[jira] [Commented] (CASSANDRA-3946) BulkRecordWriter shouldn't stream any empty data/index files that might be created at end of flush
[ https://issues.apache.org/jira/browse/CASSANDRA-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255883#comment-13255883 ] Jonathan Ellis commented on CASSANDRA-3946: --- LGTM. Could you also post a version against 1.0, Yuki? > BulkRecordWriter shouldn't stream any empty data/index files that might be > created at end of flush > -- > > Key: CASSANDRA-3946 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3946 > Project: Cassandra > Issue Type: Bug >Reporter: Chris Goffinet >Assignee: Yuki Morishita >Priority: Minor > Fix For: 1.1.1 > > Attachments: 0001-Abort-SSTableWriter-when-exception-occured.patch, > 0001-CASSANDRA-3946-BulkRecordWriter-shouldn-t-stream-any.patch > > > If by chance, we flush sstables during BulkRecordWriter (we have seen it > happen), I want to make sure we don't try to stream them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3946) BulkRecordWriter shouldn't stream any empty data/index files that might be created at end of flush
[ https://issues.apache.org/jira/browse/CASSANDRA-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253757#comment-13253757 ] Brandon Williams commented on CASSANDRA-3946: - I suspect if there is a problem here it's actually in UnsortedSimpleSSTableWriter. > BulkRecordWriter shouldn't stream any empty data/index files that might be > created at end of flush > -- > > Key: CASSANDRA-3946 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3946 > Project: Cassandra > Issue Type: Bug >Reporter: Chris Goffinet >Assignee: Yuki Morishita >Priority: Minor > Fix For: 1.1.1 > > Attachments: > 0001-CASSANDRA-3946-BulkRecordWriter-shouldn-t-stream-any.patch > > > If by chance, we flush sstables during BulkRecordWriter (we have seen it > happen), I want to make sure we don't try to stream them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3946) BulkRecordWriter shouldn't stream any empty data/index files that might be created at end of flush
[ https://issues.apache.org/jira/browse/CASSANDRA-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246543#comment-13246543 ] Brandon Williams commented on CASSANDRA-3946: - I'm not convinced that having the loader skip empty files is right yet. Why are empty files being created? > BulkRecordWriter shouldn't stream any empty data/index files that might be > created at end of flush > -- > > Key: CASSANDRA-3946 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3946 > Project: Cassandra > Issue Type: Bug >Reporter: Chris Goffinet >Assignee: Brandon Williams >Priority: Minor > Fix For: 1.1.1 > > Attachments: > 0001-CASSANDRA-3946-BulkRecordWriter-shouldn-t-stream-any.patch > > > If by chance, we flush sstables during BulkRecordWriter (we have seen it > happen), I want to make sure we don't try to stream them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3946) BulkRecordWriter shouldn't stream any empty data/index files that might be created at end of flush
[ https://issues.apache.org/jira/browse/CASSANDRA-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213667#comment-13213667 ] Jonathan Ellis commented on CASSANDRA-3946: --- I'm not sure I understand -- is it trying to stream a sstable that's in the process of being written? Or did you actually get zero-length files created? The latter is Not Supposed To Happen. > BulkRecordWriter shouldn't stream any empty data/index files that might be > created at end of flush > -- > > Key: CASSANDRA-3946 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3946 > Project: Cassandra > Issue Type: Bug >Reporter: Chris Goffinet >Assignee: Chris Goffinet >Priority: Minor > Fix For: 1.1.0 > > Attachments: > 0001-CASSANDRA-3946-BulkRecordWriter-shouldn-t-stream-any.patch > > > If by chance, we flush sstables during BulkRecordWriter (we have seen it > happen), I want to make sure we don't try to stream them. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
