[jira] [Commented] (CASSANDRA-3988) NullPointerException in org.apache.cassandra.service.AntiEntropyService when repair finds a keyspace with no CFs

2012-03-03 Thread Jonathan Ellis (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221628#comment-13221628
 ] 

Jonathan Ellis commented on CASSANDRA-3988:
---

+1 on v2, then

> NullPointerException in org.apache.cassandra.service.AntiEntropyService when 
> repair finds a keyspace with no CFs
> 
>
> Key: CASSANDRA-3988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3988
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.0.7
>Reporter: Bill Hathaway
>Assignee: Sylvain Lebresne
>Priority: Minor
> Fix For: 1.0.9
>
> Attachments: 3988-v2.txt, 3988.txt
>
>
> 2012-03-01 21:38:09,039 [RMI TCP Connection(142)-10.253.106.21] INFO  
> StorageService - Starting repair command #15, repairing 3 ranges.
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] INFO  AntiEntropyService - 
> [repair #d68369f0-63e6-11e1--8add8b9398fd] new session: will sync 
> /10.253.106.21, /10.253.106.248, /10.253.106.247 on range 
> (85070591730234615865843651857942052864,106338239662793269832304564822427566080]
>  for PersonalizationDataService2.[]
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] ERROR 
> AbstractCassandraDaemon - Fatal exception in thread 
> Thread[AntiEntropySessions:14,5,RMI Runtime]
> java.lang.NullPointerException
> at 
> org.apache.cassandra.service.AntiEntropyService$RepairSession.runMayThrow(AntiEntropyService.java:691)
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3988) NullPointerException in org.apache.cassandra.service.AntiEntropyService when repair finds a keyspace with no CFs

2012-03-03 Thread Bill Hathaway (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221615#comment-13221615
 ] 

Bill Hathaway commented on CASSANDRA-3988:
--

@Sylvain - Correct, we are not enabling assertions (no -ea flag).

> NullPointerException in org.apache.cassandra.service.AntiEntropyService when 
> repair finds a keyspace with no CFs
> 
>
> Key: CASSANDRA-3988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3988
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.0.7
>Reporter: Bill Hathaway
>Assignee: Sylvain Lebresne
>Priority: Minor
> Fix For: 1.0.9
>
> Attachments: 3988-v2.txt, 3988.txt
>
>
> 2012-03-01 21:38:09,039 [RMI TCP Connection(142)-10.253.106.21] INFO  
> StorageService - Starting repair command #15, repairing 3 ranges.
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] INFO  AntiEntropyService - 
> [repair #d68369f0-63e6-11e1--8add8b9398fd] new session: will sync 
> /10.253.106.21, /10.253.106.248, /10.253.106.247 on range 
> (85070591730234615865843651857942052864,106338239662793269832304564822427566080]
>  for PersonalizationDataService2.[]
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] ERROR 
> AbstractCassandraDaemon - Fatal exception in thread 
> Thread[AntiEntropySessions:14,5,RMI Runtime]
> java.lang.NullPointerException
> at 
> org.apache.cassandra.service.AntiEntropyService$RepairSession.runMayThrow(AntiEntropyService.java:691)
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3988) NullPointerException in org.apache.cassandra.service.AntiEntropyService when repair finds a keyspace with no CFs

2012-03-03 Thread Sylvain Lebresne (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221561#comment-13221561
 ] 

Sylvain Lebresne commented on CASSANDRA-3988:
-

@Bill do you run with assertion disabled?

> NullPointerException in org.apache.cassandra.service.AntiEntropyService when 
> repair finds a keyspace with no CFs
> 
>
> Key: CASSANDRA-3988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3988
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.0.7
>Reporter: Bill Hathaway
>Assignee: Sylvain Lebresne
>Priority: Minor
> Fix For: 1.0.9
>
> Attachments: 3988-v2.txt, 3988.txt
>
>
> 2012-03-01 21:38:09,039 [RMI TCP Connection(142)-10.253.106.21] INFO  
> StorageService - Starting repair command #15, repairing 3 ranges.
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] INFO  AntiEntropyService - 
> [repair #d68369f0-63e6-11e1--8add8b9398fd] new session: will sync 
> /10.253.106.21, /10.253.106.248, /10.253.106.247 on range 
> (85070591730234615865843651857942052864,106338239662793269832304564822427566080]
>  for PersonalizationDataService2.[]
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] ERROR 
> AbstractCassandraDaemon - Fatal exception in thread 
> Thread[AntiEntropySessions:14,5,RMI Runtime]
> java.lang.NullPointerException
> at 
> org.apache.cassandra.service.AntiEntropyService$RepairSession.runMayThrow(AntiEntropyService.java:691)
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3988) NullPointerException in org.apache.cassandra.service.AntiEntropyService when repair finds a keyspace with no CFs

2012-03-02 Thread Jonathan Ellis (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221137#comment-13221137
 ] 

Jonathan Ellis commented on CASSANDRA-3988:
---

bq. We assert this can't happen

That's a good point -- how is this getting by the RepairSession constructor?  
Do we have two bugs?

> NullPointerException in org.apache.cassandra.service.AntiEntropyService when 
> repair finds a keyspace with no CFs
> 
>
> Key: CASSANDRA-3988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3988
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.0.7
>Reporter: Bill Hathaway
>Assignee: Sylvain Lebresne
>Priority: Minor
> Fix For: 1.0.9
>
> Attachments: 3988-v2.txt, 3988.txt
>
>
> 2012-03-01 21:38:09,039 [RMI TCP Connection(142)-10.253.106.21] INFO  
> StorageService - Starting repair command #15, repairing 3 ranges.
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] INFO  AntiEntropyService - 
> [repair #d68369f0-63e6-11e1--8add8b9398fd] new session: will sync 
> /10.253.106.21, /10.253.106.248, /10.253.106.247 on range 
> (85070591730234615865843651857942052864,106338239662793269832304564822427566080]
>  for PersonalizationDataService2.[]
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] ERROR 
> AbstractCassandraDaemon - Fatal exception in thread 
> Thread[AntiEntropySessions:14,5,RMI Runtime]
> java.lang.NullPointerException
> at 
> org.apache.cassandra.service.AntiEntropyService$RepairSession.runMayThrow(AntiEntropyService.java:691)
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3988) NullPointerException in org.apache.cassandra.service.AntiEntropyService when repair finds a keyspace with no CFs

2012-03-02 Thread Brandon Williams (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221084#comment-13221084
 ] 

Brandon Williams commented on CASSANDRA-3988:
-

We assert this can't happen:

{code}
java.lang.AssertionError: Repairing no column families seems pointless, doesn't 
it
{code}

So I'm not sure how we get into this situation, but apparently we can.

> NullPointerException in org.apache.cassandra.service.AntiEntropyService when 
> repair finds a keyspace with no CFs
> 
>
> Key: CASSANDRA-3988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3988
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.0.7
>Reporter: Bill Hathaway
>Assignee: Sylvain Lebresne
>Priority: Minor
> Fix For: 1.0.9
>
> Attachments: 3988.txt
>
>
> 2012-03-01 21:38:09,039 [RMI TCP Connection(142)-10.253.106.21] INFO  
> StorageService - Starting repair command #15, repairing 3 ranges.
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] INFO  AntiEntropyService - 
> [repair #d68369f0-63e6-11e1--8add8b9398fd] new session: will sync 
> /10.253.106.21, /10.253.106.248, /10.253.106.247 on range 
> (85070591730234615865843651857942052864,106338239662793269832304564822427566080]
>  for PersonalizationDataService2.[]
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] ERROR 
> AbstractCassandraDaemon - Fatal exception in thread 
> Thread[AntiEntropySessions:14,5,RMI Runtime]
> java.lang.NullPointerException
> at 
> org.apache.cassandra.service.AntiEntropyService$RepairSession.runMayThrow(AntiEntropyService.java:691)
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-3988) NullPointerException in org.apache.cassandra.service.AntiEntropyService when repair finds a keyspace with no CFs

2012-03-02 Thread Jonathan Ellis (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221067#comment-13221067
 ] 

Jonathan Ellis commented on CASSANDRA-3988:
---

don't we use length == 0 CFs in forceTableRepair to mean "load a list of all of 
them?"  iow i think the check needs to be on the result of 
getValidColumnFamilies.

> NullPointerException in org.apache.cassandra.service.AntiEntropyService when 
> repair finds a keyspace with no CFs
> 
>
> Key: CASSANDRA-3988
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3988
> Project: Cassandra
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 1.0.7
>Reporter: Bill Hathaway
>Assignee: Sylvain Lebresne
>Priority: Minor
> Fix For: 1.0.9
>
> Attachments: 3988.txt
>
>
> 2012-03-01 21:38:09,039 [RMI TCP Connection(142)-10.253.106.21] INFO  
> StorageService - Starting repair command #15, repairing 3 ranges.
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] INFO  AntiEntropyService - 
> [repair #d68369f0-63e6-11e1--8add8b9398fd] new session: will sync 
> /10.253.106.21, /10.253.106.248, /10.253.106.247 on range 
> (85070591730234615865843651857942052864,106338239662793269832304564822427566080]
>  for PersonalizationDataService2.[]
> 2012-03-01 21:38:09,039 [AntiEntropySessions:14] ERROR 
> AbstractCassandraDaemon - Fatal exception in thread 
> Thread[AntiEntropySessions:14,5,RMI Runtime]
> java.lang.NullPointerException
> at 
> org.apache.cassandra.service.AntiEntropyService$RepairSession.runMayThrow(AntiEntropyService.java:691)
> at 
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:30)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:662)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira